r829: foreach() warnings -= 3

diff --git a/includes/functions.php b/includes/functions.php
index 623b39bdaddd75b87aff47adc31d497371276b44..a87dfbacaec4537eda4aa03b9df89b623b7491d7 100755 (executable)
--- a/includes/functions.php
+++ b/includes/functions.php
@@ -170,7 +170,7 @@ function construct_custom_fields($bug = array(), $ignore21mask = false, $nodefau
        
        $fieldvalues = $bugsys->db->query_first("SELECT * FROM " . TABLE_PREFIX . "bugvaluefill WHERE bugid = " . intval($bug['bugid']));
        
-       $fieldbits = '';
+       $fieldbits = array();
        
        foreach ($fields AS $field)
        {

diff --git a/showreport.php b/showreport.php
index e3e872eddcdc44cb32306345237baaa208d4bca8..7014ee92153bd49165197ab6c631ec639b2cf528 100644 (file)
--- a/showreport.php
+++ b/showreport.php
@@ -124,7 +124,7 @@ if ($show['edit'])
        }
        
        $show['assign'] = ((can_perform('canassign', $bug['productid'])) ? true : false);
-       if (can_perform('canassign', $bug['productid']))
+       if (can_perform('canassign', $bug['productid']) AND is_array($bugsys->datastore['assignto']))
        {
                foreach ($bugsys->datastore['assignto'] AS $dev)
                {
@@ -155,20 +155,23 @@ if ($show['edit'])
        
        $select['autoactions'] = '';
        $show['autoactions'] = false;
-       foreach ($bugsys->datastore['autoaction'] AS $action)
+       if (is_array($bugsys->datastore['autoaction']))
        {
-               $label = $action['name'];
-               $value = $action['actionid'];
-               $selected = false;
-               eval('$select[autoaction] .= "' . $template->fetch('selectoption') . '";');
-               $show['autoactions'] = true;
-       }
-       if ($show['autoactions'])
-       {
-               $label = '';
-               $value = 0;
-               $selected = true;
-               eval('$select[autoaction] = "' . $template->fetch('selectoption') . '" . $select[autoaction];');
+               foreach ($bugsys->datastore['autoaction'] AS $action)
+               {
+                       $label = $action['name'];
+                       $value = $action['actionid'];
+                       $selected = false;
+                       eval('$select[autoaction] .= "' . $template->fetch('selectoption') . '";');
+                       $show['autoactions'] = true;
+               }
+               if ($show['autoactions'])
+               {
+                       $label = '';
+                       $value = 0;
+                       $selected = true;
+                       eval('$select[autoaction] = "' . $template->fetch('selectoption') . '" . $select[autoaction];');
+               }
        }
 }