r1294: Add maxlenth attributes to all <input:text> elements so the database doesn...

diff --git a/docs/changes.txt b/docs/changes.txt
index 43755e1522e7ce983965108eea52e36d3d6612c8..20d35e80b6948e8cb4c5ea71de3392c3febb01d9 100644 (file)
--- a/docs/changes.txt
+++ b/docs/changes.txt
@@ -18,6 +18,7 @@
 - Adding a quick search feature to the header bar (http://www.bluestatic.org/bugs/showreport.php?bugid=57)
 - Fixed an occurence in header.tpl where the $stylevar align wasn't used, but a hard-coded one was
 - Only allow JPG, JPEG, PNG, and GIF attachments to be displayed inline because all other types could lead to an XSS attack
+- Added maxlength attributes to all <input type="text"/> fields so the database doesn't truncate (http://www.bluestatic.org/bugs/showreport.php?bugid=58)
 
 1.1.3
 ===============================

diff --git a/templates/editattach.tpl b/templates/editattach.tpl
index 67a9aa74fe48ac99d354fe006522e3d270ef517b..06b9af568b40204b4beea6bc25f34f9f30cf141c 100644 (file)
--- a/templates/editattach.tpl
+++ b/templates/editattach.tpl
@@ -25,7 +25,7 @@ $header
        </div>
        
        <div class="box-mid" style="text-align: $stylevar[left]">
-               <div><strong>{@"Description"}:</strong> <input name="description" type="text" size="35" value="$attachment[description]" /></div>
+               <div><strong>{@"Description"}:</strong> <input name="description" type="text" size="35" maxlength="250" value="$attachment[description]" /></div>
                <div><strong>{@"Obsolete"}:</strong> <input name="obsolete" type="checkbox" value="1"<if condition="$attachment['obsolete']"> checked="checked"</if> /></div>
        </div>
 </div>

diff --git a/templates/newattach.tpl b/templates/newattach.tpl
index 73e59f9f30ab52f2e612729d99ecce69d744a63e..aa019c21c13ad594645df00892077a991ab051a2 100644 (file)
--- a/templates/newattach.tpl
+++ b/templates/newattach.tpl
@@ -28,7 +28,7 @@ $header
        
        <div class="box-mid box-margmod-bottom" style="text-align: $stylevar[left]">
                <div><input name="attachment" type="file" /></div>
-               <div><strong>{@"Description"}:</strong> <input name="description" type="text" size="35" value="{$bugsys->in['description']}" /></div>
+               <div><strong>{@"Description"}:</strong> <input name="description" type="text" size="35" value="{$bugsys->in['description']}" maxlength="250" /></div>
        </div>
        
        <if condition="$show['obsoletes']">

diff --git a/templates/newreport.tpl b/templates/newreport.tpl
index 22e321281c75257664328b4b92af8343ac6def79..ae07d3502567748aa016add93e0a9179cfd2baf0 100644 (file)
--- a/templates/newreport.tpl
+++ b/templates/newreport.tpl
@@ -66,7 +66,7 @@ $header
                <!-- summary -->
                <fieldset>
                        <legend>{@"Summary"} $help[summary]</legend>
-                       <div class="field"><input type="text" name="summary" size="25" value="{$bugsys->in['summary']}" style="width: 100%" /></div>
+                       <div class="field"><input type="text" name="summary" size="25" value="{$bugsys->in['summary']}" style="width: 100%" maxlength="250" /></div>
                </fieldset>
                <!-- / summary -->
                

diff --git a/templates/showreport.tpl b/templates/showreport.tpl
index 21dc1bc5c4c08cae2eb12458e7bfa93b75aa884b..54c930e15d91a690bc9c08383c83ee769000f5a5 100644 (file)
--- a/templates/showreport.tpl
+++ b/templates/showreport.tpl
@@ -114,7 +114,7 @@ $header
                        <legend>{@"Summary"} $help[summary]</legend>
                        <div class="field">
                                <if condition="$show['edit']">
-                                       <input type="text" name="summary" size="25" value="$bug[summary]" style="width: 100%" />
+                                       <input type="text" name="summary" size="25" value="$bug[summary]" style="width: 100%" maxlength="250" />
                                <else />
                                        $bug[summary]
                                </if>

diff --git a/templates/userctrl.tpl b/templates/userctrl.tpl
index d8ace7d0d72f4e1d6e56773608a4b18d1d72510b..fa15e407f70264f3352110026d8f22a585b3a397 100644 (file)
--- a/templates/userctrl.tpl
+++ b/templates/userctrl.tpl
@@ -31,7 +31,7 @@ $header
                                <div class="box-mid">
                                        <fieldset>
                                                <legend>{@"Display Name"}</legend>
-                                               <input type="text" name="displayname" value="{$userinfo['displayname']}" size="25" style="width: 100%" />
+                                               <input type="text" name="displayname" value="{$userinfo['displayname']}" size="25" style="width: 100%" maxlength="250" />
                                        </fieldset>
                                        
                                        <fieldset>
@@ -74,30 +74,30 @@ $header
                                        {@"Please enter your password to change these fields"}:
                                        <br />
                                        
-                                       <input type="password" name="validate" size="35" />
+                                       <input type="password" name="validate" size="35" maxlength="250" />
                                </div>
                                
                                <div class="box-mid box-margmod-top">
                                        <fieldset>
                                                <legend>{@"Password"}</legend>
-                                               <input type="password" name="password_change" size="25" style="width: 100%" />
+                                               <input type="password" name="password_change" size="25" style="width: 100%" maxlength="250" />
                                        </fieldset>
                                        
                                        <fieldset>
                                                <legend>{@"Confirm Password"}</legend>
-                                               <input type="password" name="password_confirm" size="25" style="width: 100%" />
+                                               <input type="password" name="password_confirm" size="25" style="width: 100%" maxlength="250" />
                                        </fieldset>
                                </div>
                                
                                <div class="box-mid box-margmod-top">
                                        <fieldset>
                                                <legend>{@"Email"}</legend>
-                                               <input type="text" name="email_change" size="25" value="$email" style="width: 100%" />
+                                               <input type="text" name="email_change" size="25" value="$email" style="width: 100%" maxlength="250" />
                                        </fieldset>
                                        
                                        <fieldset>
                                                <legend>{@"Confirm Email"}</legend>
-                                               <input type="text" name="email_confirm" size="25" value="$email_confirm" style="width: 100%" />
+                                               <input type="text" name="email_confirm" size="25" value="$email_confirm" style="width: 100%" maxlength="250" />
                                        </fieldset>
                                </div>
                        </div>