r1533: Apparently some systems don't like our pass-by-reference use of ProcessBugData...

diff --git a/docs/changes.txt b/docs/changes.txt
index 898bfeff809b7ced7b7ab39721a754a7b486fcdd..e4f71891803a148185c1fdfbfeddad8cb7517832 100644 (file)
--- a/docs/changes.txt
+++ b/docs/changes.txt
@@ -8,6 +8,7 @@
 - Fixed: Some email roles would not get notified under certain circumstances because the list of users to notify was reset
 - Fixed: Errors would occurr on installation due to a problem with not loading all the data at the right time
 - Enhancement: The installer will now check to ensure that all the proper MySQL permissions are enabled
+- Fixed: A PHP warning could be generated due to passing an argument by reference (bug://report/78)
 
 1.2.0 Beta 2
 ===============================

diff --git a/favorite.php b/favorite.php
index 0f2c73dccc5fd43818be9e76aea5e062a578a2ff..b3eb1268b1384df8fc2cff5907ddd215dacbd19f 100644 (file)
--- a/favorite.php
+++ b/favorite.php
@@ -94,7 +94,7 @@ if ($_REQUEST['do'] == 'manage')
        while ($bug = $db->fetch_array($favorites))
        {
                $funct->exec_swap_bg('altcolor', '');
-               ProcessBugDataForDisplay(&$bug, $funct->bgcolour);
+               $bug = ProcessBugDataForDisplay($bug, $funct->bgcolour);
                $bugs .= $sort->constructRow($bug);
        }
        

diff --git a/index.php b/index.php
index a314dedf4e7b4588fd36194fa0f9f4ce886b47d9..7daae74a5fc5b1e71b26ee63c5f79f1f6a430455 100644 (file)
--- a/index.php
+++ b/index.php
@@ -34,6 +34,8 @@ $focus['index'] = 'focus';
 require_once('./global.php');
 require_once('./includes/class_sort.php');
 
+error_reporting(E_ALL & ~E_NOTICE);
+
 if (!can_perform('canviewbugs'))
 {
        $message->errorPermission();
@@ -65,7 +67,7 @@ $bugs_fetch = $db->query($sort->fetch_sql_query(null, $pagination->fetchLimit($p
 while ($bug = $db->fetch_array($bugs_fetch))
 {
        $funct->exec_swap_bg('altcolor', '');   
-       ProcessBugDataForDisplay(&$bug, $funct->bgcolour);
+       $bug = ProcessBugDataForDisplay($bug, $funct->bgcolour);
        $bugs .= $sort->constructRow($bug);
 }
 

diff --git a/search.php b/search.php
index 1a3fdb11464fdee1cfdc99742f35106d042041db..c16b69a7ca14611894d20d9a3afa4f84e8a1ab83 100644 (file)
--- a/search.php
+++ b/search.php
@@ -697,7 +697,7 @@ if ($_POST['do'] == 'results')
        while ($bug = $db->fetch_array($search))
        {
                $funct->exec_swap_bg('altcolor', '');
-               ProcessBugDataForDisplay(&$bug, $funct->bgcolour);
+               $bug = ProcessBugDataForDisplay($bug, $funct->bgcolour);
                $bugs .= $sort->constructRow($bug, "&hilight=$hilight");
        }