Fix un-quoted constant keys in eval expressions.

diff --git a/newreport.php b/newreport.php
index f66f265cc754af896d7c33c3900d1a54a43fdaea..13a75aa97d019452180c4c988cd70e689e31c815 100644 (file)
--- a/newreport.php
+++ b/newreport.php
@@ -167,7 +167,7 @@ if ($_REQUEST['do'] == 'add')
                        $value = $dev['userid'];
                        $label = construct_user_display($dev, false);
                        $selected = ($bugsys->in['assignedto'] ? ($bugsys->in['assignedto'] == $dev['userid']) : ($dev['userid'] == $bugsys->options['defaultassign']));
-                       eval('$select[dev] .= "' . $template->fetch('selectoption') . '";');
+                       eval('$select["dev"] .= "' . $template->fetch('selectoption') . '";');
                }
        }
 

diff --git a/search.php b/search.php
index d04b40b95267cee9e463149f1eda45edee5aa7f4..1e61c1ef9991b351f79fe6ef4d367a80006a7fb0 100644 (file)
--- a/search.php
+++ b/search.php
@@ -161,7 +161,7 @@ if ($_REQUEST['do'] == 'search')
                {
                        $value = $dev['userid'];
                        $label = construct_user_display($dev, false);
-                       eval('$select[dev] .= "' . $template->fetch('selectoption') . '";');
+                       eval('$select["dev"] .= "' . $template->fetch('selectoption') . '";');
                }
 
                eval('$template->flush("' . $template->fetch('search') . '");');
@@ -479,13 +479,13 @@ if ($_REQUEST['do'] == 'update')
        $value = '0';
        $label = '';
        $selected = true;
-       eval('$select[dev] .= "' . $template->fetch('selectoption') . '";');
+       eval('$select["dev"] .= "' . $template->fetch('selectoption') . '";');
        $selected = false;
        foreach (bugdar::$datastore['assignto'] AS $dev)
        {
                $value = $dev['userid'];
                $label = construct_user_display($dev, false);
-               eval('$select[dev] .= "' . $template->fetch('selectoption') . '";');
+               eval('$select["dev"] .= "' . $template->fetch('selectoption') . '";');
        }
 
        eval('$template->flush("' . $template->fetch('search_update') . '");');

diff --git a/showreport.php b/showreport.php
index fe3e51d29d19fee94e4d1a618a5a7eb0082c7433..051fceb794d94797c5e74a173e9509e851d8c86a 100644 (file)
--- a/showreport.php
+++ b/showreport.php
@@ -112,7 +112,7 @@ if ($show['edit'])
                        $value = $dev['userid'];
                        $selected = (($dev['userid'] == $bug['assignedto']) ? true : false);
                        $label = construct_user_display($dev, false);
-                       eval('$select[dev] .= "' . $template->fetch('selectoption') . '";');
+                       eval('$select["dev"] .= "' . $template->fetch('selectoption') . '";');
                }
        }
 
@@ -143,7 +143,7 @@ if ($show['edit'])
                        $label = $action['name'];
                        $value = $action['actionid'];
                        $selected = false;
-                       eval('$select[automation] .= "' . $template->fetch('selectoption') . '";');
+                       eval('$select["automation"] .= "' . $template->fetch('selectoption') . '";');
                        $show['automations'] = true;
                }
                if ($show['automations'])
@@ -151,7 +151,7 @@ if ($show['edit'])
                        $label = '';
                        $value = 0;
                        $selected = true;
-                       eval('$select[automation] = "' . $template->fetch('selectoption') . '" . $select[automation];');
+                       eval('$select["automation"] = "' . $template->fetch('selectoption') . '" . $select["automation"];');
                }
        }
 }