Change while($o = $db->fetch_array($r)) to foreach($r as $o)

diff --git a/admin/automation.php b/admin/automation.php
index 5d1ea04749d350624168d23317815169ddb8d957..3f6509b54bc00381a9d064499bef4aca334e2e20 100644 (file)
--- a/admin/automation.php
+++ b/admin/automation.php
@@ -170,7 +170,7 @@ if ($_REQUEST['do'] == 'add' OR $_REQUEST['do'] == 'edit')
        // -------------------------------------------------------------------
        // custom fields
        $fields_fetch = $db->query("SELECT * FROM " . TABLE_PREFIX . "bugfield ORDER BY fieldid ASC");
-       while ($field = $db->fetch_array($fields_fetch))
+       foreach ($fields_fetch as $field)
        {
                switch ($field['type'])
                {
@@ -220,7 +220,7 @@ if ($_REQUEST['do'] == 'modify')
        $admin->table_head(T('Automations'));
        
        $actions = $db->query("SELECT * FROM " . TABLE_PREFIX . "automation ORDER BY name ASC");
-       while ($action = $db->fetch_array($actions))
+       foreach ($actions as $action)
        {
                $admin->row_text($action['name'] . "\n<div class=\"smallfont\">$action[description]</div>", "<a href=\"automation.php?do=edit&amp;actionid=$action[actionid]\">[" . T('Edit') . "]</a> <a href=\"automation.php?do=delete&amp;actionid=$action[actionid]\">[" . T('Delete') . "]</a>");
        }

diff --git a/admin/field.php b/admin/field.php
index c27f40c204339b4503533a85ef70376c1eec5524..2ebb7617b2b290b5410e6b7c7405232bbc881404 100644 (file)
--- a/admin/field.php
+++ b/admin/field.php
@@ -246,14 +246,14 @@ if ($_REQUEST['do'] == 'add' OR $_REQUEST['do'] == 'edit')
                if ($edit)
                {
                        $perms = $db->query("SELECT usergroupid, mask FROM " . TABLE_PREFIX . "bugfieldpermission WHERE fieldid = " . $field->objdata['fieldid']);
-                       while ($perm = $db->fetch_array($perms))
+                       foreach ($perms as $perm)
                        {
                                $permissions["$perm[usergroupid]"] = $perm['mask'];
                        }
                }
                
                $usergroups = $db->query("SELECT * FROM " . TABLE_PREFIX . "usergroup ORDER BY usergroupid");
-               while ($usergroup = $db->fetch_array($usergroups))
+               foreach ($usergroups as $usergroup)
                {
                        unset($listitem);
                        $admin->list_item(T('No Permission'), 0, $permissions["$usergroup[usergroupid]"] == 0);
@@ -288,7 +288,7 @@ if ($_REQUEST['do'] == 'modify')
        $admin->table_column_head(array(T('Display Name/Description'), T('Field ID'), T('Actions')));
        
        $fields = $db->query("SELECT * FROM " . TABLE_PREFIX . "bugfield ORDER BY fieldid ASC");
-       while ($field = $db->fetch_array($fields))
+       foreach ($fields as $field)
        {
                $admin->row_multi_item(
                        array(

diff --git a/admin/language.php b/admin/language.php
index 237a902bcc445ffb08da772fbcc13b03297133bd..9d813d83877e4c6ebfffaf8d028506547586a8d2 100644 (file)
--- a/admin/language.php
+++ b/admin/language.php
@@ -171,7 +171,7 @@ if ($_REQUEST['do'] == 'modify')
        $admin->table_column_head(array(T('Title'), T('Language Code / Charset'), T('Options')));
        
        $languages = $db->query("SELECT * FROM " . TABLE_PREFIX . "language ORDER BY languageid ASC");
-       while ($language = $db->fetch_array($languages))
+       foreach ($languages as $language)
        {
                $admin->row_multi_item(array(
                        "<a href=\"language.php?do=edit&amp;languageid=$language[languageid]\">$language[title]</a>" => 'l',

diff --git a/admin/permission.php b/admin/permission.php
index 43ffea9577c51c026c933dbe7b74f4754a62d5a4..a0d12089946632baaa744e91537507821bddb622 100755 (executable)
--- a/admin/permission.php
+++ b/admin/permission.php
@@ -181,7 +181,7 @@ if ($_REQUEST['do'] == 'modify')
        $admin->table_head(T('Permission Manager'));
        
        $groups = $db->query("SELECT * FROM " . TABLE_PREFIX . "usergroup ORDER BY usergroupid ASC");
-       while ($group = $db->fetch_array($groups))
+       foreach ($groups as $group)
        {
                $usergroups["$group[usergroupid]"] = $group;
        }
@@ -194,13 +194,13 @@ if ($_REQUEST['do'] == 'modify')
                if ($bugsys->in['usergroupid'] == $group['usergroupid'])
                {
                        $permissions_fetch = $db->query("SELECT * FROM " . TABLE_PREFIX . "permission WHERE usergroupid = $group[usergroupid]");
-                       while ($permission = $db->fetch_array($permissions_fetch))
+                       foreach ($permissions_fetch as $permission)
                        {
                                $permissions["$permission[productid]"] = $permission['mask'];
                        }
                        
                        $products_fetch = $db->query("SELECT * FROM " . TABLE_PREFIX . "product WHERE !parentid OR parentid IS NULL ORDER BY displayorder ASC");
-                       while ($product = $db->fetch_array($products_fetch))
+                       foreach ($products_fetch as $product)
                        {
                                $groupid = $group['usergroupid'];
                                $prodid = $product['productid'];

diff --git a/admin/priority.php b/admin/priority.php
index 93bc424246f1c44b098853eb704db96ffcba3680..7da25510b4e8cd929a95ed1f89e692e5b7c8f044 100755 (executable)
--- a/admin/priority.php
+++ b/admin/priority.php
@@ -148,7 +148,7 @@ if ($_REQUEST['do'] == 'modify')
        $admin->table_start();
        $admin->table_head(T('Priority Manager'));
        
-       while ($priority = $db->fetch_array($priorities))
+       foreach ($priorities as $priority)
        {
                $admin->row_text("$priority[displayorder]: <a href=\"priority.php?do=edit&amp;priorityid=$priority[priorityid]\">$priority[priority]</a>", "(priorityid: $priority[priorityid]) <a href=\"priority.php?do=edit&amp;priorityid=$priority[priorityid]\">[" . T('Edit') . "]</a> <a href=\"priority.php?do=delete&amp;priorityid=$priority[priorityid]\">[" . T('Delete') . "]</a>");
        }

diff --git a/admin/product.php b/admin/product.php
index 82705fde99b07c71538ed6a194482443d72cd51f..5f13e3d3bc02a55e594766d0e33668f76c362575 100755 (executable)
--- a/admin/product.php
+++ b/admin/product.php
@@ -187,7 +187,7 @@ if ($_REQUEST['do'] == 'killproduct')
 {
        $bugsys->input_clean('productid', TYPE_UINT);
        $allprods = $db->query("SELECT * FROM " . TABLE_PREFIX . "product WHERE productid = " . $bugsys->in['productid'] . " OR parentid = " . $bugsys->in['productid']);
-       while ($prod = $db->fetch_array($allprods))
+       foreach ($allprods as $prod)
        {
                $list[] = $prod['productid'];
        }
@@ -357,7 +357,7 @@ EOF;
        
        $products_get = $db->query("SELECT * FROM " . TABLE_PREFIX . "product ORDER BY displayorder ASC");
        $products = array();
-       while ($prod = $db->fetch_array($products_get))
+       foreach ($products_get as $prod)
        {
                if (!$prod['parentid'])
                {
@@ -372,7 +372,7 @@ EOF;
        
        $versions_get = $db->query("SELECT * FROM " . TABLE_PREFIX . "version ORDER BY displayorder ASC");
        $versions = array();
-       while ($vers = $db->fetch_array($versions_get))
+       foreach ($versions_get as $vers)
        {
                $versions["$vers[productid]"]["$vers[versionid]"] = $vers;
        }

diff --git a/admin/resolution.php b/admin/resolution.php
index 1f8d3893f5264a2d1113cd687f4635a58fd6d442..514709f74b959ac3bc52462d76ac1af2e8a13829 100755 (executable)
--- a/admin/resolution.php
+++ b/admin/resolution.php
@@ -148,7 +148,7 @@ if ($_REQUEST['do'] == 'modify')
        $admin->table_start();
        $admin->table_head(T('Resolution Manager'));
        
-       while ($resolution = $db->fetch_array($resolutions))
+       foreach ($resolutions as $resolution)
        {
                $admin->row_text("$resolution[displayorder]: <a href=\"resolution.php?do=edit&amp;resolutionid=$resolution[resolutionid]\">$resolution[resolution]</a>", "(resolutionid: $resolution[resolutionid]) <a href=\"resolution.php?do=edit&amp;resolutionid=$resolution[resolutionid]\">[" . T('Edit') . "]</a> <a href=\"resolution.php?do=delete&amp;resolutionid=$resolution[resolutionid]\">[" . T('Delete') . "]</a>");
        }

diff --git a/admin/severity.php b/admin/severity.php
index 6b7aa7e329765345bc0b410d39d205cd3477f662..abdf148c536eb8a3bc516a5837ba998430336b24 100755 (executable)
--- a/admin/severity.php
+++ b/admin/severity.php
@@ -148,7 +148,7 @@ if ($_REQUEST['do'] == 'modify')
        $admin->table_start();
        $admin->table_head(T('Severity Manager'));
        
-       while ($severity = $db->fetch_array($severities))
+       foreach ($severities as $severity)
        {
                $admin->row_text("$severity[displayorder]: <a href=\"severity.php?do=edit&amp;severityid=$severity[severityid]\">$severity[severity]</a>", "(severityid: $severity[severityid]) <a href=\"severity.php?do=edit&amp;severityid=$severity[severityid]\">[" . T('Edit') . "]</a> <a href=\"severity.php?do=delete&amp;severityid=$severity[severityid]\">[" . T('Delete') . "]</a>");
        }

diff --git a/admin/status.php b/admin/status.php
index 88ea3cd3403957d2a67e2df07cd4535305dd8801..3d2a7abc82fdd2e49654e7a7bbd798e3c807bba3 100755 (executable)
--- a/admin/status.php
+++ b/admin/status.php
@@ -151,7 +151,7 @@ if ($_REQUEST['do'] == 'modify')
        $admin->table_start();
        $admin->table_head(T('Status Manager'));
        
-       while ($status = $db->fetch_array($statuses))
+       foreach ($statuses as $status)
        {
                $colorblock = '<span style="float: right"><div style="height: 12px; width: 12px; background-color: ' . $status['color'] . '; border: 1px black solid"></div></span>';
                $admin->row_text("$colorblock$status[displayorder]: <a href=\"status.php?do=edit&amp;statusid=$status[statusid]\">$status[status]</a>", "(statusid: $status[statusid]) <a href=\"status.php?do=edit&amp;statusid=$status[statusid]\">[" . T('Edit') . "]</a> <a href=\"status.php?do=delete&amp;statusid=$status[statusid]\">[" . T('Delete') . "]</a>");

diff --git a/admin/user.php b/admin/user.php
index 1995f96e899c7b2af510aa18bef736b72491f631..13ff1d738310e2d459aac21333b432181010ba7f 100644 (file)
--- a/admin/user.php
+++ b/admin/user.php
@@ -242,7 +242,7 @@ if ($_REQUEST['do'] == 'edit' OR $_REQUEST['do'] == 'add')
        if ($user->objdata['userid'])
        {
                $options = $db->query("SELECT * FROM " . TABLE_PREFIX . "useremail WHERE userid = " . $user->objdata['userid']);
-               while ($opt = $db->fetch_array($options))
+               foreach ($options as $opt)
                {
                        foreach ($bugsys->emailoptions['notifications'] AS $name => $notif)
                        {
@@ -357,7 +357,7 @@ if ($_REQUEST['do'] == 'search')
                        $admin->table_head(T('Search Results'), 4);
                        $admin->table_column_head(array(T('Display Name'), T('Email'), T('User ID'), T('Actions')));
                        
-                       while ($row = $db->fetch_array($results))
+                       foreach ($results as $row)
                        {
                                $admin->row_multi_item(array(
                                        $row['displayname'] => 'l',
@@ -400,7 +400,7 @@ if ($_REQUEST['do'] == 'showall')
        $pagination->splitPages();
        
        $users = $db->query("SELECT * FROM " . TABLE_PREFIX . "user ORDER BY userid ASC LIMIT " . $pagination->fetchLimit($pagination->getPage() - 1) . ", " . $pagination->getPerPage());
-       while ($user = $db->fetch_array($users))
+       foreach ($users as $user)
        {
                $admin->row_multi_item(array(
                        $user['displayname'] => 'l',

diff --git a/admin/usergroup.php b/admin/usergroup.php
index 45dac27d46f9578e9fb7b5282174e9e8d9c3a402..3f0bc58c89524eb74db6a1dbc15ec1abaa3a73e4 100755 (executable)
--- a/admin/usergroup.php
+++ b/admin/usergroup.php
@@ -181,14 +181,14 @@ if ($_REQUEST['do'] == 'add' OR $_REQUEST['do'] == 'edit' OR $_REQUEST['do'] ==
        if ($edit OR $clone)
        {
                $perms = $db->query("SELECT fieldid, mask FROM " . TABLE_PREFIX . "bugfieldpermission WHERE usergroupid = " . $usergroup->objdata['usergroupid']);
-               while ($perm = $db->fetch_array($perms))
+               foreach ($perms as $perm)
                {
                        $permissions["$perm[fieldid]"] = $perm['mask'];
                }
        }
        
        $fields = $db->query("SELECT fieldid, name FROM " . TABLE_PREFIX . "bugfield ORDER BY fieldid");
-       while ($field = $db->fetch_array($fields))
+       foreach ($fields as $field)
        {
                unset($listitem);
                $admin->list_item(T('No Permission'), 0, $permissions["$field[fieldid]"] == 0);
@@ -249,7 +249,7 @@ if ($_POST['do'] == 'insert')
        if ($bugsys->input_clean('cloneid', TYPE_UINT))
        {
                $prodperms = $db->query("SELECT * FROM " . TABLE_PREFIX . "permission WHERE usergroupid = " . $bugsys->in['cloneid']);
-               while ($prod = $db->fetch_array($prodperms))
+               foreach ($prodperms as $prod)
                {
                        $db->query("INSERT INTO " . TABLE_PREFIX . "permission (usergroupid, productid, mask) VALUES (" . $usergroup->insertid . ", $prod[productid], $prod[mask])");
                }
@@ -332,7 +332,7 @@ if ($_POST['do'] == 'doapprove')
        if (sizeof($idlist) > 0)
        {
                $users = $db->query("SELECT * FROM " . TABLE_PREFIX . "user WHERE userid IN (" . implode(',', $idlist) . ")");
-               while ($user = $db->fetch_array($users))
+               foreach ($users as $user)
                {
                        $tpl = $template->fetch(FetchEmailPath('accountapproved.xml', bugdar::$datastore['language'][bugdar::$options['defaultlanguage']]['langcode']));
                        eval('$email = "' . $tpl . '";');
@@ -364,7 +364,7 @@ if ($_REQUEST['do'] == 'approve')
        $admin->table_column_head(array(T('Display Name'), T('Usergroup'), T('Approve')));
        
        $users = $db->query("SELECT * FROM " . TABLE_PREFIX . "user WHERE usergroupid IN (3, 4)");
-       while ($user = $db->fetch_array($users))
+       foreach ($users as $user)
        {
                $admin->row_multi_item(array(
                        '<a href="user.php?do=edit&amp;userid=' . $user['userid'] . '">' . $user['email'] . '</a>' => 'l',
@@ -394,7 +394,7 @@ if ($_REQUEST['do'] == 'modify')
        $admin->table_head(T('Usergroup Manager'), 3, 'usergroups');
        
        $groups = $db->query("SELECT * FROM " . TABLE_PREFIX . "usergroup ORDER BY usergroupid ASC");
-       while ($group = $db->fetch_array($groups))
+       foreach ($groups as $group)
        {
                $usergroups["$group[usergroupid]"] = $group;
        }
@@ -407,7 +407,7 @@ if ($_REQUEST['do'] == 'modify')
                GROUP BY usergroup.usergroupid
                ORDER BY usergroup.usergroupid"
        );
-       while ($group = $db->fetch_array($groups))
+       foreach ($groups as $group)
        {
                $usergroups["$group[usergroupid]"]['total'] = $group['total'];
        }

diff --git a/admin/userhelp.php b/admin/userhelp.php
index 55000555757b9b35a484e84f53e6b11d2cbb94d8..b7c5b81468b8580d1e1cb5fc65d452322b08f337 100755 (executable)
--- a/admin/userhelp.php
+++ b/admin/userhelp.php
@@ -135,7 +135,7 @@ if ($_REQUEST['do'] == 'modify')
        $admin->table_head(T('Edit User Help'));
        
        $topics = $db->query("SELECT * FROM " . TABLE_PREFIX . "fieldhelp ORDER BY keystring ASC");
-       while ($topic = $db->fetch_array($topics))
+       foreach ($topics as $topic)
        {
                $inputfield = '<input type="text" class="input" name="help[' . $topic['keystring'] . '][title]" value="' . $topic['title'] . '" size="35" />';
                $delete = (!in_array($topic['keystring'], UserHelpAPI::not_able_to_delete()) ? '<br /><br /><a href="userhelp.php?do=delete&amp;keystring=' . $topic['keystring'] . '">[' . T('Delete') . ']</a>' : '');

diff --git a/attachment.php b/attachment.php
index 8392b487993bdd519def7b0545e73c6f6f2cffdd..b51ce83c0e68a2c5a82a6d9779b49244b5b18fd3 100755 (executable)
--- a/attachment.php
+++ b/attachment.php
@@ -179,7 +179,7 @@ if ($_REQUEST['do'] == 'add')
        
        $obsoletes_fetch = $db->query("SELECT * FROM " . TABLE_PREFIX . "attachment WHERE bugid = $bug[bugid] AND !obsolete");
        $obsoletes = '';
-       while ($obsolete = $db->fetch_array($obsoletes_fetch))
+       foreach ($obsoletes_fetch as $obsolete)
        {
                $show['obsoletes'] = true;
                $obsoletes .= "<div><input name=\"obsoletes[]\" type=\"checkbox\" value=\"$obsolete[attachmentid]\"" . (is_array($bugsys->in['obsoletes']) AND in_array($obsolete['attachmentid'], $bugsys->in['obsoletes']) ? ' checked="checked"' : '') . " /> $obsolete[filename]" . ($obsolete['description'] ? " [$obsolete[description]]" : '') . "</div>\n";

diff --git a/docs/datatools.php b/docs/datatools.php
index ab3be6e1a411ee1fd8a1ea6c195c369cfddd2e18..e025d7a08719c2596046f6f2b59153a15e0ca19b 100644 (file)
--- a/docs/datatools.php
+++ b/docs/datatools.php
@@ -63,7 +63,7 @@ if ($_REQUEST['do'] == 'export')
        foreach ($THELIST AS $display => $data)
        {
                $fetch = $db->query("SELECT * FROM " . TABLE_PREFIX . "$data[table]" . (!$data['orderfree'] ? " ORDER BY {$data[table]}id ASC" : ""));
-               while ($fitem = $db->fetch_array($fetch))
+               foreach ($fetch as $fitem)
                {
                        $exportlist["$display"][] = $fitem;
                }
@@ -198,7 +198,7 @@ if ($_REQUEST['do'] == 'settings')
 FILE;
        
        $settings = $db->query("SELECT * FROM " . TABLE_PREFIX . "setting");
-       while ($setting = $db->fetch_array($settings))
+       foreach ($settings as $setting)
        {
                $fout .= "\n\t'$setting[varname]' => '" . str_replace("'", "\'", $setting['value']) . "',";
        }

diff --git a/docs/migrate_custom_fields.php b/docs/migrate_custom_fields.php
index 338544121d60770fe19362488471c95030b937a7..9738c10cb74ed0f91ca5aee6b3c92969a5942f6d 100644 (file)
--- a/docs/migrate_custom_fields.php
+++ b/docs/migrate_custom_fields.php
@@ -8,14 +8,14 @@ require_once('global.php');
 
 // gets all the fields
 $fields = $db->query("SELECT * FROM " . TABLE_PREFIX . "bugfield");
-while ($field = $db->fetch_array($fields))
+foreach ($fields as $field)
 {
        // create the database field
        $db->query("ALTER TABLE " . TABLE_PREFIX . "bug ADD custom$field[fieldid] MEDIUMTEXT NULL");
        
        // update all the data
        $data = $db->query("SELECT * FROM " . TABLE_PREFIX . "bugvaluefill");
-       while ($custom = $db->fetch_array($data))
+       foreach ($data as $custom)
        {
                $db->query("UPDATE " . TABLE_PREFIX . "bug SET custom$field[fieldid] = '" . $db->escape_string($custom["field$field[fieldid]"]) . "' WHERE bugid = $custom[bugid]");
        }

diff --git a/docs/update_bug_names.php b/docs/update_bug_names.php
index 9e1a3a7308a3b87400f4e428ca0830498727673f..d33dc817da5691c07c2ea663dfe23d93958b2e09 100644 (file)
--- a/docs/update_bug_names.php
+++ b/docs/update_bug_names.php
@@ -7,13 +7,13 @@ require_once('./global.php');
 
 $userlist = array();
 $users = $db->query("SELECT userid, displayname FROM " . TABLE_PREFIX . "user");
-while ($user = $db->fetch_array($users))
+foreach ($users as $user)
 {
        $userlist["$user[userid]"] = $user['displayname'];
 }
 
 $bugs = $db->query("SELECT * FROM " . TABLE_PREFIX . "bug");
-while ($bug = $db->fetch_array($bugs))
+foreach ($bugs as $bug)
 {
        $db->query("
                UPDATE " . TABLE_PREFIX . "bug

diff --git a/docs/update_bug_table_cache.php b/docs/update_bug_table_cache.php
index 87a59562b29c073b4134357fcdda1ea8da40df16..189feea5bc6ae4b9ee61ec6c4189de51be1adad1 100644 (file)
--- a/docs/update_bug_table_cache.php
+++ b/docs/update_bug_table_cache.php
@@ -5,7 +5,7 @@ require_once('./global.php');
 
 $comments = $db->query("SELECT * FROM " . TABLE_PREFIX . "comment ORDER BY bugid, dateline ASC");
 
-while ($comment = $db->fetch_array($comments))
+foreach ($comments as $comment)
 {
        if (!isset($replace["$comment[bugid]"]))
        {

diff --git a/docs/update_field_order_in_bugs.php b/docs/update_field_order_in_bugs.php
index 2f96280aa4755e1fb00aac36ea4964e154b37f2a..0c47bb476b67318d53de635807e7c17ae7b17ab6 100644 (file)
--- a/docs/update_field_order_in_bugs.php
+++ b/docs/update_field_order_in_bugs.php
@@ -25,19 +25,19 @@ $fields = array(
 );
 
 $bugs = $db->query("SELECT * FROM " . TABLE_PREFIX . "bug");
-while ($bug = $db->fetch_array($bugs))
+foreach ($bugs as $bug)
 {
        $db->query("UPDATE " . TABLE_PREFIX . "bug SET priority = " . $fields['priority']["$bug[priority]"] . ", severity = " . $fields['severity']["$bug[severity]"] . " WHERE bugid = " . $bug['bugid']);
 }
 
 $severity = $db->query("SELECT * FROM " . TABLE_PREFIX . "severity");
-while ($thing = $db->fetch_array($severity))
+foreach ($severity as $thing)
 {
        $db->query("UPDATE " . TABLE_PREFIX . "severity SET severityid = " . rand(10, 100000) . " WHERE severityid = $thing[severityid]");
 }
 
 $priority = $db->query("SELECT * FROM " . TABLE_PREFIX . "priority");
-while ($thing = $db->fetch_array($priority))
+foreach ($priority as $thing)
 {
        $db->query("UPDATE " . TABLE_PREFIX . "priority SET priorityid = " . rand(10, 100000) . " WHERE priorityid = $thing[priorityid]");
 }

diff --git a/docs/update_history.php b/docs/update_history.php
index f430944cd869e2d9877a48b6052565768404131a..13b53ef4831e54ec973ac6144bf9bcb94436a61a 100644 (file)
--- a/docs/update_history.php
+++ b/docs/update_history.php
@@ -10,7 +10,7 @@ require_once('./global.php');
 $total = $nodo = 0;
 
 $history = $db->query("SELECT * FROM " . TABLE_PREFIX . "history");
-while ($log = $db->fetch_array($history))
+foreach ($history as $log)
 {
        $matches = array();
        if (preg_match('#custom_field([0-9]+?)#i', $log['field'], $matches))

diff --git a/explain.php b/explain.php
index 5c53d9677abf9dcb21d8872f5129c16a8048785b..ebe272cc00e4d6007783790e622afba091df5c15 100644 (file)
--- a/explain.php
+++ b/explain.php
@@ -110,7 +110,7 @@ if ($_REQUEST['do'] == 'automations')
                AND permission.usergroupid IN ({bugdar::$userinfo['usergroupid']}" . (sizeof(bugdar::$userinfo['groupids']) != 0 ? ',' . implode(',', bugdar::$userinfo['groupids']) : '') . ")
                GROUP BY (bugfield.fieldid)
        ");
-       while ($field = $bugsys->db->fetch_array($fields_fetch))
+       foreach ($fields_fetch as $field)
        {
                $fields["$field[fieldid]"] = $field;
        }

diff --git a/favorite.php b/favorite.php
index c10f6e76bbe8d3639bd3487f8ebb3fb9727b7c72..c3fcf62afdf0013f05e2683ef8768b3236539f24 100644 (file)
--- a/favorite.php
+++ b/favorite.php
@@ -91,7 +91,7 @@ if ($_REQUEST['do'] == 'manage')
        
        $headers = $sort->constructColumnHeaders(false);
        
-       while ($bug = $db->fetch_array($favorites))
+       foreach ($favorites as $bug)
        {
                $funct->exec_swap_bg('altcolor', '');
                $bug = ProcessBugDataForDisplay($bug, $funct->bgcolour);

diff --git a/includes/class_notification.php b/includes/class_notification.php
index 2831a3c931476c70872c4328df06f0b3c70357c0..803580358b05d03eb7385aa61f253366553559d4 100644 (file)
--- a/includes/class_notification.php
+++ b/includes/class_notification.php
@@ -154,13 +154,13 @@ class NotificationCenter
        function fetch_user_cache()
        {
                $newbuggers = $this->registry->db->query("SELECT userid FROM " . TABLE_PREFIX . "useremail WHERE relation = " . $this->registry->emailoptions['relations']['-notapplicable-'] . " AND mask & " . $this->registry->emailoptions['notifications']['newbug']);
-               while ($newbug = $this->registry->db->fetch_array($newbuggers))
+               foreach ($newbuggers as $newbug)
                {
                        $this->roles['-notapplicable-']["$newbug[userid]"] = $newbug['userid'];
                }
                
                $favorites = $this->registry->db->query("SELECT userid FROM " . TABLE_PREFIX . "favorite WHERE bugid = " . $this->registry->clean($this->bug['bugid'], TYPE_UINT));
-               while ($fav = $this->registry->db->fetch_array($favorites))
+               foreach ($favorites as $fav)
                {
                        $this->roles['favorite']["$fav[userid]"] = $fav['userid'];
                }
@@ -169,7 +169,7 @@ class NotificationCenter
                $this->roles['voter'] = preg_split('#,#', $voters['userids'], 0, PREG_SPLIT_NO_EMPTY);
                
                $commenters = $this->registry->db->query("SELECT userid FROM " . TABLE_PREFIX . "comment WHERE bugid = " . $this->registry->clean($this->bug['bugid'], TYPE_UINT));
-               while ($comment = $this->registry->db->fetch_array($commenters))
+               foreach ($commenters as $comment)
                {
                        $this->roles['commenter']["$comment[userid]"] = $comment['userid'];
                }
@@ -186,7 +186,7 @@ class NotificationCenter
                                        ON (user.userid = useremail.userid)
                                WHERE useremail.userid IN (" . implode(',', $masterids) . ")
                        ");
-                       while ($user = $this->registry->db->fetch_array($userinfo))
+                       foreach ($userinfo as $user)
                        {
                                if (!is_array($this->users["$user[userid]"]))
                                {
@@ -511,7 +511,7 @@ class NotificationCenter
                        WHERE useremail.relation = 0
                        AND useremail.mask & " . $this->registry->emailoptions['notifications']['newbug'] . "
                ");
-               while ($userInfo = $this->registry->db->fetch_array($userinfo))
+               foreach ($userinfo as $userInfo)
                {
                        if (!is_array($this->users["$userInfo[userid]"]))
                        {

diff --git a/includes/functions.php b/includes/functions.php
index 5bd5a4340613d4af825168577f60ff4065102a79..79b8c4b29459569c21b0c8a748ab461cf696c860 100755 (executable)
--- a/includes/functions.php
+++ b/includes/functions.php
@@ -228,7 +228,7 @@ function construct_custom_fields($bug = array(), $ignore21mask = false, $nodefau
                        AND permission.usergroupid IN (" . bugdar::$userinfo['usergroupid'] . (sizeof(bugdar::$userinfo['groupids']) != 0 ? ',' . implode(',', bugdar::$userinfo['groupids']) : '') . ")
                        GROUP BY (bugfield.fieldid)
                ");
-               while ($field = $bugsys->db->fetch_array($fields_fetch))
+               foreach ($fields_fetch as $field)
                {
                        $fields["$field[fieldid]"] = $field;
                }
@@ -379,7 +379,7 @@ function process_custom_fields(&$bugapi, &$msg, $errorbox = false, $searchMode =
                AND permission.usergroupid IN (" . bugdar::$userinfo['usergroupid'] . (sizeof(bugdar::$userinfo['groupids']) != 0 ? ',' . implode(',', bugdar::$userinfo['groupids']) : '') . ")
                GROUP BY (bugfield.fieldid)
        ");
-       while ($field = $bugsys->db->fetch_array($fields))
+       foreach ($fields as $field)
        {
                $fieldname = "custom$field[fieldid]";
                

diff --git a/includes/functions_datastore.php b/includes/functions_datastore.php
index 13ba2ca95eeb8675b4a69bd2597eb002c9fb23d1..ca9f379a137486b7a26735e8f765b60690bfcc1c 100755 (executable)
--- a/includes/functions_datastore.php
+++ b/includes/functions_datastore.php
@@ -25,7 +25,7 @@ function build_languages()
        global $bugsys;
        
        $languages = $bugsys->db->query("SELECT * FROM " . TABLE_PREFIX . "language");
-       while ($language = $bugsys->db->fetch_array($languages))
+       foreach ($languages as $language)
        {
                $tempstore["$language[languageid]"] = $language;
        }
@@ -45,7 +45,7 @@ function build_settings()
        global $bugsys;
        
        $settings = $bugsys->db->query("SELECT * FROM " . TABLE_PREFIX . "setting");
-       while ($setting = $bugsys->db->fetch_array($settings))
+       foreach ($settings as $setting)
        {
                $options["$setting[varname]"] = $setting['value'];
        }
@@ -65,7 +65,7 @@ function build_usergroups()
        global $bugsys;
        
        $usergroups = $bugsys->db->query("SELECT * FROM " . TABLE_PREFIX . "usergroup");
-       while ($usergroup = $bugsys->db->fetch_array($usergroups))
+       foreach ($usergroups as $usergroup)
        {
                $groups["$usergroup[usergroupid]"] = $usergroup;
        }
@@ -85,7 +85,7 @@ function build_statuses()
        global $bugsys;
        
        $statuses = $bugsys->db->query("SELECT * FROM " . TABLE_PREFIX . "status ORDER BY displayorder ASC");
-       while ($status = $bugsys->db->fetch_array($statuses))
+       foreach ($statuses as $status)
        {
                $tempstore["$status[statusid]"] = $status;
        }
@@ -105,7 +105,7 @@ function build_severities()
        global $bugsys;
        
        $severities = $bugsys->db->query("SELECT * FROM " . TABLE_PREFIX . "severity ORDER BY displayorder ASC");
-       while ($severity = $bugsys->db->fetch_array($severities))
+       foreach ($severities as $severity)
        {
                $tempstore["$severity[severityid]"] = $severity;
        }
@@ -125,7 +125,7 @@ function build_priorities()
        global $bugsys;
        
        $priorities = $bugsys->db->query("SELECT * FROM " . TABLE_PREFIX . "priority ORDER BY displayorder ASC");
-       while ($priority = $bugsys->db->fetch_array($priorities))
+       foreach ($priorities as $priority)
        {
                $tempstore["$priority[priorityid]"] = $priority;
        }
@@ -162,7 +162,7 @@ function build_assignedto()
                FROM " . TABLE_PREFIX . "user AS user
                WHERE usergroupid IN ($ids) OR $exprs"
        );
-       while ($user = $bugsys->db->fetch_array($users))
+       foreach ($users as $user)
        {
                $devs["$user[userid]"] = $user;
        }
@@ -182,7 +182,7 @@ function build_resolutions()
        global $bugsys;
        
        $resolutions = $bugsys->db->query("SELECT * FROM " . TABLE_PREFIX . "resolution ORDER BY displayorder ASC");
-       while ($resolution = $bugsys->db->fetch_array($resolutions))
+       foreach ($resolutions as $resolution)
        {
                $tempstore["$resolution[resolutionid]"] = $resolution;
        }
@@ -202,7 +202,7 @@ function build_versions()
        global $bugsys;
        
        $versions = $bugsys->db->query("SELECT * FROM " . TABLE_PREFIX . "version ORDER BY displayorder ASC");
-       while ($version = $bugsys->db->fetch_array($versions))
+       foreach ($versions as $version)
        {
                $tempstore["$version[versionid]"] = $version;
        }
@@ -222,7 +222,7 @@ function build_products()
        global $bugsys;
        
        $products = $bugsys->db->query("SELECT * FROM " . TABLE_PREFIX . "product ORDER BY displayorder ASC");
-       while ($product = $bugsys->db->fetch_array($products))
+       foreach ($products as $product)
        {
                if ($product['parentid'])
                {
@@ -252,7 +252,7 @@ function build_permissions()
        global $bugsys;
        
        $permissions = $bugsys->db->query("SELECT * FROM " . TABLE_PREFIX . "permission ORDER BY usergroupid, productid");
-       while ($permission = $bugsys->db->fetch_array($permissions))
+       foreach ($permissions as $permission)
        {
                $tempstore["$permission[usergroupid]"]["$permission[productid]"] = $permission['mask'];
        }
@@ -272,7 +272,7 @@ function build_automations()
        global $bugsys;
        
        $automations = $bugsys->db->query("SELECT * FROM " . TABLE_PREFIX . "automation ORDER BY name ASC");
-       while ($automation = $bugsys->db->fetch_array($automations))
+       foreach ($automations as $automation)
        {
                $actions["$automation[actionid]"] = $automation;
        }
@@ -293,14 +293,14 @@ function build_user_help()
        
        // custom field descriptions
        $descriptions = $bugsys->db->query("SELECT fieldid, name, description FROM " . TABLE_PREFIX . "bugfield");
-       while ($field = $bugsys->db->fetch_array($descriptions))
+       foreach ($descriptions as $field)
        {
                $help["field$field[fieldid]"] = array('title' => $field['name'], 'body' => $field['description']);
        }
        
        // standard help texts
        $texts = $bugsys->db->query("SELECT * FROM " . TABLE_PREFIX . "fieldhelp");
-       while ($field = $bugsys->db->fetch_array($texts))
+       foreach ($texts as $field)
        {
                $help["$field[keystring]"] = $field;
        }

diff --git a/install/convert_database_charset.php b/install/convert_database_charset.php
index def3532da674c9ac8b6b11aff5fc2d3d8bfa021c..190c730a27d4f230180e971614410817b3d2bc47 100644 (file)
--- a/install/convert_database_charset.php
+++ b/install/convert_database_charset.php
@@ -91,7 +91,7 @@ else if ($bugsys->in['step'] == 1)
        while ($table = $db->fetch_array($tables, false))
        {
                $columns = $db->query("SHOW FULL COLUMNS FROM $table[0]");
-               while ($col = $db->fetch_array($columns))
+               foreach ($columns as $col)
                {
                        if (!is_null($col['Collation']) AND (strpos($col['Type'], 'char') !== false OR strpos($col['Type'], 'text') !== false))
                        {

diff --git a/install/upgrade11.php b/install/upgrade11.php
index a8575f5cb85da339da0f01ec9e84ab8ecf32b064..167eeb2afd84c7e2355446eb8f1c95e319f9badb 100644 (file)
--- a/install/upgrade11.php
+++ b/install/upgrade11.php
@@ -104,7 +104,7 @@ if ($bugsys->in['mark'] == 3)
 <?php
        // gets all the fields
        $fields = $db->query("SELECT * FROM " . TABLE_PREFIX . "bugfield");
-       while ($field = $db->fetch_array($fields))
+       foreach ($fields as $field)
        {
                // create the database field
                $db->query("ALTER TABLE " . TABLE_PREFIX . "bug ADD custom$field[fieldid] MEDIUMTEXT NULL");
@@ -113,7 +113,7 @@ if ($bugsys->in['mark'] == 3)
 
                // update all the data
                $data = $db->query("SELECT * FROM " . TABLE_PREFIX . "bugvaluefill");
-               while ($custom = $db->fetch_array($data))
+               foreach ($data as $custom)
                {
                        echo ".";
                        $db->query("UPDATE " . TABLE_PREFIX . "bug SET custom$field[fieldid] = '" . $db->escape_string($custom["field$field[fieldid]"]) . "' WHERE bugid = $custom[bugid]");

diff --git a/install/upgrade2.php b/install/upgrade2.php
index 9b04826cb23a2900e9114ead9182dea558e04528..e7542a5dc4bafa8f43d195e3095b48e001902ac8 100644 (file)
--- a/install/upgrade2.php
+++ b/install/upgrade2.php
@@ -142,13 +142,13 @@ if ($bugsys->in['mark'] == 4)
        
        $userlist = array();
        $users = $db->query("SELECT userid, displayname FROM " . TABLE_PREFIX . "user");
-       while ($user = $db->fetch_array($users))
+       foreach ($users as $user)
        {
                $userlist["$user[userid]"] = $user['displayname'];
        }
        
        $bugs = $db->query("SELECT * FROM " . TABLE_PREFIX . "bug");
-       while ($bug = $db->fetch_array($bugs))
+       foreach ($bugs as $bug)
        {
                $db->query("
                        UPDATE " . TABLE_PREFIX . "bug
@@ -176,7 +176,7 @@ if ($bugsys->in['mark'] == 5)
        echo "Updating historical records";
        
        $history = $db->query("SELECT * FROM " . TABLE_PREFIX . "history");
-       while ($log = $db->fetch_array($history))
+       foreach ($history as $log)
        {
                $matches = array();
                if (preg_match('#custom_field([0-9]+?)#i', $log['field'], $matches))
@@ -225,7 +225,7 @@ if ($bugsys->in['mark'] == 6)
        echo "Setting email options";
        
        $users = $db->query("SELECT userid FROM " . TABLE_PREFIX . "user");
-       while ($user = $db->fetch_array($users))
+       foreach ($users as $user)
        {
                $db->query("
                        INSERT INTO " . TABLE_PREFIX . "useremail

diff --git a/search.php b/search.php
index a56c28a09115e939bb1856b717550103e0a68317..2cd5865d65ad50259746ee5bff9698d8690201f6 100644 (file)
--- a/search.php
+++ b/search.php
@@ -149,7 +149,7 @@ if ($_REQUEST['do'] == 'search')
                if (bugdar::$userinfo['userid'])
                {
                        $searchesFetch = $db->query("SELECT * FROM " . TABLE_PREFIX . "search WHERE name IS NOT NULL AND userid = " . bugdar::$userinfo['userid']);
-                       while ($search = $db->fetch_array($searchesFetch))
+                       foreach ($searchesFetch as $search)
                        {
                                $value = $search['searchid'];
                                $label = $search['name'];
@@ -298,7 +298,7 @@ if ($_REQUEST['do'] == 'process')
        if ($bugsys->in['favorite'] != 0 AND bugdar::$userinfo['userid'])
        {
                $favorites = $db->query("SELECT * FROM " . TABLE_PREFIX . "favorite WHERE userid = " . bugdar::$userinfo['userid']);
-               while ($favorite = $db->fetch_array($favorites))
+               foreach ($favorites as $favorite)
                {
                        $ids[] = $favorite['bugid'];
                }
@@ -335,7 +335,7 @@ if ($_REQUEST['do'] == 'process')
                AND bugfield.cansearch = 1
                GROUP BY (bugfield.fieldid)"
        );
-       while ($field = $bugsys->db->fetch_array($fields_fetch))
+       foreach ($fields_fetch as $field)
        {
                if (!empty($bugsys->in["custom$field[fieldid]"]) OR ($field['type'] == 'select_single' AND isset($bugsys->in["custom$field[fieldid]"])))
                {
@@ -392,7 +392,7 @@ if ($_REQUEST['do'] == 'process')
                $message->error(T('No search results were returned that matched your criteria. Please <a href="search.php?new=1">try again</a> with different search requirements.'));
        }
        
-       while ($result = $db->fetch_array($search))
+       foreach ($search as $result)
        {
                $ids[] = $result['bugid'];
                $results[] = $result;
@@ -512,7 +512,7 @@ if ($_POST['do'] == 'doupdate')
                                (userid = " . bugdar::$userinfo['userid'] . " AND product IN (" . fetch_on_bits('caneditown') . "))
                        )
        ");
-       while ($bug = $db->fetch_array($bugs))
+       foreach ($bugs as $bug)
        {
                if (!((can_perform('caneditown', $bug['product']) AND bugdar::$userinfo['userid'] == $bug['userid']) OR (can_perform('caneditother', $bug['product']) AND bugdar::$userinfo['userid'] != $bug['userid'])) AND !can_perform('canpostcomments', $bug['product']))
                {
@@ -595,7 +595,7 @@ if ($_REQUEST['do'] == 'export')
 
 <bugdarExport user="' . $bugsys->unsanitize(construct_user_display(bugdar::$userinfo, false)) . '" date="' . $datef->format('r', TIMENOW) . '" searchid="' . $search['searchid'] . '">';
 
-       while ($bug = $db->fetch_array($bugs))
+       foreach ($bugs as $bug)
        {
                $xml .= "\n\t<bug>";
                
@@ -696,7 +696,7 @@ if ($_POST['do'] == 'results')
        
        $bugs = '';
        $search = $db->query("SELECT * FROM " . TABLE_PREFIX . "bug WHERE bugid IN ($search[ids]) $search[orderby] LIMIT " . $pagination->fetchLimit($pagination->getPage() - 1) . ", " . $pagination->getPerPage());
-       while ($bug = $db->fetch_array($search))
+       foreach ($search as $bug)
        {
                $funct->exec_swap_bg('altcolor', '');
                $bug = ProcessBugDataForDisplay($bug, $funct->bgcolour);

diff --git a/showhistory.php b/showhistory.php
index de31c515a4475083cd8885af244c1a86b24b5fb1..f1802a7e62f9a18c2f996b6f031e9b268b407bac 100644 (file)
--- a/showhistory.php
+++ b/showhistory.php
@@ -64,7 +64,7 @@ $customfields = $db->query("
        GROUP BY (bugfield.fieldid)"
 );
 
-while ($field = $db->fetch_array($customfields))
+foreach ($customfields as $field)
 {
        $fieldlist["$field[fieldid]"] = sprintf(T('Custom Field %1$s (%2$s)'), $field['fieldid'], $field['name']);
 }
@@ -79,7 +79,7 @@ $logs_fetch = $db->query("
                ON (user.userid = history.userid)
        WHERE bugid = $bug[bugid]"
 );
-while ($log = $db->fetch_array($logs_fetch))
+foreach ($logs_fetch as $log)
 {
        $log['date'] = $datef->format(bugdar::$options['dateformat'], $log['dateline']);
        $log['user'] = construct_user_display($log);

diff --git a/showreport.php b/showreport.php
index befc103fe7fd739f1643e225efa7e71fbdb6926d..c46bd476048be979eb0ecdaed257da84788573a3 100644 (file)
--- a/showreport.php
+++ b/showreport.php
@@ -126,7 +126,7 @@ if ($show['edit'])
        {
                $depends = array();
                $dependencies = $db->query("SELECT * FROM " . TABLE_PREFIX . "bug WHERE bugid IN ($bug[dependency])");
-               while ($dependency = $db->fetch_array($dependencies))
+               foreach ($dependencies as $dependency)
                {
                        $depends[] = "<a href=\"showreport.php?bugid=$dependency[bugid]\" title=\"$dependency[summary]\">$dependency[bugid]</a>";
                }
@@ -173,7 +173,7 @@ else
        
        $dupelist = array();
        $duplicates = $db->query("SELECT bugid, summary FROM " . TABLE_PREFIX . "bug WHERE duplicateof = $bug[bugid]");
-       while ($duplicate = $db->fetch_array($duplicates))
+       foreach ($duplicates as $duplicate)
        {
                $dupelist[] = "<a href=\"showreport.php?bugid=$duplicate[bugid]\" target=\"_blank\">$duplicate[summary]</a>";
        }
@@ -183,7 +183,7 @@ else
        {
                $depends = array();
                $dependencies = $db->query("SELECT bugid, summary FROM " . TABLE_PREFIX . "bug WHERE bugid IN ($bug[dependency])");
-               while ($dependency = $db->fetch_array($dependencies))
+               foreach ($dependencies as $dependency)
                {
                        $depends[] = "<a href=\"showreport.php?bugid=$dependency[bugid]\" title=\"$dependency[summary]\" target=\"_blank\">$dependency[bugid]</a>";
                }
@@ -262,7 +262,7 @@ if ($show['getattachments'] OR $show['putattachments'])
        );
        
        $attaches = false;
-       while ($attachment = $db->fetch_array($attachments_fetch))
+       foreach ($attachments_fetch as $attachment)
        {
                $attaches = true;
                $show['editattach'] = ((can_perform('caneditattach', $bug['productid']) OR ($attachment['userid'] == bugdar::$userinfo['userid'] AND can_perform('canputattach', $bug['productid']))) ? true : false);
@@ -304,7 +304,7 @@ $comments_fetch = $db->query("
                AND !hidden" : '') . "
        ORDER BY comment.dateline ASC"
 );
-while ($comment = $db->fetch_array($comments_fetch))
+foreach ($comments_fetch as $comment)
 {
        $comment['posttime'] = $datef->format(bugdar::$options['dateformat'], $comment['dateline']);
        $comment['postby'] = construct_user_display($comment);

diff --git a/syndicate.php b/syndicate.php
index a9febca7b446b03c631aab5ce09ec7f4d251f692..9d45d0b3132d6ac40a85014f15de98884451c08e 100644 (file)
--- a/syndicate.php
+++ b/syndicate.php
@@ -46,7 +46,7 @@ $bugs_fetch = $db->query("
        ORDER BY " . (can_perform('canviewhidden', 0, fetch_guest_user()) ? "bug.lastposttime" : "bug.hiddenlastposttime") . " DESC
        LIMIT " . bugdar::$options['syndicateditems']
 );
-while ($bug = $db->fetch_array($bugs_fetch))
+foreach ($bugs_fetch as $bug)
 {
        $syndicate .= '
        <entry>

diff --git a/userctrl.php b/userctrl.php
index 878b5fc39358fdc4d51271f084d8975e13d9297c..2cc6cc77a2fa3b412d00e35cc4bfe5ac5971a7ec 100644 (file)
--- a/userctrl.php
+++ b/userctrl.php
@@ -220,7 +220,7 @@ if ($_REQUEST['do'] == 'modify')
        if (!is_array($bugsys->in['emailopts']))
        {
                $options = $db->query("SELECT * FROM " . TABLE_PREFIX . "useremail WHERE userid = " . bugdar::$userinfo['userid']);
-               while ($opt = $db->fetch_array($options))
+               foreach ($options as $opt)
                {
                        foreach ($bugsys->emailoptions['notifications'] AS $name => $notif)
                        {
@@ -279,7 +279,7 @@ if ($_REQUEST['do'] == 'modify')
        // searches
        $searches = '';
        $searchesFetch = $db->query("SELECT * FROM " . TABLE_PREFIX . "search WHERE name IS NOT NULL AND userid = " . bugdar::$userinfo['userid']);
-       while ($search = $db->fetch_array($searchesFetch))
+       foreach ($searchesFetch as $search)
        {
                eval('$searches .= "' . $template->fetch('userctrl_search') . '";');
        }