Robert Sesek [Mon, 19 Mar 2007 17:39:47 +0000 (17:39 +0000)]
r1512: In the approve users section of admin/usergroup.php, we were still using the mailing system from ISSO 2.0. Switched to using template-based emailing (which requires us to load the template system in that one file). Added templates/email/accountapproved.xml.tpl
Robert Sesek [Mon, 19 Mar 2007 05:50:24 +0000 (05:50 +0000)]
r1511: Don't use PHP short tags because not everybody has them enabled.
Robert Sesek [Mon, 19 Mar 2007 00:04:28 +0000 (00:04 +0000)]
r1510: In draw_cancel() [templates/global.js] we can't use double quotes for window.location because that wouldn't mesh well with being placed inside an onclick attribute... in fact I dare say it would down right break it.
Robert Sesek [Sun, 18 Mar 2007 22:48:24 +0000 (22:48 +0000)]
r1509: Removing whitespace at the end of admin/usergroup.php
Robert Sesek [Sun, 18 Mar 2007 22:47:35 +0000 (22:47 +0000)]
r1508: Fixing UserAPI::post_delete() to clean up bugfieldpermission and permission so that usergroups are fully deleted
Robert Sesek [Sun, 18 Mar 2007 22:45:31 +0000 (22:45 +0000)]
r1507: Adding the ability to clone usergroups
Robert Sesek [Sun, 18 Mar 2007 19:36:00 +0000 (19:36 +0000)]
r1506: changes++
Robert Sesek [Sun, 18 Mar 2007 19:32:47 +0000 (19:32 +0000)]
r1505: Implement multi group system for custom fields in explain.php and search.php
Robert Sesek [Sun, 18 Mar 2007 19:25:34 +0000 (19:25 +0000)]
r1504: Why on earth were we permission checking custom fields in the automation system?
Robert Sesek [Sun, 18 Mar 2007 19:18:32 +0000 (19:18 +0000)]
r1503: Update build_assignedto() so people in secondary groups that have assignee powers are added to the cache
Robert Sesek [Sun, 18 Mar 2007 18:35:18 +0000 (18:35 +0000)]
r1502: Making fetch_on_bits() work with multiple user groups
Robert Sesek [Sun, 18 Mar 2007 18:01:33 +0000 (18:01 +0000)]
r1501: We can actually simplify Logging::compare_arrays() by removing the array_diff() business because it really isn't necessary it turns out and was actually responsible for adding a whole bunch of useless logs to the system
Robert Sesek [Sun, 18 Mar 2007 17:47:05 +0000 (17:47 +0000)]
r1500: In showhistory.php:
- Enable multi-group support for custom fields
- Do not show custom fields in the history if users don't have permission to see them
- When we have a useless log (the very first empty checks at the top of the loop), kill them with a database query
Robert Sesek [Sun, 18 Mar 2007 17:35:45 +0000 (17:35 +0000)]
r1499: In editreport.php:
- Only set the standard bug fields if we have permission to change them (thus data isn't cleared when we don't have permission to)
- When setting the bug data for the NotificationCenter, use array_merge() to combine objdata[] and values[] so it doesn't look like we cleared all the fields if we didn't set them
Robert Sesek [Sun, 18 Mar 2007 17:10:21 +0000 (17:10 +0000)]
r1498: In construct_custom_fields() and process_custom_fields(), change the query so we support multiple user group permissions
Robert Sesek [Sun, 18 Mar 2007 05:21:24 +0000 (05:21 +0000)]
r1497: In editreport.php, there's really no point in error checking and validation if we don't ever do it...
Robert Sesek [Sun, 18 Mar 2007 05:15:16 +0000 (05:15 +0000)]
r1496: There's a string here in the parsed comments that we didn't mark
Robert Sesek [Sun, 18 Mar 2007 05:10:09 +0000 (05:10 +0000)]
r1495: It helps if we get the name of the right datastore in can_perform()
Robert Sesek [Sun, 18 Mar 2007 05:01:36 +0000 (05:01 +0000)]
r1494: We actually need to run array_strip_empty() on FetchUserPermissions() so I guess we'll just do that
Robert Sesek [Sun, 18 Mar 2007 04:50:06 +0000 (04:50 +0000)]
r1493: In admin/product.php, move the page_start() call in the addversion branch to be after the check for invalid products so we don't end up with a small display bug if the error is thrown
Robert Sesek [Sun, 18 Mar 2007 04:45:39 +0000 (04:45 +0000)]
r1492: Apparently MySQL doesn't think that NULL values should be included in !parentid which causes not all the products to be displayed in the product-level permissions
Robert Sesek [Sun, 18 Mar 2007 04:38:13 +0000 (04:38 +0000)]
r1491: changes++
Robert Sesek [Sun, 18 Mar 2007 04:37:55 +0000 (04:37 +0000)]
r1490: Fixing a SQL error in admin/usergroup.php that would occur when inserting a new usergroup and trying to INSERT INTO the permissions table for custom fields
Robert Sesek [Sun, 18 Mar 2007 01:49:03 +0000 (01:49 +0000)]
r1489: We really should heed warnings on PHP.net that tell us that there's problems with bitwise ops if we don't explicitly cast to ints...
Robert Sesek [Sun, 18 Mar 2007 01:45:39 +0000 (01:45 +0000)]
r1488: Adding secondary usergroup support to the admin CP
Robert Sesek [Sun, 18 Mar 2007 01:45:23 +0000 (01:45 +0000)]
r1487: Forgot to remove the "value" in the forach() loop in api_user.php in verify_groupids()
Robert Sesek [Sun, 18 Mar 2007 01:26:46 +0000 (01:26 +0000)]
r1486: Adding API support for multiple usergroups in UserAPI. Because we verify in the API, we no longer need to call array_strip_empty() in FetchUserPermissions()
Robert Sesek [Sun, 18 Mar 2007 01:22:03 +0000 (01:22 +0000)]
r1485: - Adding base support for multiple user groups: schema changes, created FetchUserPermissions(), and an improved can_perform()
- In ProcessBugDataForDisplay() we can use less calls to can_perform when checking canviewhidden* permissions
Robert Sesek [Sat, 17 Mar 2007 23:23:54 +0000 (23:23 +0000)]
r1484: Fixing the automation system for custom fields; this probably got all borked up when we moved the storage location of custom field data
Robert Sesek [Sat, 17 Mar 2007 22:47:01 +0000 (22:47 +0000)]
r1483: Fix the background color system of history_bit.tpl from the changes we made with stylevars
Robert Sesek [Sat, 17 Mar 2007 20:02:05 +0000 (20:02 +0000)]
r1482: Allow NO_VERSION_CHECK constant to actually work by not spelling it "NO_VERSION_CHEK"
Robert Sesek [Sat, 17 Mar 2007 19:41:38 +0000 (19:41 +0000)]
r1481: changes++
Robert Sesek [Sat, 17 Mar 2007 19:38:23 +0000 (19:38 +0000)]
r1480: Remove templates/stylevars.txt and the processing code involved in global.php
Robert Sesek [Sat, 17 Mar 2007 19:36:03 +0000 (19:36 +0000)]
r1479: Remove the need for $stylevar[alt_color] by using the altcolor CSS class by changing the values swapped when calculating rows and using trackerhome_bits.tpl
Robert Sesek [Sat, 17 Mar 2007 19:31:18 +0000 (19:31 +0000)]
r1478: In ListSorter::constructRow(), globalize $bugsys so that in row templates we can use that variable
Robert Sesek [Sat, 17 Mar 2007 19:24:32 +0000 (19:24 +0000)]
r1477: Adding a .altwidth class so that we can remove $stylevar[alternate_width]; replacing all instances of the stylevar with the new CSS class
Robert Sesek [Sat, 17 Mar 2007 19:21:08 +0000 (19:21 +0000)]
r1476: Removing all uses of $stylevar[alt_color] in templates; we just have the code-based ones left
Robert Sesek [Sat, 17 Mar 2007 19:18:32 +0000 (19:18 +0000)]
r1475: In .altcolor we should use background-color and not color for the property. Adding .textcenter class to center-align text.
Robert Sesek [Sat, 17 Mar 2007 19:16:04 +0000 (19:16 +0000)]
r1474: We no loner need the stylevars for cellpadding and cellspacing in tables because we can use CSS properties to achieve the same effect. Removing all the long <table> declarations and just replacing them with styling table with the .table class
Robert Sesek [Sat, 17 Mar 2007 18:42:26 +0000 (18:42 +0000)]
r1473: Because we didn't understand the return val of eval() all our notifications were blank. Fixing by moving all the eval() statements to not be in the assignment operation in NotificationCenter.
Robert Sesek [Sat, 17 Mar 2007 18:36:36 +0000 (18:36 +0000)]
r1472: Fix a string offset bug due to those annoying uses of construct_user_display() in NotificationCenter
Robert Sesek [Sat, 17 Mar 2007 18:25:02 +0000 (18:25 +0000)]
r1471: Fix for bug://report/69: In install/global.php, move the loading of the includes/language.php to be higher up so that the gettext emulation system is enabled sooner
Robert Sesek [Sat, 17 Mar 2007 16:08:45 +0000 (16:08 +0000)]
r1470: Fix two bugs with searching that would:
- Delete the current search if it were ever to be rerun
- Not update the timestamp on cached searches which would cause them to be rerun every time
Robert Sesek [Sat, 17 Mar 2007 16:03:27 +0000 (16:03 +0000)]
r1469: Misspelled TIMENOW in search.php which caused searches to not be rerun after 15 minutes
Robert Sesek [Sat, 17 Mar 2007 15:52:02 +0000 (15:52 +0000)]
r1468: In mailtest.php:
- Check the validity of email addresses before sending
- Make the sending from a non-existent address more effective and meaningful
Robert Sesek [Sat, 17 Mar 2007 15:42:08 +0000 (15:42 +0000)]
r1467: Adding a mailtest script for people who are having problems receiving emails in Bugdar.
Robert Sesek [Fri, 16 Mar 2007 02:27:22 +0000 (02:27 +0000)]
r1466: Fixing a bug in NotificationCenter::send_new_comment_notice() where we weren't getting the userid because we were accessing strings and not the $userid variable
Robert Sesek [Tue, 13 Mar 2007 00:41:25 +0000 (00:41 +0000)]
r1464: These will also probably create improper escape warnings due to doing {"$somevar"}
Robert Sesek [Tue, 13 Mar 2007 00:38:43 +0000 (00:38 +0000)]
r1463: Fix an improper character escape
Robert Sesek [Tue, 13 Mar 2007 00:32:59 +0000 (00:32 +0000)]
r1462: Fix the tag from "verson" to "version"
Robert Sesek [Mon, 12 Mar 2007 01:35:07 +0000 (01:35 +0000)]
r1461: Forgot one prefix
Robert Sesek [Mon, 12 Mar 2007 01:34:23 +0000 (01:34 +0000)]
r1460: Add a few sanity checks in the mass-update system just in case
Robert Sesek [Mon, 12 Mar 2007 00:24:19 +0000 (00:24 +0000)]
r1459: We need to get rid of all the old searches in order for the system to work right again, so do that in mark2
Robert Sesek [Mon, 12 Mar 2007 00:22:57 +0000 (00:22 +0000)]
r1458: Fixed a bug so that now the default column options are used properly
Robert Sesek [Mon, 12 Mar 2007 00:17:02 +0000 (00:17 +0000)]
r1457: We needed to reexport the settings because 'userid' isn't a valid column option
Robert Sesek [Mon, 12 Mar 2007 00:09:58 +0000 (00:09 +0000)]
r1456: We need to add default settings and custom help to the upgrade script because we added them in avalon
Robert Sesek [Mon, 12 Mar 2007 00:09:27 +0000 (00:09 +0000)]
r1455: Removing all the queries we have added to the upgrade script
Robert Sesek [Mon, 12 Mar 2007 00:00:37 +0000 (00:00 +0000)]
r1454: Encase the foreach() loop on components in ConstructProductSelect() so we don't get warnings
Robert Sesek [Sun, 11 Mar 2007 23:55:33 +0000 (23:55 +0000)]
r1453: Stop including includes/setting.php when we don't need to for the upgrade scripts
Robert Sesek [Sun, 11 Mar 2007 23:53:26 +0000 (23:53 +0000)]
r1452: Adding a step to migrate custom field data (which we forgot about... woops!)
Robert Sesek [Sun, 11 Mar 2007 23:43:04 +0000 (23:43 +0000)]
r1451: Updating the schema file
Robert Sesek [Sun, 11 Mar 2007 23:33:07 +0000 (23:33 +0000)]
r1450: Adding upgrade11.php as the upgrade script from 1.1.5 to 1.2.0b1
Robert Sesek [Sun, 11 Mar 2007 23:20:53 +0000 (23:20 +0000)]
r1449: One last change for class_sort.php that now will make _processDataForColumn() work by changing 'userid' to 'reporter' in step with the previous change from r1444
Robert Sesek [Sun, 11 Mar 2007 23:17:25 +0000 (23:17 +0000)]
r1448: Updating the en_US.pot file with the latest language strings
Robert Sesek [Sun, 11 Mar 2007 23:10:00 +0000 (23:10 +0000)]
r1447: Adding the template diff between 1.1.5 and 1.2.0 beta 1
Robert Sesek [Sun, 11 Mar 2007 23:09:21 +0000 (23:09 +0000)]
r1446: Don't show the controls to change the email, password, and displayname unless the authmode is default
Robert Sesek [Sun, 11 Mar 2007 23:02:41 +0000 (23:02 +0000)]
r1445: Dumping default data and settings into the files in preparation for release
Robert Sesek [Sun, 11 Mar 2007 22:56:20 +0000 (22:56 +0000)]
r1444: In all other instances for sorting, the sortby key for reporter is reporter, not userid, so have includes/premissions (and thereby $bugsys->columns and $bugsys->columnNames) reflect that
Robert Sesek [Sun, 11 Mar 2007 22:48:31 +0000 (22:48 +0000)]
r1443: Backing out the changes made in r1442 because our templates just aren't ready to do that
Robert Sesek [Sun, 11 Mar 2007 22:41:06 +0000 (22:41 +0000)]
r1442: Removing usage of $stylevar[alt_color]
Robert Sesek [Sun, 11 Mar 2007 22:03:26 +0000 (22:03 +0000)]
r1441: Adding a phpBB2 authentication module
Robert Sesek [Sun, 11 Mar 2007 21:44:23 +0000 (21:44 +0000)]
r1440: - Fixed a huge bug in Authentication::_syncBugdarUser() that would use the authid as the user ID in the Bugdar database as the condition when syncing
- Only call Authenticatoin::clearCookies() in Autthentication::authenticateCookies() if the cookie data fails to verify, and not in other cases
Robert Sesek [Sun, 11 Mar 2007 06:44:43 +0000 (06:44 +0000)]
r1439: Removing trailing whitespace from includes/auth/auth.php
Robert Sesek [Sun, 11 Mar 2007 06:21:54 +0000 (06:21 +0000)]
r1438: Fix a small bug and remove some useless code in AuthenticationDrupal::_fetchCookieUniqueId()
Robert Sesek [Sun, 11 Mar 2007 06:16:00 +0000 (06:16 +0000)]
r1437: Adding an authentication module for Drupal, AuthenticationDrupal
Robert Sesek [Sun, 11 Mar 2007 06:15:43 +0000 (06:15 +0000)]
r1436: In AuthenticationVbulletin, we can drop _fetchBugdarUserFromAuthUser() because Authentication now implements this
Robert Sesek [Sun, 11 Mar 2007 05:58:41 +0000 (05:58 +0000)]
r1435: Fixed a bug in Authentication that could potentially cause the Bugdar user to be synced every time due to the fact that the values in bugdarUser[] aren't filled
Robert Sesek [Sun, 11 Mar 2007 05:37:32 +0000 (05:37 +0000)]
r1434: Implement Authentication::_fetchBugdarUserFromAuthUser() ourselves now that we have a field map
Robert Sesek [Mon, 5 Mar 2007 05:02:27 +0000 (05:02 +0000)]
r1433: changes += 2
Robert Sesek [Mon, 5 Mar 2007 04:55:36 +0000 (04:55 +0000)]
r1432: Make logout work by calling Authentication::clearCookies()
Robert Sesek [Mon, 5 Mar 2007 04:51:01 +0000 (04:51 +0000)]
r1431: Remove "password" from the list of fields to sync so that existing Bugdar users don't have their password killed
Robert Sesek [Mon, 5 Mar 2007 04:50:08 +0000 (04:50 +0000)]
r1430: Move up the loading of the permissions file so that build_assignedto() works
Robert Sesek [Mon, 5 Mar 2007 04:47:42 +0000 (04:47 +0000)]
r1429: Refactoring Authentication::_clearCookies() to be clearCookies()
Robert Sesek [Mon, 5 Mar 2007 04:43:48 +0000 (04:43 +0000)]
r1428: In Authentication::_syncBugdarUser(), only run UserAPI->update() if fields have actually changed
Robert Sesek [Mon, 5 Mar 2007 04:37:29 +0000 (04:37 +0000)]
r1427: More work on the authentication system:
- Adding a list of fields that will be synced between Bugdar and the auth db
- Authentication::_createBugdarUser() is now implemented in the abstract class because we have a sync-fields list
- Authentication::_syncBugdarUser() is responsible for syncing the already-created Bugdar user with the user in the auth db
Robert Sesek [Tue, 27 Feb 2007 04:29:25 +0000 (04:29 +0000)]
r1426: When using USE_DEFAULT_AUTH_METHOD, we don't actually want to change the value in $bugsys->options[] because that means we can't see what the current value of the setting is
Robert Sesek [Tue, 27 Feb 2007 04:25:41 +0000 (04:25 +0000)]
r1425: - The new vBulletin authentication API now works
- If you define the USE_DEFAULT_AUTH_METHOD as 1 then Bugdar will ignore any authentication system set and will just the Bugdar database
Robert Sesek [Tue, 27 Feb 2007 03:22:26 +0000 (03:22 +0000)]
r1424: Add the initial authentication system for vBulletin
Robert Sesek [Tue, 27 Feb 2007 03:22:13 +0000 (03:22 +0000)]
r1423: In login.php, we need to get the user ID in order to do a cplogin
Robert Sesek [Mon, 26 Feb 2007 21:38:54 +0000 (21:38 +0000)]
r1422: Authentication API:
- Allowing Authentication::_setCookies() to have a $sticky flag to make
the cookies permanent
- Implementing the login methods in AuthenticationDefault and setting
them up in login.php
Robert Sesek [Mon, 26 Feb 2007 06:24:11 +0000 (06:24 +0000)]
r1421: Authentication::_verifyLoginUser() takes a string...
Robert Sesek [Mon, 26 Feb 2007 03:55:57 +0000 (03:55 +0000)]
r1420: More work on the authentication system:
- Added the authmethod setting to allow the admin to choose what authentication system to use
- In init.php, we now use the authentication API to validate the cookies
- Added Authentication::fetchBugdarUser() and fixed a small parse error
Robert Sesek [Mon, 26 Feb 2007 02:47:45 +0000 (02:47 +0000)]
r1419: Beginning to implement the authentication API:
- Adding authid to the users table
- Creating the abstract authentication class
Robert Sesek [Sun, 25 Feb 2007 18:54:37 +0000 (18:54 +0000)]
r1418: Our template was missing these slashes
Robert Sesek [Wed, 21 Feb 2007 21:40:38 +0000 (21:40 +0000)]
r1417: Make the changelog use the new format of categorizing changes
Robert Sesek [Fri, 16 Feb 2007 20:16:23 +0000 (20:16 +0000)]
r1416: Cleaned up and refactored the MessageReporter class
Robert Sesek [Fri, 16 Feb 2007 07:18:48 +0000 (07:18 +0000)]
r1415: Replacing all the URLs in the changelog to be minilinks
Robert Sesek [Fri, 16 Feb 2007 07:15:11 +0000 (07:15 +0000)]
r1414: Adding an instructions file on how to prepare for releases
Robert Sesek [Fri, 16 Feb 2007 06:52:29 +0000 (06:52 +0000)]
r1413: Fixing the installer to allow settings to actually be inserted into the database
Robert Sesek [Thu, 15 Feb 2007 02:35:06 +0000 (02:35 +0000)]
r1412: Using the new database caching feature of ISSO's template system