From 1099404013353fab50ea2190f88f5843f283f21a Mon Sep 17 00:00:00 2001 From: Elisamuel Resto Date: Fri, 13 Jun 2008 22:29:08 -0400 Subject: [PATCH] Templates XHTML compliance fixes Nearly all modified templates had a issue of: - no xmlns tag inside of the html tag - no type tag inside the stylesheet link rel's - no /> for some form elements bugfield_input_text was missing a ending > for maxlength that made the output visually break, and push everything onto one column, also making validation fail. There are other validation warnings, such as for empty options in select fields among others, but those are non-offensive, thus they don't exactly need attention. Signed-off-by: Elisamuel Resto --- templates/bugfield_input_text.tpl | 2 +- templates/editattach.tpl | 8 ++-- templates/editcomment.tpl | 8 ++-- templates/explain_automation.tpl | 2 +- templates/explain_product.tpl | 2 +- templates/favorites.tpl | 2 +- templates/headinclude.tpl | 2 +- templates/help_window.tpl | 6 +-- templates/history.tpl | 2 +- templates/login.tpl | 8 ++-- templates/lostpassword.tpl | 8 ++-- templates/newattach.tpl | 10 ++-- templates/newreport.tpl | 36 +++++++------- templates/passwordreset.tpl | 8 ++-- templates/quicksearch.tpl | 12 ++--- templates/register.tpl | 8 ++-- templates/search.tpl | 48 +++++++++---------- templates/search_results.tpl | 2 +- templates/search_save.tpl | 12 ++--- templates/search_update.tpl | 30 ++++++------ templates/showreport.tpl | 58 +++++++++++------------ templates/std_error.tpl | 6 +-- templates/std_message.tpl | 12 ++--- templates/std_redirect.tpl | 10 ++-- templates/trackerhome.tpl | 2 +- templates/userctrl.tpl | 78 +++++++++++++++---------------- 26 files changed, 191 insertions(+), 191 deletions(-) diff --git a/templates/bugfield_input_text.tpl b/templates/bugfield_input_text.tpl index b321b1e..576fc8f 100644 --- a/templates/bugfield_input_text.tpl +++ b/templates/bugfield_input_text.tpl @@ -1,6 +1,6 @@
$field[name] $help[field$field[fieldid]] -
maxlength="$field[maxlength] />
+
maxlength="$field[maxlength]" />
diff --git a/templates/editattach.tpl b/templates/editattach.tpl index 06b9af5..bfffd9e 100644 --- a/templates/editattach.tpl +++ b/templates/editattach.tpl @@ -1,8 +1,8 @@ $doctype - + $headinclude - + $attachment[filename] - $bug[summary] @@ -19,11 +19,11 @@ $header
{@"Attachment #%1$s for Bug #%2$s %3$s"}
- +
{@"Attachment"}: {@"View"} [$attachment[filename]]
- +
{@"Description"}:
{@"Obsolete"}: checked="checked" />
diff --git a/templates/editcomment.tpl b/templates/editcomment.tpl index b03c443..570e8f4 100644 --- a/templates/editcomment.tpl +++ b/templates/editcomment.tpl @@ -1,8 +1,8 @@ $doctype - + $headinclude - + <lang 1="$comment[commentid]">{@"Edit Comment %1$s"}</lang> - $bug[summary] @@ -25,9 +25,9 @@ $header
{@"Comment #%1$s in bug #%2$s %3$s"}
- +
{@"Posted on %1$s by %2$s"}
- +
style="color: red">{@"Hidden"}: checked="checked" />
{@"Parse Links in the Comment"}: checked="checked" />
diff --git a/templates/explain_automation.tpl b/templates/explain_automation.tpl index b66c4ee..90fb868 100644 --- a/templates/explain_automation.tpl +++ b/templates/explain_automation.tpl @@ -1,5 +1,5 @@ $doctype - + $headinclude {$bugsys->options['trackertitle']} - {@"Automations"} diff --git a/templates/explain_product.tpl b/templates/explain_product.tpl index c67aec6..cc841b4 100644 --- a/templates/explain_product.tpl +++ b/templates/explain_product.tpl @@ -1,5 +1,5 @@ $doctype - + $headinclude {$bugsys->options['trackertitle']} - {@"Products"} diff --git a/templates/favorites.tpl b/templates/favorites.tpl index fa81285..36e9234 100644 --- a/templates/favorites.tpl +++ b/templates/favorites.tpl @@ -1,5 +1,5 @@ $doctype - + $headinclude {$bugsys->options['trackertitle']} - {@"My Favorite Bugs"} diff --git a/templates/headinclude.tpl b/templates/headinclude.tpl index 24c16d9..339ec1a 100644 --- a/templates/headinclude.tpl +++ b/templates/headinclude.tpl @@ -1,6 +1,6 @@ - + \ No newline at end of file diff --git a/templates/help_window.tpl b/templates/help_window.tpl index 24b575c..181aa55 100644 --- a/templates/help_window.tpl +++ b/templates/help_window.tpl @@ -1,8 +1,8 @@ $doctype - + $headinclude - + {@"Help"} - $topic[title] @@ -11,7 +11,7 @@ $headinclude
{@"Help"} : $topic[title]
- +
$topic[body]
diff --git a/templates/history.tpl b/templates/history.tpl index 13134ae..88add76 100644 --- a/templates/history.tpl +++ b/templates/history.tpl @@ -1,5 +1,5 @@ $doctype - + $headinclude {@"Bug History"} - $bug[summary] diff --git a/templates/login.tpl b/templates/login.tpl index 58df23e..17840a2 100644 --- a/templates/login.tpl +++ b/templates/login.tpl @@ -1,8 +1,8 @@ $doctype - + $headinclude - + {$bugsys->options['trackertitle']} - {@"Login"} @@ -17,7 +17,7 @@ $header
{@"Login"}
- +
{@"Email"}:
{@"Password"}:
@@ -25,7 +25,7 @@ $header
[{@"Register"}] [{@"Lost Password"}]
- +
diff --git a/templates/lostpassword.tpl b/templates/lostpassword.tpl index 84e5ff2..9694a9f 100644 --- a/templates/lostpassword.tpl +++ b/templates/lostpassword.tpl @@ -1,8 +1,8 @@ $doctype - + $headinclude - + {$bugsys->options['trackertitle']} - {@"Lost Password"} @@ -16,13 +16,13 @@ $header
{@"Lost Password Recovery"}
- +
{@"The specified email could not be found or it is invalid."}
{@"Enter your email in the box below and you will receive a message with instructions on how to set a new password."}
{@"Email"}:
- +
diff --git a/templates/newattach.tpl b/templates/newattach.tpl index 0bbac09..99e6892 100644 --- a/templates/newattach.tpl +++ b/templates/newattach.tpl @@ -1,8 +1,8 @@ $doctype - + $headinclude - + {@"New Attachment"} - $bug[summary] @@ -25,12 +25,12 @@ $header
{@"New Attachment for Bug #%1$s %2$s"}
- +
{@"Description"}:
- +
{@"Mark the Following Attachments Obsolete"}: @@ -38,7 +38,7 @@ $header
- +
{@"Add Comment"}: diff --git a/templates/newreport.tpl b/templates/newreport.tpl index e164226..61c8801 100644 --- a/templates/newreport.tpl +++ b/templates/newreport.tpl @@ -1,9 +1,9 @@ $doctype - + $headinclude - - + + {@"New Bug Report"} - {$bugsys->options['trackertitle']} @@ -24,21 +24,21 @@ $header
- +
{@"Reporter"} $help[reporter]
$reporter
- +
{@"Product/Version"} $help[product]
- +
@@ -47,29 +47,29 @@ $header
- +
{@"Severity"} $help[severity]
- + $customfields[left] - +
- +
- +
{@"Summary"} $help[summary]
- +
@@ -78,7 +78,7 @@ $header
- +
@@ -87,7 +87,7 @@ $header
- +
@@ -96,9 +96,9 @@ $header
- + $customfields[right] - +
@@ -109,9 +109,9 @@ $header
{@"Description/Initial Report"} - + - +
checked="checked" /> {@"Parse Links in the Comment"}
diff --git a/templates/passwordreset.tpl b/templates/passwordreset.tpl index afec961..7ce3eb2 100644 --- a/templates/passwordreset.tpl +++ b/templates/passwordreset.tpl @@ -1,8 +1,8 @@ $doctype - + $headinclude - + {$bugsys->options['trackertitle']} - {@"Reset Password"} @@ -24,13 +24,13 @@ $header
{@"Lost Password Recovery: Password Reset"}
- +
{@"Enter a new password below and then confirm it."}
{@"New Password"}:
{@"Confirm Password"}:
- +
diff --git a/templates/quicksearch.tpl b/templates/quicksearch.tpl index 5f871d8..4c6cdd1 100644 --- a/templates/quicksearch.tpl +++ b/templates/quicksearch.tpl @@ -1,8 +1,8 @@ $doctype - + $headinclude - + {$bugsys->options['trackertitle']} - {@"Quick Search"} @@ -13,17 +13,17 @@ $header
{@"Quick Search"}
- +
$error
 - +
- + {@"Go to bug ID"} - +
diff --git a/templates/register.tpl b/templates/register.tpl index 996b7f4..5eec074 100644 --- a/templates/register.tpl +++ b/templates/register.tpl @@ -1,8 +1,8 @@ $doctype - + $headinclude - + {$bugsys->options['trackertitle']} - {@"Register"} @@ -23,7 +23,7 @@ $header
{@"Register"}
- +
{@"Email"}:
{@"Confirm Email"}:
@@ -33,7 +33,7 @@ $header
{@"Show My Email Publicly"}: checked="checked" /> {@"Yes"}
{@"Language"}:
- +
diff --git a/templates/search.tpl b/templates/search.tpl index 0d2631f..bbfcbc1 100644 --- a/templates/search.tpl +++ b/templates/search.tpl @@ -1,9 +1,9 @@ $doctype - + $headinclude - - + + {$bugsys->options['trackertitle']} - {@"Search"} @@ -26,11 +26,11 @@ $header
- +
{@"Search Mode"} - +
- +
{@"Product / Version"} $help[product]
- +
{@"Status"} $help[status]
- +
{@"Priority"} $help[priority]
- +
{@"Date (submitted since)"} - +
- +
{@"Sort By"} - +
- + $select[dev]
- +
{@"Resolution"} $help[resolution]
- +
{@"Severity"} $help[severity]
- +
@@ -161,9 +161,9 @@ $header
- + $customfields[right] - +
diff --git a/templates/search_results.tpl b/templates/search_results.tpl index 6105743..a7e730d 100644 --- a/templates/search_results.tpl +++ b/templates/search_results.tpl @@ -1,5 +1,5 @@ $doctype - + $headinclude {$bugsys->options['trackertitle']} - {@"Search Results"} diff --git a/templates/search_save.tpl b/templates/search_save.tpl index e02c759..fe20921 100644 --- a/templates/search_save.tpl +++ b/templates/search_save.tpl @@ -1,8 +1,8 @@ $doctype - + $headinclude - + {$bugsys->options['trackertitle']} - {@"Save Search"} @@ -24,16 +24,16 @@ $header
{@"Save Search"}
- +
{@"You can save this search criteria for later by naming this search."} - +

- +
{@"Name"}:
- +
diff --git a/templates/search_update.tpl b/templates/search_update.tpl index ec240a8..5fbcc9c 100644 --- a/templates/search_update.tpl +++ b/templates/search_update.tpl @@ -1,9 +1,9 @@ $doctype - + $headinclude - - + + {$bugsys->options['trackertitle']} - {@"Mass Update"} @@ -20,57 +20,57 @@ $header
- +
{@"Product / Version"} $help[product]
- +
{@"Status"} $help[status]
- +
{@"Priority"} $help[priority]
- + $customfields[left] - +
- +
- +
{@"Assignment"} $help[assignedto]
- +
{@"Resolution"} $help[resolution]
- +
{@"Severity"} $help[severity]
- +
@@ -85,9 +85,9 @@ $header
- + $customfields[right] - +
diff --git a/templates/showreport.tpl b/templates/showreport.tpl index 812936d..967e4eb 100644 --- a/templates/showreport.tpl +++ b/templates/showreport.tpl @@ -1,10 +1,10 @@ $doctype - + $headinclude - - - + + + <lang 1="$bug[bugid]">{@"Bug Report %1$s"}</lang> - $bug[summary_title] @@ -19,13 +19,13 @@ $header
- +
{@"Bug Id"} $help[bugid]
$bug[bugid] - + / class="error">{@"Hidden"}: @@ -33,21 +33,21 @@ $header / {@"Hidden Bug"} - + / [{@"Show Bug History"}] / [$favoritetext] / [{@"Delete"}]
- +
{@"Reporter"} $help[reporter]
$bug[userinfo]
- +
{@"Product/Version"} $help[product] @@ -80,7 +80,7 @@ $header
- +
{@"Duplicate Of"} $help[duplicateof] @@ -94,15 +94,15 @@ $header
- + $customfields[left] - +
- +
- +
{@"Summary"} $help[summary] @@ -115,14 +115,14 @@ $header
- +
{@"Report Time"} $help[dateline]
$bug[datetime]
- +
{@"Assignment"} $help[assignedto] @@ -135,7 +135,7 @@ $header
- +
{@"Resolution"} $help[resolution] @@ -148,7 +148,7 @@ $header
- +
{@"Priority"} $help[priority] @@ -161,7 +161,7 @@ $header
- +
{@"Dependencies"} $help[dependency] @@ -174,7 +174,7 @@ $header
- + $customfields[right]
@@ -189,9 +189,9 @@ $header
{@"New Reply"} : {@"Automation"} $help[newreply] - + - +
checked="checked" /> {@"Parse Links in the Comment"}
@@ -211,43 +211,43 @@ $header
- +
{@"Attachments"} : {@"New"} - + $attachments
- +
fiftyhundred">
{@"Votes"} - +
{@"For"}: $vote[votefor] ($vote[forpercent]%)
{@"Against"}: $vote[voteagainst] ($vote[againstpercent]%)
{@"Total"}: $vote[total]
- +
{@"Your Vote"} - +
{@"Vote For (+1)"}
{@"Vote Against (-1)"}
- +
diff --git a/templates/std_error.tpl b/templates/std_error.tpl index 40cfa09..d821a31 100644 --- a/templates/std_error.tpl +++ b/templates/std_error.tpl @@ -1,8 +1,8 @@ $doctype - + $headinclude - + {$bugsys->options['trackertitle']} - {@"Error"} @@ -13,7 +13,7 @@ $header
{@"Error"}
- +
$error
diff --git a/templates/std_message.tpl b/templates/std_message.tpl index 20aef5c..1b7afaa 100644 --- a/templates/std_message.tpl +++ b/templates/std_message.tpl @@ -1,8 +1,8 @@ $doctype - + $headinclude - + {$bugsys->options['trackertitle']} - <if condition="$show['confirm']">{@"Confirm"}<else />{@"Notice"}</if> @@ -19,16 +19,16 @@ $extra
{@"Confirm"}{@"Notice"}
- +
$message - +

- +
- +
diff --git a/templates/std_redirect.tpl b/templates/std_redirect.tpl index 2e6ac39..22276f5 100644 --- a/templates/std_redirect.tpl +++ b/templates/std_redirect.tpl @@ -1,8 +1,8 @@ $doctype - + $headinclude - + {$bugsys->options['trackertitle']} - {@"Redirect..."} @@ -14,13 +14,13 @@ $header
{@"Redirect..."}
- +
$message - +

- + {@"If you are not redirected in a few seconds, click here."}
diff --git a/templates/trackerhome.tpl b/templates/trackerhome.tpl index 2d5b961..f446a41 100644 --- a/templates/trackerhome.tpl +++ b/templates/trackerhome.tpl @@ -1,5 +1,5 @@ $doctype - + $headinclude {$bugsys->options['trackertitle']} - {@"Bug Listing"} diff --git a/templates/userctrl.tpl b/templates/userctrl.tpl index 16a962b..8c4fc62 100644 --- a/templates/userctrl.tpl +++ b/templates/userctrl.tpl @@ -1,9 +1,9 @@ $doctype - + $headinclude - - + + {$bugsys->options['trackertitle']} - {@"User Options"} @@ -27,7 +27,7 @@ $header
{@"User Options"}
- +
@@ -35,29 +35,29 @@ $header
- +
{@"Show Email Publicly"} checked="checked" /> {@"Yes"} checked="checked" /> {@"No"}
- +
{@"Show Status Colors on Bug Listings"} checked="checked" /> {@"Yes"} checked="checked" /> {@"No"}
- +
{@"Language"}
- +
{@"Timezone"}
- +
{@"Observe Daylight Savings Time (DST)"} checked="checked" /> {@"Yes, I'm currently observing DST"} @@ -65,34 +65,34 @@ $header
- +
- +
{@"Email Options"}
- +
- + - + - + - + - + - + @@ -101,7 +101,7 @@ $header - + @@ -110,7 +110,7 @@ $header - + @@ -119,7 +119,7 @@ $header - + @@ -128,7 +128,7 @@ $header - + @@ -141,14 +141,14 @@ $header - +
- +
{@"Saved Searches"}
- +
$searches
@@ -156,7 +156,7 @@ $header - +
 {@"Reporter"}{@"Reporter"} {@"Assignee"}{@"Favorite"}{@"Favorite"} {@"Voter"}{@"Commenter"}{@"Commenter"}
{@"New bug is added"}
{@"I am made the assignee"}
{@"Status or resolution changes"}
{@"'Duplicates' field is changed"}
{@"A new comment is added"}
{@"A new attachment is added"}
{@"Any other field changes"} @@ -164,28 +164,28 @@ $header
{@"Please enter your password to change these fields"}:
- +
- +
{@"Password"}
- +
{@"Confirm Password"}
- +
{@"Email"}
- +
{@"Confirm Email"} @@ -193,30 +193,30 @@ $header
- +
- +
{@"Bug List Display Options"}
- +
{@"Hidden Statuses on Bug Listing"}
- +
{@"Default Sort Order Column"} $defaultsortkey
- +
{@"Default Sort Order Direction"} $defaultsortas
- +
{@"Bug List Columns"} $help[columnorder] @@ -229,9 +229,9 @@ $header
- +
- +
-- 2.22.5