From 2cb9934ac8c80052e43fd0bcc0c423912bfceacf Mon Sep 17 00:00:00 2001 From: Robert Sesek Date: Tue, 7 Apr 2020 07:36:36 -0400 Subject: [PATCH] Reduce the number of user queries for assignto log changes. --- showreport.php | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/showreport.php b/showreport.php index 989dd26..b3cd705 100644 --- a/showreport.php +++ b/showreport.php @@ -343,6 +343,7 @@ while ($log = $db->fetch_array($logs_fetch)) ksort($logs); $toKill = array(); +$logusers = array(); foreach ($logs AS $dateline => $logitems) { @@ -392,20 +393,28 @@ foreach ($logs AS $dateline => $logitems) { if ($log['original']) { - $user = new UserAPI($bugsys); - $user->set('userid', $log['original']); - $user->set_condition(); - $user->fetch(); - $log['original'] = construct_user_display($user->objdata); + if (!$logusers[$log['original']]) + { + $user = new UserAPI($bugsys); + $user->set('userid', $log['original']); + $user->set_condition(); + $user->fetch(); + $logusers[$log['original']] = construct_user_display($user->objdata); + } + $log['original'] = $logusers[$log['original']]; } if ($log['changed']) { - $user = new UserAPI($bugsys); - $user->set('userid', $log['changed']); - $user->set_condition(); - $user->fetch(); - $log['changed'] = construct_user_display($user->objdata); + if (!$logusers[$log['changed']]) + { + $user = new UserAPI($bugsys); + $user->set('userid', $log['changed']); + $user->set_condition(); + $user->fetch(); + $logusers[$log['changed']] = construct_user_display($user->objdata); + } + $log['changed'] = $logusers[$log['changed']]; } } } -- 2.22.5