From 32784216e8e2e5052b3737adf9f7ed4f04e959f6 Mon Sep 17 00:00:00 2001
From: Robert Sesek <rsesek@bluestatic.org>
Date: Mon, 20 Nov 2006 01:53:57 +0000
Subject: [PATCH] r1294: Add maxlenth attributes to all <input:text> elements
 so the database doesn't truncate without the user knowning

---
 docs/changes.txt         |  1 +
 templates/editattach.tpl |  2 +-
 templates/newattach.tpl  |  2 +-
 templates/newreport.tpl  |  2 +-
 templates/showreport.tpl |  2 +-
 templates/userctrl.tpl   | 12 ++++++------
 6 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/docs/changes.txt b/docs/changes.txt
index 43755e1..20d35e8 100644
--- a/docs/changes.txt
+++ b/docs/changes.txt
@@ -18,6 +18,7 @@
 - Adding a quick search feature to the header bar (http://www.bluestatic.org/bugs/showreport.php?bugid=57)
 - Fixed an occurence in header.tpl where the $stylevar align wasn't used, but a hard-coded one was
 - Only allow JPG, JPEG, PNG, and GIF attachments to be displayed inline because all other types could lead to an XSS attack
+- Added maxlength attributes to all <input type="text"/> fields so the database doesn't truncate (http://www.bluestatic.org/bugs/showreport.php?bugid=58)
 
 1.1.3
 ===============================
diff --git a/templates/editattach.tpl b/templates/editattach.tpl
index 67a9aa7..06b9af5 100644
--- a/templates/editattach.tpl
+++ b/templates/editattach.tpl
@@ -25,7 +25,7 @@ $header
 	</div>
 	
 	<div class="box-mid" style="text-align: $stylevar[left]">
-		<div><strong>{@"Description"}:</strong> <input name="description" type="text" size="35" value="$attachment[description]" /></div>
+		<div><strong>{@"Description"}:</strong> <input name="description" type="text" size="35" maxlength="250" value="$attachment[description]" /></div>
 		<div><strong>{@"Obsolete"}:</strong> <input name="obsolete" type="checkbox" value="1"<if condition="$attachment['obsolete']"> checked="checked"</if> /></div>
 	</div>
 </div>
diff --git a/templates/newattach.tpl b/templates/newattach.tpl
index 73e59f9..aa019c2 100644
--- a/templates/newattach.tpl
+++ b/templates/newattach.tpl
@@ -28,7 +28,7 @@ $header
 	
 	<div class="box-mid box-margmod-bottom" style="text-align: $stylevar[left]">
 		<div><input name="attachment" type="file" /></div>
-		<div><strong>{@"Description"}:</strong> <input name="description" type="text" size="35" value="{$bugsys->in['description']}" /></div>
+		<div><strong>{@"Description"}:</strong> <input name="description" type="text" size="35" value="{$bugsys->in['description']}" maxlength="250" /></div>
 	</div>
 	
 	<if condition="$show['obsoletes']">
diff --git a/templates/newreport.tpl b/templates/newreport.tpl
index 22e3212..ae07d35 100644
--- a/templates/newreport.tpl
+++ b/templates/newreport.tpl
@@ -66,7 +66,7 @@ $header
 		<!-- summary -->
 		<fieldset>
 			<legend>{@"Summary"} $help[summary]</legend>
-			<div class="field"><input type="text" name="summary" size="25" value="{$bugsys->in['summary']}" style="width: 100%" /></div>
+			<div class="field"><input type="text" name="summary" size="25" value="{$bugsys->in['summary']}" style="width: 100%" maxlength="250" /></div>
 		</fieldset>
 		<!-- / summary -->
 		
diff --git a/templates/showreport.tpl b/templates/showreport.tpl
index 21dc1bc..54c930e 100644
--- a/templates/showreport.tpl
+++ b/templates/showreport.tpl
@@ -114,7 +114,7 @@ $header
 			<legend>{@"Summary"} $help[summary]</legend>
 			<div class="field">
 				<if condition="$show['edit']">
-					<input type="text" name="summary" size="25" value="$bug[summary]" style="width: 100%" />
+					<input type="text" name="summary" size="25" value="$bug[summary]" style="width: 100%" maxlength="250" />
 				<else />
 					$bug[summary]
 				</if>
diff --git a/templates/userctrl.tpl b/templates/userctrl.tpl
index d8ace7d..fa15e40 100644
--- a/templates/userctrl.tpl
+++ b/templates/userctrl.tpl
@@ -31,7 +31,7 @@ $header
 				<div class="box-mid">
 					<fieldset>
 						<legend>{@"Display Name"}</legend>
-						<input type="text" name="displayname" value="{$userinfo['displayname']}" size="25" style="width: 100%" />
+						<input type="text" name="displayname" value="{$userinfo['displayname']}" size="25" style="width: 100%" maxlength="250" />
 					</fieldset>
 					
 					<fieldset>
@@ -74,30 +74,30 @@ $header
 					{@"Please enter your password to change these fields"}:
 					<br />
 					
-					<input type="password" name="validate" size="35" />
+					<input type="password" name="validate" size="35" maxlength="250" />
 				</div>
 				
 				<div class="box-mid box-margmod-top">
 					<fieldset>
 						<legend>{@"Password"}</legend>
-						<input type="password" name="password_change" size="25" style="width: 100%" />
+						<input type="password" name="password_change" size="25" style="width: 100%" maxlength="250" />
 					</fieldset>
 					
 					<fieldset>
 						<legend>{@"Confirm Password"}</legend>
-						<input type="password" name="password_confirm" size="25" style="width: 100%" />
+						<input type="password" name="password_confirm" size="25" style="width: 100%" maxlength="250" />
 					</fieldset>
 				</div>
 				
 				<div class="box-mid box-margmod-top">
 					<fieldset>
 						<legend>{@"Email"}</legend>
-						<input type="text" name="email_change" size="25" value="$email" style="width: 100%" />
+						<input type="text" name="email_change" size="25" value="$email" style="width: 100%" maxlength="250" />
 					</fieldset>
 					
 					<fieldset>
 						<legend>{@"Confirm Email"}</legend>
-						<input type="text" name="email_confirm" size="25" value="$email_confirm" style="width: 100%" />
+						<input type="text" name="email_confirm" size="25" value="$email_confirm" style="width: 100%" maxlength="250" />
 					</fieldset>
 				</div>
 			</div>
-- 
2.22.5