From 4acbd79d2505afbfcbc0263b977301c6c0f425c0 Mon Sep 17 00:00:00 2001 From: Robert Sesek Date: Sun, 18 Mar 2007 04:50:06 +0000 Subject: [PATCH] r1493: In admin/product.php, move the page_start() call in the addversion branch to be after the check for invalid products so we don't end up with a small display bug if the error is thrown --- admin/product.php | 4 ++-- docs/changes.txt | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/admin/product.php b/admin/product.php index cd78dea..dd1b475 100755 --- a/admin/product.php +++ b/admin/product.php @@ -111,8 +111,6 @@ if ($_REQUEST['do'] == 'addversion') NavLinks::productsEdit($bugsys->input_clean('productid', TYPE_UINT)); $navigator->set_focus('link', 'products-edit-version', 'products-edit'); - $admin->page_start(_('Add Version')); - if ($bugsys->in['productid'] != -1) { $product = $db->query_first("SELECT * FROM " . TABLE_PREFIX . "product WHERE productid = " . $bugsys->in['productid']); @@ -126,6 +124,8 @@ if ($_REQUEST['do'] == 'addversion') $bugsys->in['productid'] = 0; } + $admin->page_start(_('Add Version')); + $admin->form_start('product.php', 'insertversion'); $admin->form_hidden_field('productid', $bugsys->in['productid']); $admin->table_start(); diff --git a/docs/changes.txt b/docs/changes.txt index 4805c1c..a34ea3e 100644 --- a/docs/changes.txt +++ b/docs/changes.txt @@ -11,6 +11,7 @@ - Fixed: Automations would have no effect on custom fields when running them from the edit screen - Fixed: A SQL error would occur when saving creating a new usergroup - Fixed: In the product-level permissions screens, not all the products would always show up +- Fixed: A minor display issue would occur in a rare instance when showing an error message when trying to add a version without a product 1.2.0 Beta 1 =============================== -- 2.22.5