From 52954ec8d02a92ca6b9350a60a383c7e69e5e513 Mon Sep 17 00:00:00 2001 From: Robert Sesek Date: Fri, 16 Mar 2007 02:27:22 +0000 Subject: [PATCH] r1466: Fixing a bug in NotificationCenter::send_new_comment_notice() where we weren't getting the userid because we were accessing strings and not the $userid variable --- docs/changes.txt | 5 ++++- includes/class_notification.php | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/changes.txt b/docs/changes.txt index 5d81d3d..f89bca4 100644 --- a/docs/changes.txt +++ b/docs/changes.txt @@ -1,3 +1,7 @@ +1.2.0 Beta 2 +=============================== +- Fixed: Emails wouldn't be sent out for new comments do to a bug with updating the notices array + 1.2.0 Beta 1 =============================== - Change: When a user does not have any favorites in his list, show a message instead of an empty screen @@ -26,7 +30,6 @@ 1.1.5 =============================== - - Fixed a potential SQL error on search.php because no results were found (bug://report/62) - Fixed a SQL error on admin/user.php when adding a new user from the admin section (bug://report/63) - When adding a new user from the admin section, email options were not saved properly diff --git a/includes/class_notification.php b/includes/class_notification.php index 034b46d..567afb4 100644 --- a/includes/class_notification.php +++ b/includes/class_notification.php @@ -440,7 +440,7 @@ class NotificationCenter $user = construct_user_display($this->registry->userinfo, false); $date = $this->registry->modules['date']->format($this->registry->options['dateformat'], $comment['dateline']); - $this->notices["$user[userid]"][] = eval('$email = "' . $this->registry->template->fetch('email/notice_comment.part') . '";'); + $this->notices["$userid"][] = eval('$email = "' . $this->registry->template->fetch('email/notice_comment.part') . '";'); } } @@ -572,6 +572,7 @@ class NotificationCenter { if ($userid == $this->registry->userinfo['userid']) { + $this->registry->debug("skipping user $userid because they're the one doing the thing"); continue; } -- 2.22.5