From 657896cf60c0a4d23de13b342a0608858d995b02 Mon Sep 17 00:00:00 2001
From: Robert Sesek <rsesek@bluestatic.org>
Date: Sat, 16 Sep 2006 19:49:51 +0000
Subject: [PATCH] r1148: Change the way we generate the feed. Less looping is
 better.

---
 syndicate.php | 98 ++++++++++++++++++++++-----------------------------
 1 file changed, 43 insertions(+), 55 deletions(-)

diff --git a/syndicate.php b/syndicate.php
index 41de1e9..cd500d2 100644
--- a/syndicate.php
+++ b/syndicate.php
@@ -2,7 +2,7 @@
 /*=====================================================================*\
 || ###################################################################
 || # Bugdar [#]version[#]
-|| # Copyright ©2002-[#]year[#] Blue Static
+|| # Copyright ©2002-[#]year[#] Blue Static
 || #
 || # This program is free software; you can redistribute it and/or modify
 || # it under the terms of the GNU General Public License as published by
@@ -29,8 +29,10 @@ if (!can_perform('canviewbugs'))
 }
 
 // ###################################################################
-// get the syndicated items and prepare their content
 
+header('Content-type: application/xml');
+
+$syndicate = '';
 $timestamp = (can_perform('canviewhidden', 0, fetch_guest_user()) ? 'lastposttime' : 'hiddenlastposttime');
 $lastupdated = 0;
 $buglist = array();
@@ -46,46 +48,46 @@ $bugs_fetch = $db->query("
 );
 while ($bug = $db->fetch_array($bugs_fetch))
 {
-	$bug['storytext'] = htmlspecialchars(sprintf(
-		_('<table cellspacing="0" cellpadding="3" border="0">
-<tr>
-	<td><strong>Bug ID:</strong></td>
-	<td>%1$s</td>
-</tr>
-<tr>
-	<td><strong>Summary:</strong></td>
-	<td>%2$s</td>
-</tr>
-<tr>
-	<td><strong>Product/Component/Version:</strong></td>
-	<td>%3$s</td>
-</tr>
-<tr>
-	<td><strong>Status:</strong></td>
-	<td>%4$s</td>
-</tr>
-<tr>
-	<td><strong>Severity:</strong></td>
-	<td>%5$s</td>
-</table>
-
-<p>%6$s</p>'),
-		$bug['bugid'],
-		$bug['summary'],
-		$bugsys->datastore['product']["$bug[product]"]['title'] . '/' . (($bug['component']) ? $bugsys->datastore['product']["$bug[component]"]['title'] . '/' : '') . $bugsys->datastore['version']["$bug[version]"]['version'],
-		$bugsys->datastore['status']["$bug[status]"]['status'],
-		$bugsys->datastore['severity']["$bug[severity]"]['severity'],
-		$bug['comment_parsed']
-	));
-	$buglist["$bug[bugid]"] = $bug;
+	$syndicate .= '
+	<entry>
+		<id>' . $bugsys->options['trackertitle'] . '/showreport.php?bugid=' . $bug['bugid'] . '</id>
+		<title>' . $bug['summary'] . '</title>
+		<updated>' . gmdate('Y-m-d\TH:i:s\Z', $bug["$timestamp"]) . '</updated>
+		<author>
+			<name>' . $bug['username'] . '</name>
+		</author>
+		<content type="html">
+			' . htmlspecialchars('<table cellspacing="0" cellpadding="3" border="0">
+			<tr>
+				<td><strong>' . _('Bug ID') . ':</strong></td>
+				<td>' . $bug['bugid'] . '</td>
+			</tr>
+			<tr>
+				<td><strong>' . _('Summary') . ':</strong></td>
+				<td>' . $bug['summary'] . '</td>
+			</tr>
+			<tr>
+				<td><strong>' . _('Product/Component/Version') . ':</strong></td>
+				<td>' . $bugsys->datastore['product']["$bug[product]"]['title'] . '/' . (($bug['component']) ? $bugsys->datastore['product']["$bug[component]"]['title'] . '/' : '') . $bugsys->datastore['version']["$bug[version]"]['version'] . '</td>
+			</tr>
+			<tr>
+				<td><strong>' . _('Status') . ':</strong></td>
+				<td>' . $bugsys->datastore['status']["$bug[status]"]['status'] . '</td>
+			</tr>
+			<tr>
+				<td><strong>' . _('Severity') . ':</strong></td>
+				<td>' . $bugsys->datastore['severity']["$bug[severity]"]['severity'] . '</td>
+			</table>
+			
+			<p>' . $bug['comment_parsed'] . '</p>') . '
+		</content>
+		<summary type="text">' . htmlspecialchars($bug['comment_parsed']) . '</summary>
+		<link rel="alternate" href="' . $bugsys->options['trackerurl'] . '/showreport.php?bugid=' . $bug['bugid'] . '"/>
+	</entry>';
+	
 	$lastupdated = $bug["$timestamp"];
 }
 
-// ###################################################################
-// generate the actual feed
-
-header('Content-type: application/xml');
-
 echo '<?xml version="1.0" encoding="utf-8"?>
 <feed xmlns="http://www.w3.org/2005/Atom">
 
@@ -95,22 +97,8 @@ echo '<?xml version="1.0" encoding="utf-8"?>
 	
 	<!-- entries -->
 	';
-	
-foreach ($buglist AS $bug)
-{
-	echo '
-	<entry>
-		<id>' . $bugsys->options['trackertitle'] . '/showreport.php?bugid=' . $bug['bugid'] . '</id>
-		<title>' . $bug['summary'] . '</title>
-		<updated>' . gmdate('Y-m-d\TH:i:s\Z', $bug["$timestamp"]) . '</updated>
-		<author>
-			<name>' . $bug['username'] . '</name>
-		</author>
-		<content type="html">' . $bug['storytext'] . '</content>
-		<summary type="text">' . htmlspecialchars($bug['comment_parsed']) . '</summary>
-		<link rel="alternate" href="' . $bugsys->options['trackerurl'] . '/showreport.php?bugid=' . $bug['bugid'] . '"/>
-	</entry>';
-}
+
+echo $syndicate;
 	
 echo '
 	<!-- / entries -->
-- 
2.22.5