From c9a4b4b1139b37173303917868a2042512a62683 Mon Sep 17 00:00:00 2001
From: Robert Sesek <rsesek@bluestatic.org>
Date: Wed, 26 Jul 2006 00:13:31 +0000
Subject: [PATCH] r955: Make the favourite checkbox a <select> so that it's
 meaning is clear

---
 search.php           | 4 ++--
 templates/search.tpl | 8 +++++++-
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/search.php b/search.php
index 3efa3e9..a5d87cc 100644
--- a/search.php
+++ b/search.php
@@ -177,14 +177,14 @@ if ($_REQUEST['do'] == 'process')
 	
 	// -------------------------------------------------------------------
 	// favourites
-	if ($bugsys->in['favourite'] AND $bugsys->userinfo['userid'])
+	if (($bugsys->in['favourite'] == 1 OR $bugsys->in['favourite'] == 0) AND $bugsys->userinfo['userid'])
 	{
 		$favourites = $db->query("SELECT * FROM " . TABLE_PREFIX . "favourite WHERE userid = " . $bugsys->userinfo['userid']);
 		while ($favourite = $db->fetch_array($favourites))
 		{
 			$ids[] = $favourite['bugid'];
 		}
-		$querybuild['favourites'] = "AND bug.bugid IN (" . implode(', ', $ids) . ")";
+		$querybuild['favourites'] = "AND bug.bugid " . ($bugsys->in['favourite'] == 0 ? "NOT IN" : "IN") . " (" . implode(', ', $ids) . ")";
 	}
 	
 	// -------------------------------------------------------------------
diff --git a/templates/search.tpl b/templates/search.tpl
index 491b75f..295148c 100644
--- a/templates/search.tpl
+++ b/templates/search.tpl
@@ -144,7 +144,13 @@ $header
 		<!-- favourite -->
 		<fieldset>
 			<legend>{@"Favourite"}</legend>
-			<div class="field"><input type="checkbox" name="favourite" value="1" /> {@"Yes, search for favourites only"}</div>
+			<div class="field">
+				<select name="favourite">
+					<option value="-1">{@"Ignore favourite status"}</option>
+					<option value="1">{@"Yes, search for favourites only"}</option>
+					<option value="0">{@"No, exclude all favourites"}</option>
+				</select>
+			</div>
 		</fieldset>
 		<!-- / favourite -->
 		</if>
-- 
2.22.5