isso.git
10 years agoUpdate version.php to 3.3.0 master 3.3.0
Robert Sesek [Fri, 1 May 2009 21:06:23 +0000 (17:06 -0400)]
Update version.php to 3.3.0

* version.php

10 years agoBSFunctions::swap_css_classes() now returns the value rather than storing it in a...
Robert Sesek [Fri, 1 May 2009 21:05:23 +0000 (17:05 -0400)]
BSFunctions::swap_css_classes() now returns the value rather than storing it in a static member variable

* Functions.php:
(BSFunctions::swap_css_classes)
* UnitTest/FunctionsTest.php:
(FunctionsTest::testSwapCssClasses)

10 years agoFix an issue with the ApiTest for renaming BSApi::remove() to ::delete()
Robert Sesek [Fri, 1 May 2009 21:00:37 +0000 (17:00 -0400)]
Fix an issue with the ApiTest for renaming BSApi::remove() to ::delete()

* UnitTest/ApiTest.php:
(ApiTest::testRemove)

10 years agoBSFunctions::cookie() no longer depends on static member values for the domain, timeo...
Robert Sesek [Fri, 1 May 2009 20:55:16 +0000 (16:55 -0400)]
BSFunctions::cookie() no longer depends on static member values for the domain, timeout, and path

* Functions.php:
(BSFunctions::cookie): Use paramters instead

10 years agoAdd font styling to form input elements and create a .button class for styling links... 3.2.3
Robert Sesek [Fri, 20 Mar 2009 04:16:22 +0000 (00:16 -0400)]
Add font styling to form input elements and create a .button class for styling links as buttons

* Decorator.css.php

10 years agoCreate a toString method for BSTemplate that will evaluate it 3.2.2
Robert Sesek [Thu, 15 Jan 2009 16:08:54 +0000 (11:08 -0500)]
Create a toString method for BSTemplate that will evaluate it

* Template.php:
(BSTemplate::__toString): Implemented to call evaluate()->getTemplate()
* version.php: Bumping the version number

10 years agoUpdate version.php to 3.2.1 3.2.1
Robert Sesek [Thu, 8 Jan 2009 18:41:46 +0000 (10:41 -0800)]
Update version.php to 3.2.1

* version.php

10 years agoUpdate changelog for BSDecorator changes
Robert Sesek [Thu, 8 Jan 2009 18:41:19 +0000 (10:41 -0800)]
Update changelog for BSDecorator changes

10 years agoMinor fixes for Decorator.css.php based on real-world use:
Robert Sesek [Thu, 8 Jan 2009 18:38:24 +0000 (10:38 -0800)]
Minor fixes for Decorator.css.php based on real-world use:

- dfn no longer needs to be a child element to be styled
- Added more padding to dd and make it float left instead of right
- Added new .submit row
- Made .headings:td pseduo-classes in reverse order for cascading purposes

10 years agoBSTemplate now uses the entire file path when caching templates in the database
Robert Sesek [Tue, 6 Jan 2009 07:31:04 +0000 (23:31 -0800)]
BSTemplate now uses the entire file path when caching templates in the database

* Template.php

10 years agoDo not insert the debug block automatically anymore. Created BSTemplate::get_debug_bl...
Robert Sesek [Tue, 6 Jan 2009 06:55:11 +0000 (22:55 -0800)]
Do not insert the debug block automatically anymore. Created BSTemplate::get_debug_block() to get it instead.

* Template.php:
(BSTemplate::flush): Do not insert the debug block before </body> anymore
(BSTemplate::get_debug_block): New method to get the debug block info

10 years agoAdd BSFunctions::bool_to_string()
Robert Sesek [Tue, 6 Jan 2009 06:44:53 +0000 (22:44 -0800)]
Add BSFunctions::bool_to_string()

* Functions.php:
(BSFunctions::bool_to_string): New function

10 years agoChanging the version number to 3.2.0 3.2.0
Robert Sesek [Tue, 6 Jan 2009 01:57:36 +0000 (17:57 -0800)]
Changing the version number to 3.2.0

* version.php

10 years agoThere's no reason to make BSFunctions use a singleton. Switching it to be a purely...
Robert Sesek [Mon, 5 Jan 2009 03:33:13 +0000 (19:33 -0800)]
There's no reason to make BSFunctions use a singleton. Switching it to be a purely-static class.

* Functions.php: Made all the ivars static
(BSFunctions::_instance): Removed
(BSFunctions::set_cookie_path): Use new static ivar
(BSFunctions::set_cookie_domain): ditto
(BSFunctions::set_cookie_timeout): ditto
(BSFunctions::cookie): ditto

10 years agoRemove an unnecessary if/else and replace it with a single return statement
Robert Sesek [Mon, 5 Jan 2009 03:27:20 +0000 (19:27 -0800)]
Remove an unnecessary if/else and replace it with a single return statement

* Functions.php:
(BSFunctions::is_valid_email)

10 years agoRemoving the images/ folder that went along with BSPrinter
Robert Sesek [Mon, 5 Jan 2009 03:20:30 +0000 (19:20 -0800)]
Removing the images/ folder that went along with BSPrinter

* images/: Removed

10 years agoRemoving the BSPrinter module
Robert Sesek [Mon, 5 Jan 2009 03:19:48 +0000 (19:19 -0800)]
Removing the BSPrinter module

* Printer.php: Removed
* PrinterAbstract.php: Removed
* PrinterElement.php: Removed
* PrinterElementLabel.php: Removed
* PrinterElementTable.php: Removed
* PrinterNavigation.php: Removed
* PrinterRootAbstract.php: Removed
* PrinterRootForm.php: Removed
* PrinterRootPage.php: Removed
* PrinterRootTable.php: Removed
* docs/printertest.php: Removed
* printer.css.php: Removed

10 years agoAdd some files for posterity
Robert Sesek [Mon, 5 Jan 2009 03:17:52 +0000 (19:17 -0800)]
Add some files for posterity

* docs/BSDbAbstracter.php
* docs/printertest.php

10 years agoAdd 3.2.0 changelog entry
Robert Sesek [Mon, 5 Jan 2009 03:13:26 +0000 (19:13 -0800)]
Add 3.2.0 changelog entry

10 years agoHappy new year!
Robert Sesek [Mon, 5 Jan 2009 02:07:24 +0000 (18:07 -0800)]
Happy new year!

10 years agoFix scrolling and margins in the #body div
Robert Sesek [Sun, 4 Jan 2009 22:10:05 +0000 (14:10 -0800)]
Fix scrolling and margins in the #body div

* Decorator.css.php

10 years agoDocument some CSS
Robert Sesek [Sun, 4 Jan 2009 04:51:17 +0000 (20:51 -0800)]
Document some CSS

* Decorator.css.php

10 years agoAdd Decorator.js to do the nav javascript stuff
Robert Sesek [Sun, 4 Jan 2009 04:48:54 +0000 (20:48 -0800)]
Add Decorator.js to do the nav javascript stuff

* Decorator.css.php
* Decorator.js
* docs/decoratortest.html

10 years agoAdd input element styling
Robert Sesek [Sun, 4 Jan 2009 04:01:17 +0000 (20:01 -0800)]
Add input element styling

* Decorator.css.php

10 years agoNeed to add the navigation background images
Robert Sesek [Sun, 4 Jan 2009 01:39:04 +0000 (17:39 -0800)]
Need to add the navigation background images

* DecoratorResources/nav-section.jpg: New file
* DecoratorResources/nav-section-open.jpg: New file

10 years agoAdd a text input field to the decorator test file
Robert Sesek [Thu, 1 Jan 2009 03:06:07 +0000 (19:06 -0800)]
Add a text input field to the decorator test file

* docs/decoratortest.html

10 years agoAdd a footer CSS id
Robert Sesek [Thu, 1 Jan 2009 01:01:07 +0000 (17:01 -0800)]
Add a footer CSS id

* Decorator.css.php
* docs/decoratortest.html

10 years agoNested lists need to be in <li>s themselves. Also add link styling to the navbar.
Robert Sesek [Wed, 31 Dec 2008 22:24:22 +0000 (14:24 -0800)]
Nested lists need to be in <li>s themselves. Also add link styling to the navbar.

* Decorator.css.php
* docs/decoratortest.html

10 years agoFix a width issue on the dd elements
Robert Sesek [Wed, 31 Dec 2008 22:02:43 +0000 (14:02 -0800)]
Fix a width issue on the dd elements

* Decorator.css.php

10 years agoAdd styling to the navigation bar
Robert Sesek [Wed, 31 Dec 2008 22:01:22 +0000 (14:01 -0800)]
Add styling to the navigation bar

* Decorator.css.php
* docs/decoratortest.html

10 years agoAdd the navigation frame layouts
Robert Sesek [Wed, 31 Dec 2008 20:44:19 +0000 (12:44 -0800)]
Add the navigation frame layouts

* Decorator.css.php
* docs/decoratortest.html

10 years agoAdd the background image to #title
Robert Sesek [Wed, 31 Dec 2008 20:19:18 +0000 (12:19 -0800)]
Add the background image to #title

* Decorator.css.php
* DecoratorResources/title.jpg: New file

10 years agoChange the styling of the <legend> elements a little
Robert Sesek [Wed, 31 Dec 2008 20:05:15 +0000 (12:05 -0800)]
Change the styling of the <legend> elements a little

* Decorator.css.php

10 years agoWork on form element lists
Robert Sesek [Wed, 31 Dec 2008 20:04:31 +0000 (12:04 -0800)]
Work on form element lists

* Decorator.css.php
* docs/decoratortest.html

10 years agoCollapse table borders
Robert Sesek [Wed, 31 Dec 2008 18:14:49 +0000 (10:14 -0800)]
Collapse table borders

* Decorator.css.php

10 years agoAdd the initial decorator stuff
Robert Sesek [Wed, 31 Dec 2008 09:42:26 +0000 (01:42 -0800)]
Add the initial decorator stuff

* Decorator.css.php: New file
* docs/decoratortest.html

10 years agoAdd BSApi::fetchValue() and BSApi::reset() methods
Robert Sesek [Fri, 7 Nov 2008 17:16:59 +0000 (12:16 -0500)]
Add BSApi::fetchValue() and BSApi::reset() methods

* Api.php:
(BSApi::fetchValue): New method to return the value of a field from either the record[] or values[] array
(BSApi::reset): New method to reset the API object to only have the REQ_AUTO field set

10 years agoBSPrinterRootForm's marked as ::setUpload() would not have the right enctype set
Robert Sesek [Thu, 23 Oct 2008 14:01:24 +0000 (10:01 -0400)]
BSPrinterRootForm's marked as ::setUpload() would not have the right enctype set

* PrinterRootForm.php:
(BSPrinterRootForm::paint): Use the proper enctype

10 years agoUpdate version number 3.1.2
Robert Sesek [Wed, 17 Sep 2008 14:25:04 +0000 (10:25 -0400)]
Update version number

* version.php

10 years agoChange BSApi::remove() to BSApi::delete()
Robert Sesek [Sat, 6 Sep 2008 18:24:04 +0000 (14:24 -0400)]
Change BSApi::remove() to BSApi::delete()

* Api.php:
(BSApi::remove): Renamed to delete()

10 years agoAdd convert_txt tool to convert a text file into a HTML document
Robert Sesek [Wed, 20 Aug 2008 01:57:11 +0000 (21:57 -0400)]
Add convert_txt tool to convert a text file into a HTML document

* docs/tools/convert_txt.php: New file

10 years agoFix create_schema.php to work with the current version of ISSO and BSDb
Robert Sesek [Wed, 9 Jul 2008 15:30:01 +0000 (11:30 -0400)]
Fix create_schema.php to work with the current version of ISSO and BSDb

* docs/tools/create_schema.php

10 years agoUse a regex to match queries that need Result objects, because it's more than just...
Robert Sesek [Wed, 9 Jul 2008 15:29:20 +0000 (11:29 -0400)]
Use a regex to match queries that need Result objects, because it's more than just SELECT

* Db.php:
(BSDb::query): SELECT, DESCRIBE, and EXPLAIN queries all need a Result object

10 years agoFixing an undefined variable notice and improving the debug output 3.1.1
Robert Sesek [Mon, 7 Jul 2008 20:08:15 +0000 (16:08 -0400)]
Fixing an undefined variable notice and improving the debug output

* Mail.php:
(BSMail::send): Change the $sendHtml param to $sendhtml and mark the BSApp::debug messages with the class name

10 years agoVersion 3.1.1
Robert Sesek [Mon, 7 Jul 2008 14:15:14 +0000 (10:15 -0400)]
Version 3.1.1

10 years agoUpdate the API documentation
Robert Sesek [Mon, 7 Jul 2008 13:43:44 +0000 (09:43 -0400)]
Update the API documentation

* PrinterAbstract.php
(BSPrinterAbstract::setId): Document the return type
(BSPrinterAbstract::_prepareStyle): Update docs

10 years agoFixing a call to undefined function error for BSFunctions::Rand() in BSMail::send()
Robert Sesek [Sun, 6 Jul 2008 12:52:21 +0000 (08:52 -0400)]
Fixing a call to undefined function error for BSFunctions::Rand() in BSMail::send()

* Mail.php:
(BSMail::send): Require Functions.php and then call ::random() instead of ::Rand()

10 years agoSetting the verison to be 3.1.0 3.1.0
Robert Sesek [Sun, 6 Jul 2008 12:39:27 +0000 (08:39 -0400)]
Setting the verison to be 3.1.0

* version.php

10 years agoWe need to require() Functions.php in BSPrinterRootPage::paint() for the ISSO_MT_STAR...
Robert Sesek [Sun, 6 Jul 2008 12:28:17 +0000 (08:28 -0400)]
We need to require() Functions.php in BSPrinterRootPage::paint() for the ISSO_MT_START timer

* PrinterRootPage.php
(BSPrinterRootPage::paint)

10 years agoAdding a global exception handler BSExceptionHandler
Robert Sesek [Wed, 2 Jul 2008 02:13:25 +0000 (22:13 -0400)]
Adding a global exception handler BSExceptionHandler

* ExceptionHandler.php: New file
* App.php: set_exception_handler() to use BSExceptionHandler

10 years agoApiException will now string all of its exceptions together to form the message
Robert Sesek [Tue, 1 Jul 2008 21:50:15 +0000 (17:50 -0400)]
ApiException will now string all of its exceptions together to form the message

* Api.php:
(ApiException::__construct): Add a prefix for the list of errors to be displayed
(ApiException::addException): Append the exception's message to ApiException->message

10 years agoBetter handle parse errors in nested templates
Robert Sesek [Thu, 26 Jun 2008 16:10:50 +0000 (12:10 -0400)]
Better handle parse errors in nested templates

* Template.php:
(BSTemplate::evaluate): Don't call ob_end_clean()

10 years agoAdd BSTemplate::$globalVars that every template will substitute through
Robert Sesek [Thu, 26 Jun 2008 14:37:44 +0000 (10:37 -0400)]
Add BSTemplate::$globalVars that every template will substitute through

* Template.php:
(BSTemplate::evaluate)

10 years agoPass the BSTemplate object to the ISSO hook
Robert Sesek [Thu, 26 Jun 2008 14:15:44 +0000 (10:15 -0400)]
Pass the BSTemplate object to the ISSO hook

* Template.php:
(BSTemplate::_parseTemplate)

10 years agoMake Pagination->page and Pagination->perpage be public and not protected
Robert Sesek [Wed, 25 Jun 2008 18:51:46 +0000 (14:51 -0400)]
Make Pagination->page and Pagination->perpage be public and not protected

* Pagination.php

10 years agoAdd a test for the new Iterarator implementation in BSDBResult
Robert Sesek [Wed, 25 Jun 2008 14:25:50 +0000 (10:25 -0400)]
Add a test for the new Iterarator implementation in BSDBResult

* UnitTest/DatabaseTestAbstract.php
(DatabaseTestAbstract::testIterator): New method

10 years agoImplement Iterator in BSDbResult
Robert Sesek [Wed, 25 Jun 2008 14:14:33 +0000 (10:14 -0400)]
Implement Iterator in BSDbResult

* Db.php: Add $iterator ivar
(BSDBResult::rewind): New method
(BSDBResult::current): New method
(BSDBResult::key): New method
(BSDBResult::next): New method
(BSDBResult::valid): New method

11 years agoIn the template manager, add an option to echo in the opening tag
Robert Sesek [Mon, 14 Apr 2008 18:09:39 +0000 (14:09 -0400)]
In the template manager, add an option to echo in the opening tag

* Template.php:
(BSTemplate::_parseTokens): If the tag is <%- convert it to <?php echo

11 years agoAdd a __toString() method on BSPrinterAbstract
Robert Sesek [Tue, 8 Apr 2008 17:40:34 +0000 (13:40 -0400)]
Add a __toString() method on BSPrinterAbstract

* PrinterAbstract.php:
(BSPrinterAbstract::__toString): New method that calls paint()

11 years agoMaking BSTemplate follow OOP instead of just being a metaclass/object. Updating the...
Robert Sesek [Mon, 7 Apr 2008 18:32:08 +0000 (14:32 -0400)]
Making BSTemplate follow OOP instead of just being a metaclass/object. Updating the unit tests to reflect this, too.

11 years agoMake makepo.sh.php work with ISSO 3.0
Robert Sesek [Thu, 3 Apr 2008 16:42:03 +0000 (12:42 -0400)]
Make makepo.sh.php work with ISSO 3.0

* docs/makepo.sh.php

11 years agoMaking a lot of previously-private methods and ivars public or protected
Robert Sesek [Thu, 3 Apr 2008 16:37:30 +0000 (12:37 -0400)]
Making a lot of previously-private methods and ivars public or protected

11 years agoMerge ../butv10/core/framework
Robert Sesek [Thu, 27 Mar 2008 04:32:33 +0000 (00:32 -0400)]
Merge ../butv10/core/framework

Conflicts:

CHANGES

11 years agoAdd a way to quick-set API fields via an array
Robert Sesek [Wed, 26 Mar 2008 18:14:08 +0000 (14:14 -0400)]
Add a way to quick-set API fields via an array

* Api.php:
(BSApi::setArray): New method to set API fields via an array

11 years agoAdd the ability to set the id attribute of all Printer elements
Robert Sesek [Wed, 26 Mar 2008 18:11:25 +0000 (14:11 -0400)]
Add the ability to set the id attribute of all Printer elements

* PrinterAbstract.php: New id ivar
(BSPrinterAbstract::setId): New method
(BSPrinterAbstract::_prepareStyle): Add the id attribute if it's present

11 years agoAdd a method for injecting code into the <head> element of the page
Robert Sesek [Tue, 18 Mar 2008 01:56:26 +0000 (21:56 -0400)]
Add a method for injecting code into the <head> element of the page

* PrinterRootPage.php: Add a headerCode ivar
(BSPrinterRootPage::setHeaderCode): New method
(BSPrinterRootPage::paint): Paint the header code

11 years agoRemove the text-indent from .input
Robert Sesek [Wed, 12 Mar 2008 15:21:06 +0000 (11:21 -0400)]
Remove the text-indent from .input

* printer.css.php
* CHANGES

11 years agoRemove the text-indent from .input
Robert Sesek [Wed, 12 Mar 2008 15:13:36 +0000 (11:13 -0400)]
Remove the text-indent from .input

* printer.css.php

11 years agoIn BSPrinterElementTable::__construct(), we can now on-the-fly create Label elements...
Robert Sesek [Tue, 11 Mar 2008 19:16:51 +0000 (15:16 -0400)]
In BSPrinterElementTable::__construct(), we can now on-the-fly create Label elements from just strings to save us some code

* CHANGES
* PrinterElementTable.php:
(BSPrinterElementTable::__construct): If the child is not an instance of BSPrinterAbstract, make it into a Label

11 years agoUpdate the comment formatting to not use the pound bar anymore and to put a space... 3.0.0
Robert Sesek [Thu, 28 Feb 2008 20:49:05 +0000 (15:49 -0500)]
Update the comment formatting to not use the pound bar anymore and to put a space in front of the PHPdoc comments

11 years agoMaking BSPagination an abstract class that people extend instead of using callback...
Robert Sesek [Thu, 28 Feb 2008 20:11:45 +0000 (15:11 -0500)]
Making BSPagination an abstract class that people extend instead of using callback functions

* Pagination.php

11 years agoRemoved a globalization of $bugsys (wow, talk about directly ripping from Bugdar)
Robert Sesek [Mon, 28 Jan 2008 05:26:22 +0000 (00:26 -0500)]
Removed a globalization of $bugsys (wow, talk about directly ripping from Bugdar)

* Pagination.php
(BSPagination::constructPageNav): Do not globalize a gvar we don't need

11 years agoAdd fluent interfaces for set() functions in BSPrinterelement
Robert Sesek [Fri, 25 Jan 2008 17:25:21 +0000 (12:25 -0500)]
Add fluent interfaces for set() functions in BSPrinterelement

* PrinterElement.php
(BSPrinterElement::setActive): Return $this
(BSPrinterElement::setOnClick): ditto
(BSPrinterElement::setAccessKey): ditto
(BSPrinterElement::setName): ditto

11 years agoFixing some references to controller/action that we used back when we were going...
Robert Sesek [Fri, 25 Jan 2008 17:21:19 +0000 (12:21 -0500)]
Fixing some references to controller/action that we used back when we were going to have a controller module

* PrinterRootForm.php: Renamed BSPrinterRootForm->controller to be ->action and BSPrinterRootForm->action to be ->do
(BSPrinterRootForm::__construct): Changes to ivar assignment
(BSPrinterRootForm::paint): Changes for ivar names
* PrinterRootPage.php: ditto
(BSPrinterRootPage::redirect): Take a location instead of a controller/action pair; additionally, make changes for postvars
(BSPrinterRootPage::confirm): Rename parameters to match BSPrinterRootForm ivars

11 years agoFixing a documentation and error mistake that weren't fixed through our sesarch/repla...
Robert Sesek [Thu, 24 Jan 2008 22:08:19 +0000 (17:08 -0500)]
Fixing a documentation and error mistake that weren't fixed through our sesarch/replace of renaming Printer classes

11 years agoFixing a bad function call to BSFunctions::SwapCssClasses()
Robert Sesek [Thu, 24 Jan 2008 21:56:28 +0000 (16:56 -0500)]
Fixing a bad function call to BSFunctions::SwapCssClasses()

* PrinterAbstract.php
(BSPrinterAbstract::_prepareStyle): Change the call to swap_css_classes()

11 years agoRenaming all the classes for the Printer to match the name of the file
Robert Sesek [Thu, 24 Jan 2008 21:55:33 +0000 (16:55 -0500)]
Renaming all the classes for the Printer to match the name of the file

11 years agoFinished that file name swap.
Robert Sesek [Thu, 24 Jan 2008 21:21:44 +0000 (16:21 -0500)]
Finished that file name swap.

11 years agoThese two files need to be swapped
Robert Sesek [Thu, 24 Jan 2008 21:21:21 +0000 (16:21 -0500)]
These two files need to be swapped

11 years agoRenaming the Printer files to make their names much less verbose. Part 1 of 2.
Robert Sesek [Thu, 24 Jan 2008 21:20:14 +0000 (16:20 -0500)]
Renaming the Printer files to make their names much less verbose. Part 1 of 2.

11 years agoAdd a rule about how to advance the ISSO version number and a version constant file
Robert Sesek [Thu, 24 Jan 2008 17:39:54 +0000 (12:39 -0500)]
Add a rule about how to advance the ISSO version number and a version constant file

* docs/versioning_rules.txt: Outlines the procedures for updating the version number
* version.php: The version number stored in a file

11 years agoDo not allow random() to take an array of high or low, just an optional fixed length...
Robert Sesek [Thu, 24 Jan 2008 16:24:51 +0000 (11:24 -0500)]
Do not allow random() to take an array of high or low, just an optional fixed length (otherwise it will randomly select one)

* Functions.php:
(BSFunctions::random): Do not accept an Array as a parameter, just an optional int
* UnitTest/FunctionsTest.php:
(FunctionsTest::testRandom): Test using a fixed length as well as the random length

11 years agoRemoving the is_browser() function
Robert Sesek [Wed, 23 Jan 2008 22:15:47 +0000 (17:15 -0500)]
Removing the is_browser() function

* Functions.php:
(BSFunctions::is_browser): Removed
(BSFunctions::download_file): Send both application/octet-stream and application/octetstream so we don't need to browser sniff anymore
* UnitTest/FunctionsTest.php: Removed the empty unit test for is_browser()

11 years agoChanging our coding standards slightly:
Robert Sesek [Wed, 23 Jan 2008 21:06:33 +0000 (16:06 -0500)]
Changing our coding standards slightly:

- foreach($a AS $b) goes to foreach($a as $b)
- ($a AND $b) goes to ($a && $b)
- ($a OR $b) goes to ($a || $b)

11 years agoWe no longer need the ISSO_CHECK_POST_REFERER because we made BSInput::_checkPostRefe...
Robert Sesek [Wed, 23 Jan 2008 20:45:57 +0000 (15:45 -0500)]
We no longer need the ISSO_CHECK_POST_REFERER because we made BSInput::_checkPostReferer() public

* Input.php:
(BSInput::__construct): Remove the code that called _checkPostReferer()
(BSInput::checkPostReferer): Removed the _ from the old name and made it public

11 years agoAdd sanity checks to BSPrinterNavigation when setting focus or sections
Robert Sesek [Mon, 14 Jan 2008 22:04:29 +0000 (17:04 -0500)]
Add sanity checks to BSPrinterNavigation when setting focus or sections

* PrinterNavigation.php
(BSPrinterNavigation::addFocus): Make sure the key is unique and exists before accepting it
(BSPrinterNavigation::addSection): ditto

11 years agoWe were testing for a condition that always works but used a non-existant var
Robert Sesek [Mon, 14 Jan 2008 21:48:03 +0000 (16:48 -0500)]
We were testing for a condition that always works but used a non-existant var

* printer.css.php

11 years agoFixing another bug in BSPrinterRootElementPage in paint() that was still making refer...
Robert Sesek [Mon, 14 Jan 2008 21:12:10 +0000 (16:12 -0500)]
Fixing another bug in BSPrinterRootElementPage in paint() that was still making references to GetType()

* PrinterRootElementPage.php
(BSPrinterRootElementPage::paint): We no longer use GetType() but instead cvars in BSApp

11 years agoFixing a bug in BSPrinterRootElementPage that would cause an error whenever we tried...
Robert Sesek [Mon, 14 Jan 2008 21:08:43 +0000 (16:08 -0500)]
Fixing a bug in BSPrinterRootElementPage that would cause an error whenever we tried to paint children

* PrinterRootElementPage.php:
(BSPrinterRootElementPage::_paintChildren): We use the var builder not this->builder

11 years agoMinor adjustments to the BSPrinterNavigation system to support not having tabs or...
Robert Sesek [Mon, 14 Jan 2008 21:06:25 +0000 (16:06 -0500)]
Minor adjustments to the BSPrinterNavigation system to support not having tabs or toplinks

* PrinterNavigation.php

11 years agoUpdating the PrinterNavigation system to take an XML structure instead that is much...
Robert Sesek [Mon, 14 Jan 2008 21:01:38 +0000 (16:01 -0500)]
Updating the PrinterNavigation system to take an XML structure instead that is much more powerful than the scoped keys of the old version

11 years agoMaking BSPrinterRootElementPage::setNavigator() part of the fluent interface
Robert Sesek [Mon, 14 Jan 2008 20:09:45 +0000 (15:09 -0500)]
Making BSPrinterRootElementPage::setNavigator() part of the fluent interface

* PrinterRootElementPage.php
(BSPrinterRootElementPage::setNavigator): Return a fluent interface

11 years agoFixing some things in the Printer system
Robert Sesek [Mon, 14 Jan 2008 20:04:19 +0000 (15:04 -0500)]
Fixing some things in the Printer system

* Printer.php: include PrinterNavigation.php
* PrinterRootElementPage.php:
(BSPrinterRootElementPage::get/setNavigator): Renamed from get/setNavigation()
(BSPrinterRootElementPage::paint): Fix a parse error caused by a missing concat op

11 years agoInstead of using the registry to get the PrinterNavigation system, add methods to...
Robert Sesek [Mon, 14 Jan 2008 19:58:38 +0000 (14:58 -0500)]
Instead of using the registry to get the PrinterNavigation system, add methods to set BSPrinterRootElementPage->navigator

* PrinterRootElementPage.php:
(BSPrinterRootElementPage::setNavigator): New method
(BSPrinterRootElementPage::getNavigator): New method

11 years agoWe now pass the installer test again, the issue was that InstallerTest->input wasn...
Robert Sesek [Mon, 14 Jan 2008 19:41:00 +0000 (14:41 -0500)]
We now pass the installer test again, the issue was that InstallerTest->input wasn't being set. The circular ref to the rig in TestInstallerFixture was also cleaned up

* UnitTest/InstallerTest.php

11 years agoRemoving the PHP tests because we have now implemented our conclusions
Robert Sesek [Sun, 13 Jan 2008 22:35:43 +0000 (14:35 -0800)]
Removing the PHP tests because we have now implemented our conclusions

11 years agoAdding fixes in the unit tests for all the refactoring we did
Robert Sesek [Sun, 13 Jan 2008 22:11:46 +0000 (14:11 -0800)]
Adding fixes in the unit tests for all the refactoring we did

11 years agoRemoving the BSVariableRegistry and instead making public static vars in BSApp for...
Robert Sesek [Sun, 13 Jan 2008 21:37:31 +0000 (13:37 -0800)]
Removing the BSVariableRegistry and instead making public static vars in BSApp for the necessary inter-linking modules

* Api.php: No longer use BSApp::registry() but rather just the cvars
* App.php: Make the ivars cvars so we no longer need singleton stuff
(BSApp::_instance): Removed
(BSApp::registry): Removed
(BSApp::load_module): Removed, just directly instantiate now
(BSApp::required_modules): Removed
(BSVariableRegistry): Removed
* Input.php: Use cvars instead of the BSApp::registry()
* Installer.php: ditto
* Mail.php: ditto
* Pagination.php: ditto
* Template.php: ditto

11 years agoRemoving a lot of old system variables from BSApp
Robert Sesek [Sun, 13 Jan 2008 20:43:26 +0000 (12:43 -0800)]
Removing a lot of old system variables from BSApp

* App.php: Removed BSApp->application, BSApp->appPath, BSApp->appVersion, BSApp->webPath
(BSApp::set_application): Removed
(BSApp::get_application): Removed
(BSApp::set_app_path): Removed
(BSApp::get_app_path): Removed
(BSApp::set_app_version): Removed
(BSApp::get_app_version): Removed
(BSApp::set_web_path): Removed
(BSApp::get_web_path): Removed
* Printer.php: Add BSPrinter->copyright to store copyright information for the footer of pages
(BSPrinter::get_copyright): New method
(BSPrinter::set_copyright): New method
* PrinterNavigation.php: BSPrinter->realm is now the only component used for titles
(BSPrinterNavigation::constructHeaderHtml): Now uses only the realm
* PrinterRootElementPage.php: Again, only use BSPrinter->realm
(BSPrinterRootElementPage::paint): Switch to using only the realm in the title and using BSPrinter->copyright in the footer

11 years agoFixing a few functions that broke during the refactoring
Robert Sesek [Sun, 13 Jan 2008 18:46:16 +0000 (10:46 -0800)]
Fixing a few functions that broke during the refactoring

* Functions.php:
(BSFunctions::swap_css_classes): This function wasn't marked static so it wasn't refactored, fixed both of those issues
(BSFunctions::scan_directory): Issues arose with _help_scan_directory()
(BSFunctions::_help_scan_directory): ditto