macgdbp.git
15 years agoDon't include the final .0 in 1.2 1.2
Robert Sesek [Thu, 12 Feb 2009 15:07:30 +0000 (10:07 -0500)]
Don't include the final .0 in 1.2

* Info.plist

15 years agoConvert the run command to use the StackFrame system
Robert Sesek [Tue, 10 Feb 2009 17:40:47 +0000 (12:40 -0500)]
Convert the run command to use the StackFrame system

* Source/GDBpConnection.m+h:
(run): Now returns a StackFrame object
(processData:): Return nil if the given data is nil
(createStackFrame): If we get an empty NSXMLDocument for the stack, return nil
(updateStatus): If the status is nil, the debugger is stopped
* Source/DebuggerController.m:
(run): Use the stack frame
* Source/SocketWrapper.m:
(receive): If the call to recv() returns -1 (error), return nil string

15 years agoMerge branch 'path-replacement'
Robert Sesek [Mon, 9 Feb 2009 12:55:06 +0000 (07:55 -0500)]
Merge branch 'path-replacement'

Conflicts:
CHANGES
Source/AppDelegate.m

15 years agoThe breakpoints window will now remember if it was opened or closed
Robert Sesek [Fri, 6 Feb 2009 20:33:44 +0000 (15:33 -0500)]
The breakpoints window will now remember if it was opened or closed

* English.lproj/Breakpoints.xib: Bind the visible status to NSUserDefaults
* Source/AppDelegate.m:
(load): Add the default value for BreakpointsWindowVisible stdudef
* Source/BreakpointController.m:
(init): Only order the window back if BreakpointsWindowVisible is true

15 years agoBumping the version number to 1.2.0
Robert Sesek [Fri, 6 Feb 2009 20:16:28 +0000 (15:16 -0500)]
Bumping the version number to 1.2.0

* Info.plist

15 years agoAdd a changelog entry for the path replacements prefs
Robert Sesek [Fri, 6 Feb 2009 20:13:29 +0000 (15:13 -0500)]
Add a changelog entry for the path replacements prefs

15 years agoAdd a change to the changelog
Robert Sesek [Fri, 6 Feb 2009 20:12:31 +0000 (15:12 -0500)]
Add a change to the changelog

15 years agoWhen sending breakpoints to Xdebug, use the [transformedPath]
Robert Sesek [Fri, 6 Feb 2009 06:31:09 +0000 (01:31 -0500)]
When sending breakpoints to Xdebug, use the [transformedPath]

* Source/GDBpConnection.m:
(addBreakpoint:): Use [transformedPath] instead of [file]

15 years agoAdd the actual path replacement procedure and flip/rename the columns in the preferences
Robert Sesek [Fri, 6 Feb 2009 06:21:43 +0000 (01:21 -0500)]
Add the actual path replacement procedure and flip/rename the columns in the preferences

* English.lproj/Preferences.xib: Flip and rename the path columns
* Source/Breakpoint.m+h:
(transformedPath): New method

15 years agoAdd a custom NSArrayController for the paths preferences so we can customize the...
Robert Sesek [Fri, 6 Feb 2009 05:57:00 +0000 (00:57 -0500)]
Add a custom NSArrayController for the paths preferences so we can customize the default dictionary values

* English.lproj/Preferences.xib: Update the bindings
* Source/PreferencesPathsArrayController.h+m: New files
* MacGDBp.xcodeproj/project.pbxproj: Project updates for new files

15 years agoAdd the path management bindings and array controller
Robert Sesek [Fri, 6 Feb 2009 05:32:10 +0000 (00:32 -0500)]
Add the path management bindings and array controller

* English.lproj/Preferences.xib: Hook up the interface using bindings and NSUserDefaultsController
* Source/AppDelegate.m:
(load): Add a default for the PathReplacements user defaults

15 years agoDesign the paths replacement interface
Robert Sesek [Fri, 6 Feb 2009 01:35:30 +0000 (20:35 -0500)]
Design the paths replacement interface

* English.lproj/Preferences.xib: Design the paths panel
* Source/PreferencesController.m:
(showPreferencesWindow): Center the window before opening

15 years agoImplement preferences window resizing
Robert Sesek [Fri, 6 Feb 2009 01:26:05 +0000 (20:26 -0500)]
Implement preferences window resizing

* Source/PreferencesController.h: Add blankView ivar
* Source/PreferencesController.m: Create private interface for resizing
(init): Create the blankView
(dealloc): New method
(awakeFromNib): New method
(showGeneral:): Call the resize method
(showPaths:): ditto
(resizeWindowToSize:): New private method

15 years agoAdd the paths replacement panel but don't implement anything in it
Robert Sesek [Thu, 5 Feb 2009 20:44:24 +0000 (15:44 -0500)]
Add the paths replacement panel but don't implement anything in it

15 years agoImplement a toolbar for the preferences window
Robert Sesek [Thu, 5 Feb 2009 20:35:54 +0000 (15:35 -0500)]
Implement a toolbar for the preferences window

* Source/AppDelegate.m:
(showPreferences:): Don't call methods on the [prefs window] anymore, but [showPreferencesWindow]
* Source/PreferencesController.m+h: Add toolbar outlet ivars
(showPreferencesWindow): New method
(showGeneral:): New method
(toolbarSelectableItemIdentifiers:): New method

15 years agoAdding a CONTRIBUTORS file
Robert Sesek [Thu, 5 Feb 2009 18:57:33 +0000 (13:57 -0500)]
Adding a CONTRIBUTORS file

15 years agoWord wrap CHANGES
Robert Sesek [Thu, 5 Feb 2009 18:47:45 +0000 (13:47 -0500)]
Word wrap CHANGES

15 years agoShow the variables in all contexts instead of just Locals. Fixes #147.
Robert Sesek [Thu, 5 Feb 2009 18:43:12 +0000 (13:43 -0500)]
Show the variables in all contexts instead of just Locals. Fixes #147.

Patch partial from Nicola Ferruzzi.

* Source/StackFrame.m+h: Change "contexts" to "variables"
(initWithIndex:withFilename:withSource:atLine:inFunction:withContexts:): Renamed to be ...withVariables:
* Source/GDBpConnection.m:
(createStackFrame): Collect all the contexts into an array and send that to StackFrame
* English.lproj/Debugger.xib: Rebind to simply "variables"

15 years agoWhen the debugger connects, automatically step in to the first frame to make the...
Robert Sesek [Wed, 28 Jan 2009 17:16:50 +0000 (12:16 -0500)]
When the debugger connects, automatically step in to the first frame to make the debugger look active

* Source/DebuggerController.m+h:
(startDebugger): New method
* Source/GDBpConnection.m:
(socketDidAccept:): Call the -[startDebugger] method

15 years agoUpdating the changelog for 1.2.0
Robert Sesek [Wed, 28 Jan 2009 17:16:15 +0000 (12:16 -0500)]
Updating the changelog for 1.2.0

* CHANGES

15 years agoHappy new year! Bump copyright.
Robert Sesek [Thu, 22 Jan 2009 19:47:52 +0000 (14:47 -0500)]
Happy new year! Bump copyright.

15 years agoHighlighting of the currently debugged file will now get the source from Xdebug rathe...
Robert Sesek [Thu, 22 Jan 2009 19:04:17 +0000 (14:04 -0500)]
Highlighting of the currently debugged file will now get the source from Xdebug rather than reading local files

* Source/BSSourceView.m+h:
(setString:asFile:): New method that will highlight strings rather than files
(scrollToLine:): Change the sanity check to be based off of text in the textStorage, rather than if a file has been set
* Source/DebuggerController.m:
(updateSourceViewer): Use the new setString:asFile: instead of just setFile:

15 years agoMerge branch 'refactoring'
Robert Sesek [Thu, 22 Jan 2009 16:44:52 +0000 (11:44 -0500)]
Merge branch 'refactoring'

Conflicts:
English.lproj/Debugger.xib

15 years agoFixed a bug where stepIn would remove the current stack frame if the file was the...
Robert Sesek [Wed, 3 Dec 2008 07:13:11 +0000 (02:13 -0500)]
Fixed a bug where stepIn would remove the current stack frame if the file was the same but a function call was made

* Source/StackFrame.m:
(isShiftedFrame:): A frame is shifted if it is in the same file AND it is still in the same function

15 years agoRenaming registers to variables
Robert Sesek [Tue, 2 Dec 2008 16:10:52 +0000 (11:10 -0500)]
Renaming registers to variables

15 years agoWe need to keep variables expanded across changing stack positions
Robert Sesek [Mon, 1 Dec 2008 23:56:01 +0000 (18:56 -0500)]
We need to keep variables expanded across changing stack positions

* Source/DebuggerController.m:
(setRegister:): Removed
(tableViewSelectionDidChange:): Call [expandRegisters]
(expandVariables): New private method
* Source/DebuggerController.h: Header updates

15 years agoFix a couple display issues and a crash
Robert Sesek [Mon, 1 Dec 2008 21:58:42 +0000 (16:58 -0500)]
Fix a couple display issues and a crash

* Source/DebuggerController.m:
(resetDisplays): Clear all the items in the stackController.stack
(updateSourceViewer): If the selection is empty, do not try to clear it. Also, tell the textView to repaint.

15 years agoGet the source code from the debugger engine in [GDBpConnection(Private) createStackF...
Robert Sesek [Mon, 1 Dec 2008 17:50:11 +0000 (12:50 -0500)]
Get the source code from the debugger engine in [GDBpConnection(Private) createStackFrame]

* Source/GDBpConnection.m:
(createStackFrame): Use the source GDBp command to get the source code for the stack frame

15 years agoRemove -[DebuggerController setStatus:]
Robert Sesek [Mon, 1 Dec 2008 15:38:39 +0000 (10:38 -0500)]
Remove -[DebuggerController setStatus:]

* Source/DebuggerController.h: Header updates
* Source/DebuggerController.m:
(awakeFromNib): Set the window's title and remove the call to [setStatus:]
(setStatus:): Removed
(setError:): Remove call to [setStatus:]
* Source/GDBpConnection.m:
(initWithPort:session:): Set the status to "Connecting"

15 years agoUse automatic validation of UI items for the toolbar buttons, rather than manually...
Robert Sesek [Mon, 1 Dec 2008 15:33:16 +0000 (10:33 -0500)]
Use automatic validation of UI items for the toolbar buttons, rather than manually enabling/disabling them

* Source/DebuggerController.h: Remove the outlets for the toolbar items
* Source/DebuggerController.m:
(validateUserInterfaceItem:): Validate the reconnect button
(setStatus:): Remove the block of code that sets button states
(updateStackViewer): ditto
* English.lproj/Debugger.xib: Remove the outlets and set all the toolbar items to autovalidate

15 years agoCall -[resetDisplays] when we reconnect
Robert Sesek [Mon, 1 Dec 2008 15:27:16 +0000 (10:27 -0500)]
Call -[resetDisplays] when we reconnect

* Source/DebuggerController.m:
(reconnect:): Call resetDisplays

15 years agoUse bindings to set the register controller's contentArray
Robert Sesek [Mon, 1 Dec 2008 15:22:26 +0000 (10:22 -0500)]
Use bindings to set the register controller's contentArray

* English.lproj/Debugger.xib

15 years agoRemove all references of the window controller from GDBpConnection
Robert Sesek [Mon, 1 Dec 2008 15:17:12 +0000 (10:17 -0500)]
Remove all references of the window controller from GDBpConnection

* Source/GDBpConnection.h: Removed the windowController ivar and prop
* Source/GDBpConnection.m:
(initWithWindowController:port:session): Renamed to -[initWithPort:session:]
(dealloc): No more windowController
(socketDidAccept:): Change a -[refreshStatus] to an -[updateStatus]
(reconnect): Don't make a call on windowController
* Source/DebuggerController.m:
(init): Use the updated init method for GDBpConnection

15 years agoRemove the model-updating-controller register variable code
Robert Sesek [Mon, 1 Dec 2008 15:13:41 +0000 (10:13 -0500)]
Remove the model-updating-controller register variable code

* Source/GDBpConnection.m:
(refreshStatus): Removed
(run): Call -[updateStatus] and not -[refreshStatus]
(stepIn): ditto
(stepOut): ditto
(stepOver): ditto
(updateStackTraceAndRegisters): Removed
(createStackFrame): Fetch the contexts and variables
* Source/GDBpConnection.h: Header updates

15 years agoSet the file column to truncate head, not truncate tail
Robert Sesek [Mon, 1 Dec 2008 06:13:46 +0000 (01:13 -0500)]
Set the file column to truncate head, not truncate tail

* English.lproj/Debugger.xib

15 years agoOne more instance of calling -[setStatus:] that needs to change
Robert Sesek [Mon, 1 Dec 2008 04:11:05 +0000 (23:11 -0500)]
One more instance of calling -[setStatus:] that needs to change

* Source/GDBpConnection.m:
(reconnect): Change the ivar rather than calling setStatus

15 years agoRather than having GDBpConnection tell the window controller to change status, cache...
Robert Sesek [Mon, 1 Dec 2008 04:06:34 +0000 (23:06 -0500)]
Rather than having GDBpConnection tell the window controller to change status, cache the status as an ivar and bind to it

* Source/GDBpConnection.h: Define the status ivar and make it a prop
* Source/GDBpConnection.m:
(refreshStatus): Remove most of the status-updating code
(updateStatus): New method to fetch and set the status ivar
* English.lproj/Debugger.xib: Bind the status text to GDBpConnection's new status ivar

15 years agoUse our new error system
Robert Sesek [Mon, 1 Dec 2008 03:49:17 +0000 (22:49 -0500)]
Use our new error system

* Source/GDBpConnection.m:
(processData:): Call -[errorEncountered]

15 years agoCreate an error system that follows MVC
Robert Sesek [Mon, 1 Dec 2008 03:40:18 +0000 (22:40 -0500)]
Create an error system that follows MVC

* Source/DebuggerController.m:
(init): Register ourselves as an observer for the error notif type
(handleConnectionError:): New method to handle the error notifs
* Source/GDBpConnection.h: Forward-declare kErrorOccurred
* Source/GDBpConnection.m:
(errorEncountered:): Post the notification

15 years agoRemove all of the old stack system
Robert Sesek [Mon, 1 Dec 2008 03:18:37 +0000 (22:18 -0500)]
Remove all of the old stack system

* Source/DebuggerController.h: Remove stackController2 and stack ivars
* Source/DebuggerController.m:
(validateUserInterfaceItem:): Update to use stackController.stack for -[count]
(resetDisplays): Remove the call to stackController2
(setStack): Removed
(stepIn:): Call -[updateStackViewer]
(stepOut:): ditto
(stepOver:): ditto
(updateSourceViewer): Use our new stackController
(updateStackViewer): New method
* Source/GDBpConnection.m:
(updateStackTraceAndRegisters): Remove the block of code that used to update the stack

15 years agoUpdate the bindings for the stack viewer to use our new StackController system
Robert Sesek [Mon, 1 Dec 2008 02:57:23 +0000 (21:57 -0500)]
Update the bindings for the stack viewer to use our new StackController system

* English.lproj/Debugger.xib: Redo the bindings
* Source/DebuggerController.h: Add stackArrayController ivar
* Source/DebuggerController.m:
(awakeFromNib): Set the sort descriptors
(stepIn:): Rearrange the stackArrayController
(stepOut:): ditto
(stepOver): ditto

15 years agoThe StackFrame index will always be 0 in -[GDBpConnection createStackFrame], so we...
Robert Sesek [Mon, 1 Dec 2008 01:34:01 +0000 (20:34 -0500)]
The StackFrame index will always be 0 in -[GDBpConnection createStackFrame], so we need to advance it in -[StackController pop] and -[push:]

* Source/GDBpConnection.m:
(createStackFrame): Don't bother getting the "level" property, it will always be 0
* Source/StackController.m:
(pop): Decrease all of the frames' counter
(push:): Increase all of the frames' counter

15 years agoWe need to pop the stack twice when stepOut is called
Robert Sesek [Mon, 1 Dec 2008 01:27:18 +0000 (20:27 -0500)]
We need to pop the stack twice when stepOut is called

* Source/DebuggerController.m:
(stepOut): Pop the stack twice

15 years agoStart using our new StackFrame and StackController classes as struts
Robert Sesek [Mon, 1 Dec 2008 01:19:28 +0000 (20:19 -0500)]
Start using our new StackFrame and StackController classes as struts

* Source/DebuggerController.h: Add the stackController ivar
* Source/DebuggerController.m:
(init): Initialize the stackController
(dealloc): Release stackController
(stepIn:): Pop and push the stackController appropriately
(stepOut:): ditto
(stepOver:): ditto
* Source/GDBpConnection.h: -[stepIn] -[stepOut] and -[stepOver] now all return StackFrame objects
* Source/GDBpConnection.m:
(stepIn): Generate and return the frame
(stepOut): ditto
(stepOver): ditto
(createStackFrame): New private method
* Source/StackController.m+h:
(peek): New method
* Source/StackFrame.m+h:
(isShiftedFrame:): New method
(description): Implemented

15 years agoRefactor the DebuggerController's "stackController" ivar to be named "stackController2"
Robert Sesek [Mon, 1 Dec 2008 00:15:54 +0000 (19:15 -0500)]
Refactor the DebuggerController's "stackController" ivar to be named "stackController2"

15 years agoAdd the StackController class
Robert Sesek [Mon, 1 Dec 2008 00:09:23 +0000 (19:09 -0500)]
Add the StackController class

* Source/StackController.m+h: New files
* MacGDBp.xcodeproj: Project updates for new files

15 years agoAdding the StackFrame class
Robert Sesek [Sun, 30 Nov 2008 23:52:14 +0000 (18:52 -0500)]
Adding the StackFrame class

* Source/StackFrame.m+h: New files
* MacGDBp.xcodeproj: Project updates

15 years agoReorganize the project files to separate connection from debugger classes
Robert Sesek [Sat, 15 Nov 2008 17:20:51 +0000 (12:20 -0500)]
Reorganize the project files to separate connection from debugger classes

* MacGDBp.xcodeproj

15 years agoUpdate version number 1.1.2
Robert Sesek [Tue, 14 Oct 2008 01:47:23 +0000 (21:47 -0400)]
Update version number

* Info.plist

15 years agoHave the debugger and breakpoints windows remember their size and location
Robert Sesek [Mon, 13 Oct 2008 15:05:16 +0000 (11:05 -0400)]
Have the debugger and breakpoints windows remember their size and location

* English.lproj/Breakpoints.xib: Set autosave name
* English.lproj/Debugger.xib: ditto
* Source/DebuggerController.m:
(awakeFromNib): Do not call [window center] anymore

15 years agoSaved breakpoints (or any breakpoint) that had a file that does not exist would crash...
Robert Sesek [Mon, 13 Oct 2008 14:07:47 +0000 (10:07 -0400)]
Saved breakpoints (or any breakpoint) that had a file that does not exist would crash MacGDBp

* Source/BSSourceView.m:
(setFile:): If the file does not exist, simply display an empty string
(scrollToLine:): If the file does not exist, return

15 years agoUpdate the version to 1.1.1 1.1.1
Robert Sesek [Wed, 20 Aug 2008 18:53:44 +0000 (14:53 -0400)]
Update the version to 1.1.1

* Info.plist

15 years agoAllow multiple selection and removal of breakpoints
Robert Sesek [Wed, 20 Aug 2008 18:50:17 +0000 (14:50 -0400)]
Allow multiple selection and removal of breakpoints

* English.lproj/Breakpoints.xib: Allow multiple selection
* Source/BreakpointController.m:
(removeBreakpoint:): Remove the selection's entirety, instead of the first element

15 years agoFix a bug where breakpoints would be recreated exponentially after their removal
Robert Sesek [Wed, 20 Aug 2008 18:47:50 +0000 (14:47 -0400)]
Fix a bug where breakpoints would be recreated exponentially after their removal

* Source/BreakpointManager.m:
(removeBreakpointAt:inFile:): Need to call -[removeObject:] instead of -[addObject:]

15 years agoAdd the bug numbers to the change log 1.1
Robert Sesek [Mon, 4 Aug 2008 17:00:11 +0000 (13:00 -0400)]
Add the bug numbers to the change log

* CHANGES

15 years agoPreferences should be set in +load rather than +initialize, as we can’t rely on AppDe...
Ciarán Walsh [Tue, 15 Jul 2008 07:40:07 +0000 (08:40 +0100)]
Preferences should be set in +load rather than +initialize, as we can’t rely on AppDelegate receiving a message before any other objects (In this case, DebuggerController was being created first, leading to sockets without the correct default port number).

* Source/AppDelegate.m:
(initialize): Change to load

15 years agoChanging the version to be 1.1
Robert Sesek [Fri, 1 Aug 2008 17:23:04 +0000 (13:23 -0400)]
Changing the version to be 1.1

* Info.plist

15 years agoKeep breakpoints in the preferences so they are restored at launch
Robert Sesek [Fri, 1 Aug 2008 17:21:57 +0000 (13:21 -0400)]
Keep breakpoints in the preferences so they are restored at launch

* Source/BreakpointManager.m+h: Add a savedBreakpoints ivar to hold the dictionarys
(addBreakpoint:): Add the breakpoint to the NSUserDefaults
(removeBreakpointAt:inFile:): Remove the breakpoint from NSUserDefaults

15 years agoAdd a CHANGES file to manage the change log
Robert Sesek [Wed, 30 Jul 2008 16:21:36 +0000 (12:21 -0400)]
Add a CHANGES file to manage the change log

* CHANGES

15 years agoFixing a memory leak
Robert Sesek [Tue, 15 Jul 2008 14:47:18 +0000 (10:47 -0400)]
Fixing a memory leak

* Source/DebuggerController.m:
(gutterClickedAtLine:forFile:): The breakpoint (bp) sent to BreakpointManager is over-retained

15 years agoCheck and see if stderr has any data on it when syntax highlighting. If so, only...
Robert Sesek [Mon, 14 Jul 2008 19:13:34 +0000 (15:13 -0400)]
Check and see if stderr has any data on it when syntax highlighting. If so, only show plain text.

* Source/BSSourceView.m:
(initWithFrame): Register to be an observer of the file handle reader notification
(setFile:): Add another pipe for stderr, and read in background from it
(errorHighlightingFile:): New method to handle the notification

15 years agoCode formatting
Robert Sesek [Mon, 14 Jul 2008 17:06:59 +0000 (13:06 -0400)]
Code formatting

15 years agoRenaming NSXMLElementAdditions(NSXMLElementAdditions) to be NSXMLElementAdditions...
Robert Sesek [Mon, 14 Jul 2008 16:16:31 +0000 (12:16 -0400)]
Renaming NSXMLElementAdditions(NSXMLElementAdditions) to be NSXMLElementAdditions(GDBpAdditions)

15 years agoRenaming BreakpointWindowController to BreakpointController
Robert Sesek [Mon, 14 Jul 2008 16:15:39 +0000 (12:15 -0400)]
Renaming BreakpointWindowController to BreakpointController

15 years agoRenaming DebuggerConnection to GDBpConnection
Robert Sesek [Mon, 14 Jul 2008 16:14:04 +0000 (12:14 -0400)]
Renaming DebuggerConnection to GDBpConnection

15 years agoRenaming DebuggerWindowController to DebuggerController
Robert Sesek [Mon, 14 Jul 2008 16:12:10 +0000 (12:12 -0400)]
Renaming DebuggerWindowController to DebuggerController

15 years agoAdd IBOutlets for both DebuggerWindowController and BreakpointWindowController
Robert Sesek [Mon, 14 Jul 2008 16:07:41 +0000 (12:07 -0400)]
Add IBOutlets for both DebuggerWindowController and BreakpointWindowController

* Source/AppDelegate.h: Add the IBOutlets
* English.lproj/MainMenu.xib: Hook up the IBOs

15 years ago-[SocketWrapper(Private) error:] would send message to a non-existent selector
Robert Sesek [Mon, 14 Jul 2008 15:49:29 +0000 (11:49 -0400)]
-[SocketWrapper(Private) error:] would send message to a non-existent selector

* Source/SocketWrapper.m:
(error:): [errorEncountered:] has been replaced with [setError:]

15 years agoThe subviews of BSSourceView were over-retained
Robert Sesek [Mon, 14 Jul 2008 15:44:20 +0000 (11:44 -0400)]
The subviews of BSSourceView were over-retained

* Source/BSSourceView.m:
(dealloc): Call [removeFromSuperview] on the subviews

15 years agoUpdate the version to 1.1 Beta 1
Robert Sesek [Mon, 14 Jul 2008 13:12:02 +0000 (09:12 -0400)]
Update the version to 1.1 Beta 1

15 years agoFix build errors. Properties cannot be synthesized if they are defined in a category
Robert Sesek [Mon, 14 Jul 2008 13:10:15 +0000 (09:10 -0400)]
Fix build errors. Properties cannot be synthesized if they are defined in a category

* Source/SocketWrapper.m

15 years agoMerge branch 'memory-fixes'
Robert Sesek [Mon, 14 Jul 2008 12:56:38 +0000 (08:56 -0400)]
Merge branch 'memory-fixes'

15 years agoValidate user interface items for the Debugger menu
Robert Sesek [Sun, 13 Jul 2008 23:36:10 +0000 (19:36 -0400)]
Validate user interface items for the Debugger menu

* Source/DebuggerWindowController.m:
(init): Set self to be [self window]'s delegate
(validateUserInterfaceItem:): New method

15 years agoFixing a bug in -[SocketWrapper receive] that could miss up to the last 8 bytes of...
Robert Sesek [Sun, 13 Jul 2008 16:43:38 +0000 (12:43 -0400)]
Fixing a bug in -[SocketWrapper receive] that could miss up to the last 8 bytes of a response

* Source/SocketWrapper.m:
(receive): A multi-packet response could be incomplete by a difference of 8 bytes because we didn't factor in packetLength when counting

15 years agoAdd a call to NSAssert() to stop us if we receive incomplete packets from SocketWrapper
Robert Sesek [Sun, 13 Jul 2008 15:29:26 +0000 (11:29 -0400)]
Add a call to NSAssert() to stop us if we receive incomplete packets from SocketWrapper

* Source/SocketWrapper.m:
(receive): Assert that the packet is a complete XML document

15 years agoA few miscellaneous memory management fixes
Ciarán Walsh [Wed, 25 Jun 2008 00:01:25 +0000 (01:01 +0100)]
A few miscellaneous memory management fixes

* Source/BSSourceView.m:
(setFile:): Autorelease the NSTask and release the NSAttributedString
* Source/BSSplitView.m:
(drawDividerInRect:): Release the NSGradient after drawing
* Source/Breakpoint.m:
(initWithDictionary:): Retain the file object
* Source/BreakpointManager.m:
(hasBreakpointAtLine:inFile:): Autorelease the object we send to [containsObject:]

15 years agoThe -connect: method would leak memory when called more than once
Ciarán Walsh [Wed, 25 Jun 2008 00:00:43 +0000 (01:00 +0100)]
The -connect: method would leak memory when called more than once

* Source/SocketWrapper.m: Add a private prop for the hostname
(remoteHost): Removed through use of a prop
(connect:): Change from alloc'ing an NSString to creating an autorelease'd one

15 years agoA crash would occur in the event that -setFile: was called with the same path string...
Ciarán Walsh [Tue, 24 Jun 2008 23:24:44 +0000 (00:24 +0100)]
A crash would occur in the event that -setFile: was called with the same path string object as is currently own

* Source/BSSourceView.m:
(setFile:)

15 years agoSending messages to nil is always safe (a no-op)
Ciarán Walsh [Tue, 24 Jun 2008 23:23:15 +0000 (00:23 +0100)]
Sending messages to nil is always safe (a no-op)

* Source/BSSourceView.m:
(dealloc): Don't need to check and see if file is nil before [release]

15 years agoMerge branch 'menu-validation'
Robert Sesek [Sun, 13 Jul 2008 23:45:10 +0000 (19:45 -0400)]
Merge branch 'menu-validation'

Conflicts:

English.lproj/MainMenu.xib: Took HEAD XIB and copied branch XIB's Debugger menu manually

15 years agoValidate user interface items for the Debugger menu
Robert Sesek [Sun, 13 Jul 2008 23:36:10 +0000 (19:36 -0400)]
Validate user interface items for the Debugger menu

* Source/DebuggerWindowController.m:
(init): Set self to be [self window]'s delegate
(validateUserInterfaceItem:): New method

15 years agoFixing a bug in -[SocketWrapper receive] that could miss up to the last 8 bytes of...
Robert Sesek [Sun, 13 Jul 2008 16:43:38 +0000 (12:43 -0400)]
Fixing a bug in -[SocketWrapper receive] that could miss up to the last 8 bytes of a response

* Source/SocketWrapper.m:
(receive): A multi-packet response could be incomplete by a difference of 8 bytes because we didn't factor in packetLength when counting

15 years agoAdd a call to NSAssert() to stop us if we receive incomplete packets from SocketWrapper
Robert Sesek [Sun, 13 Jul 2008 15:29:26 +0000 (11:29 -0400)]
Add a call to NSAssert() to stop us if we receive incomplete packets from SocketWrapper

* Source/SocketWrapper.m:
(receive): Assert that the packet is a complete XML document

15 years agoAdding the "Debugger" menu to the NIB file and hooking up the actions for them
Robert Sesek [Thu, 10 Jul 2008 11:41:52 +0000 (07:41 -0400)]
Adding the "Debugger" menu to the NIB file and hooking up the actions for them

* English.lproj/MainMenu.xib

15 years agoTracking the Italian versin of Sparkle
Robert Sesek [Thu, 10 Jul 2008 11:34:35 +0000 (07:34 -0400)]
Tracking the Italian versin of Sparkle

* Sparkle.framework/Versions/A/Resources/it.lproj/: Add

15 years agoAdd the Sparkle keys to Info.plist
Robert Sesek [Thu, 10 Jul 2008 11:29:11 +0000 (07:29 -0400)]
Add the Sparkle keys to Info.plist

* Info.plist

15 years agoHook up the "Check for updates..." menu item
Robert Sesek [Thu, 10 Jul 2008 11:15:49 +0000 (07:15 -0400)]
Hook up the "Check for updates..." menu item

* English.lproj/MainMenu.xib

15 years agoUpdating Sparkle to use a version that uses CFBundleShortVersionString for comparisio...
Robert Sesek [Thu, 10 Jul 2008 11:13:44 +0000 (07:13 -0400)]
Updating Sparkle to use a version that uses CFBundleShortVersionString for comparision instead of CFBundleVersion

* Sparkle.framework/

15 years agoRemove the old version checking system that we wrote ourselves
Robert Sesek [Wed, 9 Jul 2008 17:58:00 +0000 (13:58 -0400)]
Remove the old version checking system that we wrote ourselves

* Source/AppDelegate.m+h: Removed updater outlets
(applicationDidFinishLaunching:): Removed
(versionCheck:): Removed
(openUpdateInformation:): Removed
* English.lproj/MainMenu.xib: Removed the update window

15 years agoAdd Sparkle framework and hook it up (except for the appcast URL)
Robert Sesek [Wed, 9 Jul 2008 17:54:08 +0000 (13:54 -0400)]
Add Sparkle framework and hook it up (except for the appcast URL)

* English.lproj/MainMenu.xib: Instantiate the SUUpdater
* MacGDBp.xcodeproj: Add a build phase and link against Sparkle.framework
* Sparkle.framewokr/: New files

15 years agoInstantiate the Debugger and Breakpoint controllers in the NIB rather than in code
Robert Sesek [Wed, 9 Jul 2008 17:45:02 +0000 (13:45 -0400)]
Instantiate the Debugger and Breakpoint controllers in the NIB rather than in code

* English.lproj/MainMenu.xib: Instantiate DebuggerWindowController and BreakpointWindowController
* Source/AppDelegate.m:
(applicationDidFinishLaunching:): Remove the two object init lines

15 years agoUse prefernce values to set the port and IDE key, rather than hard-coded values
Robert Sesek [Wed, 9 Jul 2008 17:39:55 +0000 (13:39 -0400)]
Use prefernce values to set the port and IDE key, rather than hard-coded values

* Source/DebuggerWindowController.m+h:
(initWithPort:session:): Renamed to -[init] and use preference values to set the port and IDE key
* Source/AppDelegate.m:
(applicationDidFinishLaunching:): Simply call init on DebuggerWindowController

15 years agoAdd a warning that says to close and reopen MacGDBp after changing pref values
Robert Sesek [Wed, 9 Jul 2008 17:31:42 +0000 (13:31 -0400)]
Add a warning that says to close and reopen MacGDBp after changing pref values

* English.lproj/Preferences.xib

15 years agoBind the preference inputs to the NSUserDefaultsController
Robert Sesek [Wed, 9 Jul 2008 17:29:47 +0000 (13:29 -0400)]
Bind the preference inputs to the NSUserDefaultsController

* English.lproj/Preferences.xib

15 years agoSetting the default values for NSUserDefaults
Robert Sesek [Wed, 9 Jul 2008 17:27:06 +0000 (13:27 -0400)]
Setting the default values for NSUserDefaults

* Source/AppDelegate.m:
(initialize): Register the default preferences dict

15 years agoLaying out the user interface for the preferences window
Robert Sesek [Wed, 9 Jul 2008 17:09:56 +0000 (13:09 -0400)]
Laying out the user interface for the preferences window

* English.lproj/Preferences.xib

15 years agoAdding an empty preferences window and controller. Hooking up the Preferences menu...
Robert Sesek [Wed, 9 Jul 2008 17:05:14 +0000 (13:05 -0400)]
Adding an empty preferences window and controller. Hooking up the Preferences menu item.

* English.lproj/MainMenu.xib: Hooking up the Preferences menu item
* English.lproj/Preferences.xib: New file
* Source/PreferencesController.m+h: New files
* Source/AppDelegate.m+h: Adding an ivar for the PreferencesController
(showPreferences:): New method
* MacGDBp.xcodeproj: Project updates for new files

15 years agoMerge branch 'bug-125' 1.0.1
Robert Sesek [Mon, 23 Jun 2008 13:45:46 +0000 (09:45 -0400)]
Merge branch 'bug-125'

Conflicts:

Source/BSSourceView.m

15 years agoInstead of using the "stopping" status, just use "Stopped" for both itself and "stopping"
Robert Sesek [Mon, 23 Jun 2008 13:28:49 +0000 (09:28 -0400)]
Instead of using the "stopping" status, just use "Stopped" for both itself and "stopping"

* Source/DebuggerConnection.m:
(refreshStatus)

15 years agoClose the connection when we receive the "stopping" status. Fixes bug://report/125
Robert Sesek [Sun, 22 Jun 2008 16:25:05 +0000 (12:25 -0400)]
Close the connection when we receive the "stopping" status. Fixes bug://report/125

* Source/DebuggerConnection.m:
(refreshStatus): The "stopped" and "stopping" statuses should have the same effect now