macgdbp.git
13 years agoWe need to set self.attached before referencing it. 1.4.0.85
Robert Sesek [Sat, 26 Feb 2011 19:20:05 +0000 (14:20 -0500)]
We need to set self.attached before referencing it.

13 years agoRemove one more NSLog. 1.4
Robert Sesek [Sat, 26 Feb 2011 17:28:34 +0000 (12:28 -0500)]
Remove one more NSLog.

13 years agoRemove some NSLog statements
Robert Sesek [Sat, 26 Feb 2011 17:19:35 +0000 (12:19 -0500)]
Remove some NSLog statements

13 years agoClose and reopen the connection when toggling the attached state.
Robert Sesek [Sat, 26 Feb 2011 17:14:51 +0000 (12:14 -0500)]
Close and reopen the connection when toggling the attached state.

13 years agoMove dealing with the socket into NetworkCallbackController.
Robert Sesek [Sat, 19 Feb 2011 17:40:42 +0000 (12:40 -0500)]
Move dealing with the socket into NetworkCallbackController.

13 years agoRemove beta moniker and unstable info from Info.plist.
Robert Sesek [Tue, 25 Jan 2011 19:44:20 +0000 (14:44 -0500)]
Remove beta moniker and unstable info from Info.plist.

13 years agoRemove NSLog()
Robert Sesek [Sat, 15 Jan 2011 05:35:58 +0000 (00:35 -0500)]
Remove NSLog()

13 years agoAdd code to the AppDelegate to record if a user has ever used an unstable VersionCast... 1.4-beta-2
Robert Sesek [Sat, 15 Jan 2011 04:43:48 +0000 (23:43 -0500)]
Add code to the AppDelegate to record if a user has ever used an unstable VersionCast feed

13 years agoRemove some dead code in -[NetworkConnection socketDisconnected]
Robert Sesek [Sat, 15 Jan 2011 04:33:16 +0000 (23:33 -0500)]
Remove some dead code in -[NetworkConnection socketDisconnected]

13 years agoFix a typo
Robert Sesek [Fri, 14 Jan 2011 14:56:29 +0000 (09:56 -0500)]
Fix a typo

13 years agoThe attached state is now persisted to preferences.
Robert Sesek [Thu, 6 Jan 2011 17:45:42 +0000 (12:45 -0500)]
The attached state is now persisted to preferences.

13 years agoUpdate changelog
Robert Sesek [Thu, 6 Jan 2011 17:38:20 +0000 (12:38 -0500)]
Update changelog

13 years agoDisallow sorting and selection of columns in the Connection Log.
Robert Sesek [Thu, 6 Jan 2011 14:31:09 +0000 (09:31 -0500)]
Disallow sorting and selection of columns in the Connection Log.

13 years agoHandle sending the |detach| command when not attached in |-handleInitialResponse...
Robert Sesek [Thu, 6 Jan 2011 14:26:08 +0000 (09:26 -0500)]
Handle sending the |detach| command when not attached in |-handleInitialResponse:| not |-connectionDidAccept:|.

13 years agoUpdate the changelog
Robert Sesek [Thu, 6 Jan 2011 14:15:15 +0000 (09:15 -0500)]
Update the changelog

13 years agoDon't use [connection attached] as a condition on which to validate the Stop item.
Robert Sesek [Thu, 6 Jan 2011 14:13:39 +0000 (09:13 -0500)]
Don't use [connection attached] as a condition on which to validate the Stop item.

13 years agoAdd an Attached menu item and give it a keyboard shortcut.
Robert Sesek [Thu, 6 Jan 2011 14:08:19 +0000 (09:08 -0500)]
Add an Attached menu item and give it a keyboard shortcut.

This also binds that item and the attached toolbar item to connection.attached
so both update their UI automatically.

13 years agoChange the version number to 1.4 Beta 2.
Robert Sesek [Thu, 6 Jan 2011 06:43:35 +0000 (01:43 -0500)]
Change the version number to 1.4 Beta 2.

13 years agoSet the key equivalent for the remove breakpoint button to be the backspace key.
Robert Sesek [Thu, 6 Jan 2011 06:26:24 +0000 (01:26 -0500)]
Set the key equivalent for the remove breakpoint button to be the backspace key.

13 years agoAdd a second bug number to the "Stop" button change
Robert Sesek [Thu, 6 Jan 2011 03:28:17 +0000 (22:28 -0500)]
Add a second bug number to the "Stop" button change

13 years agoFormally define BSSourceViewDelegate as a protocol.
Robert Sesek [Thu, 6 Jan 2011 03:20:36 +0000 (22:20 -0500)]
Formally define BSSourceViewDelegate as a protocol.

13 years agoAdd drag and drop support on BSSourceView and enable it in the BreakpointController.
Robert Sesek [Thu, 6 Jan 2011 03:16:34 +0000 (22:16 -0500)]
Add drag and drop support on BSSourceView and enable it in the BreakpointController.

13 years agoRevert "Stub out the methods needed for drag and drop on the breakpoint table view."
Robert Sesek [Thu, 6 Jan 2011 02:54:31 +0000 (21:54 -0500)]
Revert "Stub out the methods needed for drag and drop on the breakpoint table view."

This reverts commit d0a336076f5e432b2fe52db4b5f4b10cc37b69cc.

13 years agoRevert "Add drag and drop for the table view."
Robert Sesek [Thu, 6 Jan 2011 02:54:29 +0000 (21:54 -0500)]
Revert "Add drag and drop for the table view."

This reverts commit 7a8a10f2673ce531fcb38cfec89a04991bbe09c0.

13 years agoAdd drag and drop for the table view.
Robert Sesek [Thu, 6 Jan 2011 02:53:16 +0000 (21:53 -0500)]
Add drag and drop for the table view.

13 years agoStub out the methods needed for drag and drop on the breakpoint table view.
Robert Sesek [Thu, 6 Jan 2011 02:28:24 +0000 (21:28 -0500)]
Stub out the methods needed for drag and drop on the breakpoint table view.

13 years agoFix a warning.
Robert Sesek [Thu, 6 Jan 2011 02:18:41 +0000 (21:18 -0500)]
Fix a warning.

13 years agoHappy new year!
Robert Sesek [Thu, 6 Jan 2011 02:15:09 +0000 (21:15 -0500)]
Happy new year!

13 years agoRemoved some extra braces and add a comment for NetworkConnection(Private)
Robert Sesek [Thu, 6 Jan 2011 02:10:39 +0000 (21:10 -0500)]
Removed some extra braces and add a comment for NetworkConnection(Private)

13 years agoAdd a Stop menu item.
Robert Sesek [Thu, 6 Jan 2011 02:08:42 +0000 (21:08 -0500)]
Add a Stop menu item.

13 years agoSplit out changes for the different 1.4 betas.
Robert Sesek [Thu, 6 Jan 2011 01:56:33 +0000 (20:56 -0500)]
Split out changes for the different 1.4 betas.

13 years agoAdd a "stop" button to the toolbar that detaches the debugger from the backend for...
Robert Sesek [Wed, 5 Jan 2011 23:42:05 +0000 (18:42 -0500)]
Add a "stop" button to the toolbar that detaches the debugger from the backend for the current session.

13 years agoRemove two warnings about using deprecated |+[NSString stringWithContentsOfFile:]|.
Robert Sesek [Fri, 24 Dec 2010 19:27:53 +0000 (14:27 -0500)]
Remove two warnings about using deprecated |+[NSString stringWithContentsOfFile:]|.

13 years agoFix formatting that Xcode bodged.
Robert Sesek [Fri, 24 Dec 2010 19:05:56 +0000 (14:05 -0500)]
Fix formatting that Xcode bodged.

13 years agoSplit out the C++ class into its own file. Also move NetworkConnection's private...
Robert Sesek [Fri, 24 Dec 2010 18:53:56 +0000 (13:53 -0500)]
Split out the C++ class into its own file. Also move NetworkConnection's private interface out.

13 years agoUse a C++ class to handle the CFNetwork events, rather than plain C functions.
Robert Sesek [Fri, 24 Dec 2010 18:29:35 +0000 (13:29 -0500)]
Use a C++ class to handle the CFNetwork events, rather than plain C functions.

13 years agoForgot to check in modp_b64/. Oops.
Robert Sesek [Fri, 24 Dec 2010 16:39:55 +0000 (11:39 -0500)]
Forgot to check in modp_b64/. Oops.

13 years agoDrop in Sparkle 1.5b6 so that it doesn't crash on relaunch anymore.
Robert Sesek [Fri, 24 Dec 2010 16:38:40 +0000 (11:38 -0500)]
Drop in Sparkle 1.5b6 so that it doesn't crash on relaunch anymore.

13 years agoDon't fetch source in |-[DebuggerBackEnd loadStackFrame:]| for empy filenames.
Robert Sesek [Fri, 24 Dec 2010 16:29:13 +0000 (11:29 -0500)]
Don't fetch source in |-[DebuggerBackEnd loadStackFrame:]| for empy filenames.
Doing so wedges the write queue because the error comes back without a transasction ID.

13 years agoAdd a hack to get |-expandVariables| working.
Robert Sesek [Fri, 24 Dec 2010 00:41:36 +0000 (19:41 -0500)]
Add a hack to get |-expandVariables| working.

13 years agoAdd a |-description| for VariableNode.
Robert Sesek [Fri, 24 Dec 2010 00:23:15 +0000 (19:23 -0500)]
Add a |-description| for VariableNode.

13 years agoUpdate changelong for 1.4 1.4-beta-1
Robert Sesek [Sat, 18 Dec 2010 19:35:59 +0000 (14:35 -0500)]
Update changelong for 1.4

13 years agoUse the unstable AppCast URL.
Robert Sesek [Sat, 18 Dec 2010 19:04:26 +0000 (14:04 -0500)]
Use the unstable AppCast URL.

13 years agoRenaming because there's too many Debugger* classes
Robert Sesek [Sat, 18 Dec 2010 18:24:47 +0000 (13:24 -0500)]
Renaming because there's too many Debugger* classes
DebuggerProcessor -> DebuggerBackEnd
DebuggerConnection -> NetworkConnection

13 years agoMove -[DebuggerConnection send:] to the private interface because it isn't threadsafe.
Robert Sesek [Sat, 18 Dec 2010 18:04:38 +0000 (13:04 -0500)]
Move -[DebuggerConnection send:] to the private interface because it isn't threadsafe.

13 years agoPlug a bunch of leaks by implementing -[StackFrame dealloc]
Robert Sesek [Sat, 18 Dec 2010 17:54:48 +0000 (12:54 -0500)]
Plug a bunch of leaks by implementing -[StackFrame dealloc]

13 years agoMerge -[DebuggerController startDebugger] and |-debuggerConnected|.
Robert Sesek [Sat, 18 Dec 2010 17:32:54 +0000 (12:32 -0500)]
Merge -[DebuggerController startDebugger] and |-debuggerConnected|.

13 years agoUpdate Info.plist for Beta 1.
Robert Sesek [Fri, 17 Dec 2010 17:02:33 +0000 (12:02 -0500)]
Update Info.plist for Beta 1.

13 years agoAdd missing |-[super dealloc]| in LoggingController.
Robert Sesek [Fri, 17 Dec 2010 17:01:34 +0000 (12:01 -0500)]
Add missing |-[super dealloc]| in LoggingController.

13 years agoFix a warning about a non-synthesized setter being marked atomic.
Robert Sesek [Fri, 17 Dec 2010 16:34:33 +0000 (11:34 -0500)]
Fix a warning about a non-synthesized setter being marked atomic.

13 years agoSwitch out base64 decoders. Also memset the destination string so that there's no...
Robert Sesek [Fri, 17 Dec 2010 16:31:49 +0000 (11:31 -0500)]
Switch out base64 decoders. Also memset the destination string so that there's no garbage data in the result.

13 years agoRemove the remote host from the title.
Robert Sesek [Fri, 17 Dec 2010 16:13:43 +0000 (11:13 -0500)]
Remove the remote host from the title.

13 years agoOpen the help page with HTTPS.
Robert Sesek [Thu, 16 Dec 2010 15:19:18 +0000 (10:19 -0500)]
Open the help page with HTTPS.

13 years agoIn -[DebuggerController debuggerConnected], do not do anything if we're not attached.
Robert Sesek [Thu, 16 Dec 2010 14:28:24 +0000 (09:28 -0500)]
In -[DebuggerController debuggerConnected], do not do anything if we're not attached.

13 years agoRemove verbose logging from SocketAcceptCallback()
Robert Sesek [Thu, 16 Dec 2010 14:23:24 +0000 (09:23 -0500)]
Remove verbose logging from SocketAcceptCallback()

13 years ago* Store the DebuggerAttached value in the preferences
Robert Sesek [Thu, 16 Dec 2010 14:18:41 +0000 (09:18 -0500)]
* Store the DebuggerAttached value in the preferences
* Respect the attached checkbox on start

13 years ago* Remove the AutoReconnect preference item now that reconnecting is a thing of the...
Robert Sesek [Thu, 16 Dec 2010 14:11:43 +0000 (09:11 -0500)]
* Remove the AutoReconnect preference item now that reconnecting is a thing of the past
* Remove Icons/Reconnect.png

13 years agoDo away with the concept of "reconnect" and use a checbox for attached/detached state.
Robert Sesek [Thu, 16 Dec 2010 14:06:59 +0000 (09:06 -0500)]
Do away with the concept of "reconnect" and use a checbox for attached/detached state.

* |-[DebuggerConnectionDelegate connectionDidAccept:]| now actually gets signaled
* When the debugger is in "detached" mode, it will automatically reject new client sockets.

13 years agoUpdate the API for loading properties to just pass around VariableNode pointers,...
Robert Sesek [Mon, 22 Nov 2010 12:54:30 +0000 (07:54 -0500)]
Update the API for loading properties to just pass around VariableNode pointers, rather than string names.

13 years agoFix reconnect feature by resetting the last txR and txW values.
Robert Sesek [Sun, 31 Oct 2010 23:44:48 +0000 (19:44 -0400)]
Fix reconnect feature by resetting the last txR and txW values.

13 years agoDo not ever close the socket until we are definitely closing the connection. We can...
Robert Sesek [Sun, 31 Oct 2010 23:28:20 +0000 (19:28 -0400)]
Do not ever close the socket until we are definitely closing the connection. We can't reuse the same socket fast enough.

13 years agoTry to make socket reuse more robust. It isn't working.
Robert Sesek [Sun, 31 Oct 2010 19:51:11 +0000 (15:51 -0400)]
Try to make socket reuse more robust. It isn't working.

13 years agoDo not ever spawn more than 1 network thread.
Robert Sesek [Sun, 31 Oct 2010 19:27:07 +0000 (15:27 -0400)]
Do not ever spawn more than 1 network thread.

13 years agoProperly quit the run loop. For some reason, calling -[NSRunLoop run] doesn't work...
Robert Sesek [Sun, 31 Oct 2010 17:33:35 +0000 (13:33 -0400)]
Properly quit the run loop. For some reason, calling -[NSRunLoop run] doesn't work with CFRunLoopStop(). Activate it with CFRunLoopRun() instead.

13 years agoAdd a quit source to the DebuggerConnection's run loop to properly handle closing.
Robert Sesek [Sun, 31 Oct 2010 17:04:48 +0000 (13:04 -0400)]
Add a quit source to the DebuggerConnection's run loop to properly handle closing.

13 years agoProperly set the |connected_| flag in the Connection to NO when we're stopped. Preven...
Robert Sesek [Sun, 31 Oct 2010 16:18:20 +0000 (12:18 -0400)]
Properly set the |connected_| flag in the Connection to NO when we're stopped. Prevents an EXC_BAD_ACCESS on |-run:|.

13 years agoRename |-connectInternal| to |-connectionThreadStart|.
Robert Sesek [Sun, 31 Oct 2010 16:13:45 +0000 (12:13 -0400)]
Rename |-connectInternal| to |-connectionThreadStart|.

13 years agoRemove 2 super verbose NSLog() statements.
Robert Sesek [Sun, 31 Oct 2010 16:11:23 +0000 (12:11 -0400)]
Remove 2 super verbose NSLog() statements.

13 years agoSwitch to using VariableNode in the interface. Reduce use of NSXMLElementAdditions...
Robert Sesek [Sun, 31 Oct 2010 16:09:03 +0000 (12:09 -0400)]
Switch to using VariableNode in the interface. Reduce use of NSXMLElementAdditions to just the key methods.

13 years agoAdd VariableNode which will replace our use of raw NSXMLElement.
Robert Sesek [Sun, 31 Oct 2010 15:24:15 +0000 (11:24 -0400)]
Add VariableNode which will replace our use of raw NSXMLElement.

13 years agoRemove the pending property after it is received.
Robert Sesek [Sun, 31 Oct 2010 14:52:44 +0000 (10:52 -0400)]
Remove the pending property after it is received.

13 years agoInitial work to get properties loading asynchronously. This may have a memory corrupt...
Robert Sesek [Sun, 31 Oct 2010 14:48:36 +0000 (10:48 -0400)]
Initial work to get properties loading asynchronously. This may have a memory corruption bug at the moment...

13 years agoAdd a singleton |+instance| method to AppDelegate so we don't cast everywhere.
Robert Sesek [Sun, 31 Oct 2010 14:26:51 +0000 (10:26 -0400)]
Add a singleton |+instance| method to AppDelegate so we don't cast everywhere.

13 years agoStop crashing with EXC_BAD_ACCESS when expanding properties beyond the fetched depth.
Robert Sesek [Sun, 31 Oct 2010 14:23:52 +0000 (10:23 -0400)]
Stop crashing with EXC_BAD_ACCESS when expanding properties beyond the fetched depth.

13 years agoMake logging threadsafe.
Robert Sesek [Sun, 31 Oct 2010 14:13:22 +0000 (10:13 -0400)]
Make logging threadsafe.

13 years agoTabs to spaces.
Robert Sesek [Sun, 31 Oct 2010 14:01:01 +0000 (10:01 -0400)]
Tabs to spaces.

13 years agoBegin making DebuggerConnection more threadsafe.
Robert Sesek [Sun, 31 Oct 2010 00:11:01 +0000 (20:11 -0400)]
Begin making DebuggerConnection more threadsafe.

13 years agoXcode project file updates.
Robert Sesek [Sat, 30 Oct 2010 22:07:24 +0000 (18:07 -0400)]
Xcode project file updates.

13 years agoMake StackFrame a dumb data structure and remove its initializer. All properties...
Robert Sesek [Fri, 9 Jul 2010 03:59:39 +0000 (23:59 -0400)]
Make StackFrame a dumb data structure and remove its initializer. All properties are now read-write.

This fixes two warnings produced by Clang-SA and avoids sticking an |+alloc|ed but non-
|-init...|ed class inside the |stackFrames_| array.

13 years agoDon't drain the pool, just release it.
Robert Sesek [Sat, 19 Jun 2010 17:20:45 +0000 (13:20 -0400)]
Don't drain the pool, just release it.

13 years agoLazily load the complete stack frame for anything but the current one.
Robert Sesek [Sat, 19 Jun 2010 16:26:58 +0000 (12:26 -0400)]
Lazily load the complete stack frame for anything but the current one.

13 years ago* In StackController, don't update the frame indices when |-push:|- or |-pop|-ing.
Robert Sesek [Sat, 19 Jun 2010 16:14:23 +0000 (12:14 -0400)]
* In StackController, don't update the frame indices when |-push:|- or |-pop|-ing.
* Only retreive full stack frame information for frame 0. The other frames will be fetched lazily.

13 years agoGive |-connectInternal| an autorelease pool.
Robert Sesek [Tue, 1 Jun 2010 03:03:02 +0000 (23:03 -0400)]
Give |-connectInternal| an autorelease pool.

13 years agoRe-organize DebuggerConnection to give it some shape and a decent public interface.
Robert Sesek [Tue, 1 Jun 2010 02:49:42 +0000 (22:49 -0400)]
Re-organize DebuggerConnection to give it some shape and a decent public interface.

13 years agoRemove objects from the |callTable_| after handing the response.
Robert Sesek [Tue, 1 Jun 2010 02:37:58 +0000 (22:37 -0400)]
Remove objects from the |callTable_| after handing the response.

13 years agoPut a lock around adding to the write queue in |-send|.
Robert Sesek [Tue, 1 Jun 2010 02:35:32 +0000 (22:35 -0400)]
Put a lock around adding to the write queue in |-send|.

13 years agoMake DebuggerConnection work on a separate thread.
Robert Sesek [Tue, 1 Jun 2010 02:28:14 +0000 (22:28 -0400)]
Make DebuggerConnection work on a separate thread.

13 years agoMove the callTable back into DebuggerProcessor.
Robert Sesek [Tue, 1 Jun 2010 02:20:39 +0000 (22:20 -0400)]
Move the callTable back into DebuggerProcessor.

13 years agoFinished enough of the basic refactoring to get things working.
Robert Sesek [Tue, 1 Jun 2010 00:59:49 +0000 (20:59 -0400)]
Finished enough of the basic refactoring to get things working.

13 years agoAdd a new DebuggerConnection that separates out the socket logic from the handling...
Robert Sesek [Mon, 31 May 2010 23:44:04 +0000 (19:44 -0400)]
Add a new DebuggerConnection that separates out the socket logic from the handling logic.

This compiles, but will most certainly not work. This is just the initial separation of
methods and ivars that needs to be rewired.

13 years agoRename DebuggerConnection to DebuggerProcessor in preparation for the separation...
Robert Sesek [Mon, 31 May 2010 23:20:07 +0000 (19:20 -0400)]
Rename DebuggerConnection to DebuggerProcessor in preparation for the separation between the two.

13 years agoDon't |-send:| if the transactions do not match
Robert Sesek [Mon, 31 May 2010 23:06:26 +0000 (19:06 -0400)]
Don't |-send:| if the transactions do not match

13 years agoReplace strlen() with a loop that we can guarantee.
Robert Sesek [Tue, 4 May 2010 16:37:32 +0000 (12:37 -0400)]
Replace strlen() with a loop that we can guarantee.

13 years agoRewrite |-readStreamHasData| in an effort to make it more robust.
Robert Sesek [Tue, 27 Apr 2010 17:35:15 +0000 (13:35 -0400)]
Rewrite |-readStreamHasData| in an effort to make it more robust.

14 years agoFix some potential bugs and do general cleanup.
Robert Sesek [Wed, 21 Apr 2010 04:40:55 +0000 (00:40 -0400)]
Fix some potential bugs and do general cleanup.

14 years agoRewrite DebuggerConnection's packet handling sytem. The initial version failed
Robert Sesek [Wed, 21 Apr 2010 04:16:49 +0000 (00:16 -0400)]
Rewrite DebuggerConnection's packet handling sytem. The initial version failed
to account for multiple packets in the same stream read.

* Rewrite |-readStreamHasData| to just parse out string packets
* Created |-handlePacket:| to perform the XML parsing and dispatching

14 years ago* Factor out some code for parsing the txnID out of a command into |-transactionIDFro...
Robert Sesek [Thu, 15 Apr 2010 05:21:07 +0000 (01:21 -0400)]
* Factor out some code for parsing the txnID out of a command into |-transactionIDFromCommand:|.
* Change the way we use the write queue, with the aim of producing less into it and starving it infrequently.

14 years agoUse the new VersionCast URL.
Robert Sesek [Thu, 15 Apr 2010 05:06:26 +0000 (01:06 -0400)]
Use the new VersionCast URL.

14 years agoRemove duplicated logic.
Robert Sesek [Thu, 15 Apr 2010 04:56:02 +0000 (00:56 -0400)]
Remove duplicated logic.

14 years agoTry to recover from erroneous XML packets.
Robert Sesek [Thu, 15 Apr 2010 04:40:25 +0000 (00:40 -0400)]
Try to recover from erroneous XML packets.