From d20c3da2f675c641fde3e9cd2f1c27a9fd973aa3 Mon Sep 17 00:00:00 2001 From: Robert Sesek Date: Wed, 20 Aug 2008 14:47:50 -0400 Subject: [PATCH] Fix a bug where breakpoints would be recreated exponentially after their removal * Source/BreakpointManager.m: (removeBreakpointAt:inFile:): Need to call -[removeObject:] instead of -[addObject:] --- CHANGES | 20 +++++++++++++++----- Source/BreakpointManager.m | 2 +- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/CHANGES b/CHANGES index b9c2f52..faf96c5 100644 --- a/CHANGES +++ b/CHANGES @@ -1,20 +1,30 @@ MacGDBp CHANGE LOG ================================================================================ +1.1.1 +##################### +- Fix: Breakpoints that were removed would come back, multiplied upon relaunch + + 1.1 ##################### - New: Add preferences that allow changing of the Xdebug IDE key and port number - Change: Improved software updater via Sparkle -- Fix: Packets from the Xdebug extension would be incorrectly handled in some situations, causing the display to break or crash +- Fix: Packets from the Xdebug extension would be incorrectly handled in some +situations, causing the display to break or crash - New: #123 Add menu items and keyboard shortcuts for the debugger commands -- Fix: Several memory leaks that could, under certain conditions, would cause crashes (thanks to Ciarán Walsh) -- Change: #130 If MacGDBp can't highlight the source code, it will default to using just plain text -- New: Breakpoints are saved into preferences so that they are recreated at launch time +- Fix: Several memory leaks that could, under certain conditions, would cause +crashes (thanks to Ciarán Walsh) +- Change: #130 If MacGDBp can't highlight the source code, it will default to +using just plain text +- New: Breakpoints are saved into preferences so that they are recreated at +launch time 1.0.1 ##################### - New: Source code is now highlighted via the PHP binary (thanks Ciarán Walsh) - New: The breakpoints window is now visible on launch -- Fixed: #125 Some installations would receive a "Stopping" status that MacGDBp did not handle correctly +- Fixed: #125 Some installations would receive a "Stopping" status that MacGDBp +did not handle correctly - Fixed: #125 Crash when adding breakpoints diff --git a/Source/BreakpointManager.m b/Source/BreakpointManager.m index 12a7379..80f2b95 100644 --- a/Source/BreakpointManager.m +++ b/Source/BreakpointManager.m @@ -91,7 +91,7 @@ [breakpoints removeObject:b]; [connection removeBreakpoint:b]; - [savedBreakpoints addObject:[b dictionary]]; + [savedBreakpoints removeObject:[b dictionary]]; [[NSUserDefaults standardUserDefaults] setValue:savedBreakpoints forKey:@"Breakpoints"]; [self updateDisplaysForFile:file]; -- 2.22.5